From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#13402: 24.2.92 pretest: bugs in isearch-yank-line in info page. [Patch] Date: Thu, 21 Feb 2013 12:27:40 +0000 Message-ID: <20130221122739.GA3647@acm.acm> References: <20130110132530.GA2805@acm.acm> <20130214200937.GA3336@acm.acm> <87d2w2ggsh.fsf@mail.jurta.org> <87liapan32.fsf@mail.jurta.org> <20130215132004.GB2907@acm.acm> <87ip5s3tq8.fsf@mail.jurta.org> <20130219145057.GA4377@acm.acm> <87ip5nql4v.fsf@mail.jurta.org> <20130220223759.GA2644@acm.acm> <871ucaiirw.fsf@mail.jurta.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1361449739 25579 80.91.229.3 (21 Feb 2013 12:28:59 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 21 Feb 2013 12:28:59 +0000 (UTC) Cc: 13402@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Feb 21 13:29:21 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1U8VH6-0002Jy-P8 for geb-bug-gnu-emacs@m.gmane.org; Thu, 21 Feb 2013 13:29:20 +0100 Original-Received: from localhost ([::1]:49691 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U8VGm-0006rJ-Fk for geb-bug-gnu-emacs@m.gmane.org; Thu, 21 Feb 2013 07:29:00 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:52824) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U8VGe-0006qv-8p for bug-gnu-emacs@gnu.org; Thu, 21 Feb 2013 07:28:58 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U8VGZ-0008Vw-0I for bug-gnu-emacs@gnu.org; Thu, 21 Feb 2013 07:28:52 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:36149) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U8VGY-0008Vs-Ta for bug-gnu-emacs@gnu.org; Thu, 21 Feb 2013 07:28:46 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1U8VHm-0006nF-Ue for bug-gnu-emacs@gnu.org; Thu, 21 Feb 2013 07:30:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 21 Feb 2013 12:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13402 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 13402-submit@debbugs.gnu.org id=B13402.136144977526042 (code B ref 13402); Thu, 21 Feb 2013 12:30:02 +0000 Original-Received: (at 13402) by debbugs.gnu.org; 21 Feb 2013 12:29:35 +0000 Original-Received: from localhost ([127.0.0.1]:41613 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U8VHL-0006lz-6h for submit@debbugs.gnu.org; Thu, 21 Feb 2013 07:29:35 -0500 Original-Received: from colin.muc.de ([193.149.48.1]:29468 helo=mail.muc.de) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U8VHH-0006lq-Vy for 13402@debbugs.gnu.org; Thu, 21 Feb 2013 07:29:33 -0500 Original-Received: (qmail 90254 invoked by uid 3782); 21 Feb 2013 12:28:13 -0000 Original-Received: from acm.muc.de (pD9519D48.dip.t-dialin.net [217.81.157.72]) by colin.muc.de (tmda-ofmipd) with ESMTP; Thu, 21 Feb 2013 13:28:11 +0100 Original-Received: (qmail 4235 invoked by uid 1000); 21 Feb 2013 12:27:40 -0000 Content-Disposition: inline In-Reply-To: <871ucaiirw.fsf@mail.jurta.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:71591 Archived-At: Hi, Juri. On Thu, Feb 21, 2013 at 02:45:31AM +0200, Juri Linkov wrote: > Fortunately, it is possible to combine both logics > with a small patch that you can see below. > The key point is that the lazy-highlighting loop should start > from the same position where the main search function found > the beginning of the match! Hey, that's brilliant! It simply works, without all the added (or alternative) complexity of my patch. > Currently the boundary of the lazy-highlighting loop starts at the end > of the found match (the value of `(point)'). But the match found by > the main search function (and highlighted by the primary face `isearch') > begins at `isearch-other-end'. So currently they are mutually inconsistent. > This patch moves the boundary of lazy-highlighting from the end > of the found match to its beginning - like in the main search function. > Thus it brings the logic of `isearch-lazy-highlight-search' closer to > the logic of the main search function in `isearch-search'. > In the result of removing this inconsistency, this patch passes > the test case that you posted in your original bug report, > i.e. placing point at the start of the second paragraph > (" Each entry in a ....") and typing `C-s M-s C-e' (isearch-yank-line) > doesn't highlight the gap preceding the paragraph with lazy-highlight face. > And it also passes other tests that I tried. It seems to work for ispell too. What more could one ask for? Can we install this into the emacs-24 branch? It satisfies Glenn's criterion of a week ago, "...and you are sure the fix is safe". -- Alan Mackenzie (Nuremberg, Germany).