From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#13402: 24.2.92 pretest: bugs in isearch-yank-line in info page. [Patch] Date: Fri, 15 Feb 2013 11:55:02 +0000 Message-ID: <20130215115502.GA2907@acm.acm> References: <20130110132530.GA2805@acm.acm> <20130214200937.GA3336@acm.acm> <87d2w2ggsh.fsf@mail.jurta.org> <87liapan32.fsf@mail.jurta.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1360929388 27309 80.91.229.3 (15 Feb 2013 11:56:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 15 Feb 2013 11:56:28 +0000 (UTC) Cc: 13402@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Feb 15 12:56:50 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1U6JuK-0004Dr-2g for geb-bug-gnu-emacs@m.gmane.org; Fri, 15 Feb 2013 12:56:48 +0100 Original-Received: from localhost ([::1]:39608 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U6Ju0-0003HP-I1 for geb-bug-gnu-emacs@m.gmane.org; Fri, 15 Feb 2013 06:56:28 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:47056) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U6Jtw-0003HI-94 for bug-gnu-emacs@gnu.org; Fri, 15 Feb 2013 06:56:26 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U6Jts-0005ln-0w for bug-gnu-emacs@gnu.org; Fri, 15 Feb 2013 06:56:24 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:51729) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U6Jtr-0005li-Tv for bug-gnu-emacs@gnu.org; Fri, 15 Feb 2013 06:56:19 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1U6JuX-00057B-RK for bug-gnu-emacs@gnu.org; Fri, 15 Feb 2013 06:57:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 15 Feb 2013 11:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13402 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 13402-submit@debbugs.gnu.org id=B13402.136092938819617 (code B ref 13402); Fri, 15 Feb 2013 11:57:01 +0000 Original-Received: (at 13402) by debbugs.gnu.org; 15 Feb 2013 11:56:28 +0000 Original-Received: from localhost ([127.0.0.1]:57193 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U6Jtz-00056L-CD for submit@debbugs.gnu.org; Fri, 15 Feb 2013 06:56:28 -0500 Original-Received: from colin.muc.de ([193.149.48.1]:28751 helo=mail.muc.de) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U6Jtw-00056B-1G for 13402@debbugs.gnu.org; Fri, 15 Feb 2013 06:56:25 -0500 Original-Received: (qmail 40690 invoked by uid 3782); 15 Feb 2013 11:55:40 -0000 Original-Received: from acm.muc.de (pD951B3CC.dip.t-dialin.net [217.81.179.204]) by colin.muc.de (tmda-ofmipd) with ESMTP; Fri, 15 Feb 2013 12:55:37 +0100 Original-Received: (qmail 2925 invoked by uid 1000); 15 Feb 2013 11:55:02 -0000 Content-Disposition: inline In-Reply-To: <87liapan32.fsf@mail.jurta.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:71309 Archived-At: Hi, Juri. On Fri, Feb 15, 2013 at 12:10:45PM +0200, Juri Linkov wrote: > >> Here is a patch for this change: > > Thanks, I'll test your patch now. > I noticed one problem: going to the next match with `C-s' > (isearch-repeat-forward) doesn't lazy-highlight the previous match > that was unhighlighted. The previous match needs to be re-highlighted > and the next match unhighlighted. OK. Sorry I didn't spot this. > But this requires performing the complete round of lazy-highlighting > all of lazy-matches on every `C-s' key press that will cause > significant slow down in lazy-highlighting because it will remove the > current optimization where `C-s' doesn't cause re-highlighting of > lazy-matches most of the time (when there is no scrolling or toggling > of search parameters). Not necessarily. Another approach, which I'm going to try, is to create the "lazy" overlay for the current match, but not to give it the face property. On C-s, that overlay can get its face, and the overlay for the current match can lose its "lazy face". That way, each match will have exactly one isearch overlay face active. -- Alan Mackenzie (Nuremberg, Germany).