unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Alan Mackenzie <acm@muc.de>
To: Juri Linkov <juri@jurta.org>
Cc: 13402@debbugs.gnu.org
Subject: bug#13402: 24.2.92 pretest: bugs in isearch-yank-line in info page. [Patch]
Date: Fri, 15 Feb 2013 11:55:02 +0000	[thread overview]
Message-ID: <20130215115502.GA2907@acm.acm> (raw)
In-Reply-To: <87liapan32.fsf@mail.jurta.org>

Hi, Juri.

On Fri, Feb 15, 2013 at 12:10:45PM +0200, Juri Linkov wrote:
> >> Here is a patch for this change:

> > Thanks, I'll test your patch now.

> I noticed one problem: going to the next match with `C-s'
> (isearch-repeat-forward) doesn't lazy-highlight the previous match
> that was unhighlighted.  The previous match needs to be re-highlighted
> and the next match unhighlighted.

OK.  Sorry I didn't spot this.

> But this requires performing the complete round of lazy-highlighting
> all of lazy-matches on every `C-s' key press that will cause
> significant slow down in lazy-highlighting because it will remove the
> current optimization where `C-s' doesn't cause re-highlighting of
> lazy-matches most of the time (when there is no scrolling or toggling
> of search parameters).

Not necessarily.  Another approach, which I'm going to try, is to create
the "lazy" overlay for the current match, but not to give it the face
property.  On C-s, that overlay can get its face, and the overlay for
the current match can lose its "lazy face".  That way, each match will
have exactly one isearch overlay face active.

-- 
Alan Mackenzie (Nuremberg, Germany).





  reply	other threads:[~2013-02-15 11:55 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-10 13:25 bug#13402: 24.2.92 pretest: bugs in isearch-yank-line in info page Alan Mackenzie
2013-01-10 18:21 ` Andreas Schwab
2013-01-11  0:43 ` Juri Linkov
2013-02-13  9:47   ` Alan Mackenzie
2013-02-13 17:53     ` Juri Linkov
2013-02-13 21:59       ` Alan Mackenzie
2013-02-14  9:16         ` Juri Linkov
2013-02-14 20:09 ` bug#13402: 24.2.92 pretest: bugs in isearch-yank-line in info page. [Patch] Alan Mackenzie
     [not found] ` <20130214200937.GA3336@acm.acm>
2013-02-14 23:53   ` Glenn Morris
2013-02-15  7:47   ` Juri Linkov
2013-02-15 10:10     ` Juri Linkov
2013-02-15 11:55       ` Alan Mackenzie [this message]
2013-02-15 13:20       ` Alan Mackenzie
2013-02-16 21:50         ` Juri Linkov
2013-02-17 10:03           ` Juri Linkov
2013-02-19 14:50           ` Alan Mackenzie
2013-02-20 10:49             ` Juri Linkov
2013-02-20 22:37               ` Alan Mackenzie
2013-02-21  0:45                 ` Juri Linkov
2013-02-21 12:27                   ` Alan Mackenzie
2013-02-21 17:09                     ` Glenn Morris
2013-02-21 17:48                       ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130215115502.GA2907@acm.acm \
    --to=acm@muc.de \
    --cc=13402@debbugs.gnu.org \
    --cc=juri@jurta.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).