From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#13402: 24.2.92 pretest: bugs in isearch-yank-line in info page Date: Wed, 13 Feb 2013 21:59:36 +0000 Message-ID: <20130213215936.GA5084@acm.acm> References: <20130110132530.GA2805@acm.acm> <87k3rktu9v.fsf@mail.jurta.org> <20130213094724.GA9907@acm.acm> <87621ww23b.fsf@mail.jurta.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1360793437 15195 80.91.229.3 (13 Feb 2013 22:10:37 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 13 Feb 2013 22:10:37 +0000 (UTC) Cc: 13402@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Feb 13 23:10:58 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1U5kXY-0008GW-TB for geb-bug-gnu-emacs@m.gmane.org; Wed, 13 Feb 2013 23:10:57 +0100 Original-Received: from localhost ([::1]:50001 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U5kXF-00080w-8K for geb-bug-gnu-emacs@m.gmane.org; Wed, 13 Feb 2013 17:10:37 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:41559) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U5kNd-0003xS-85 for bug-gnu-emacs@gnu.org; Wed, 13 Feb 2013 17:00:42 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U5kNU-0005IB-OI for bug-gnu-emacs@gnu.org; Wed, 13 Feb 2013 17:00:34 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:49180) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U5kNU-0005GE-Lf for bug-gnu-emacs@gnu.org; Wed, 13 Feb 2013 17:00:32 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1U5kNy-00038H-F5 for bug-gnu-emacs@gnu.org; Wed, 13 Feb 2013 17:01:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 13 Feb 2013 22:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13402 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 13402-submit@debbugs.gnu.org id=B13402.136079285312026 (code B ref 13402); Wed, 13 Feb 2013 22:01:02 +0000 Original-Received: (at 13402) by debbugs.gnu.org; 13 Feb 2013 22:00:53 +0000 Original-Received: from localhost ([127.0.0.1]:54644 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U5kNo-00037t-4l for submit@debbugs.gnu.org; Wed, 13 Feb 2013 17:00:53 -0500 Original-Received: from colin.muc.de ([193.149.48.1]:23389 helo=mail.muc.de) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U5kNk-00037k-Ug for 13402@debbugs.gnu.org; Wed, 13 Feb 2013 17:00:50 -0500 Original-Received: (qmail 82690 invoked by uid 3782); 13 Feb 2013 22:00:13 -0000 Original-Received: from acm.muc.de (pD951A532.dip.t-dialin.net [217.81.165.50]) by colin.muc.de (tmda-ofmipd) with ESMTP; Wed, 13 Feb 2013 23:00:10 +0100 Original-Received: (qmail 5354 invoked by uid 1000); 13 Feb 2013 21:59:36 -0000 Content-Disposition: inline In-Reply-To: <87621ww23b.fsf@mail.jurta.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:71216 Archived-At: Hi, Juri. On Wed, Feb 13, 2013 at 07:53:28PM +0200, Juri Linkov wrote: > > I think it should either skip it properly, or not at all. There is an > > inconsistency here between parts of isearch. > This can be fixed by the patch below that takes into account > the default value `open' of `search-invisible' and treats it the same > as its value `t', i.e. matches hidden text (but it still can't "open" it > in a meaningful way). OK. The patch seems to work. > > I think this should be fixed, somehow, for Emacs 24.3. I would agree > > with your suggestion that isearch should simply yank the invisible text. > This is not a regression, so this patch is intended for trunk: Indeed, I tried it on some older Emacsen. It does go back some way. > === modified file 'lisp/info.el' > --- lisp/info.el 2013-02-12 07:57:04 +0000 > +++ lisp/info.el 2013-02-13 17:52:53 +0000 > @@ -2162,7 +2162,7 @@ (defun Info-isearch-filter (beg-found fo > (let ((backward (< found beg-found))) > (not > (or > - (and (not (eq search-invisible t)) > + (and (null search-invisible) > (if backward > (or (text-property-not-all found beg-found 'invisible nil) > (text-property-not-all found beg-found 'display nil)) -- Alan Mackenzie (Nuremberg, Germany).