From: Alan Mackenzie <acm@muc.de>
To: Juri Linkov <juri@jurta.org>
Cc: 13402@debbugs.gnu.org
Subject: bug#13402: 24.2.92 pretest: bugs in isearch-yank-line in info page
Date: Wed, 13 Feb 2013 21:59:36 +0000 [thread overview]
Message-ID: <20130213215936.GA5084@acm.acm> (raw)
In-Reply-To: <87621ww23b.fsf@mail.jurta.org>
Hi, Juri.
On Wed, Feb 13, 2013 at 07:53:28PM +0200, Juri Linkov wrote:
> > I think it should either skip it properly, or not at all. There is an
> > inconsistency here between parts of isearch.
> This can be fixed by the patch below that takes into account
> the default value `open' of `search-invisible' and treats it the same
> as its value `t', i.e. matches hidden text (but it still can't "open" it
> in a meaningful way).
OK. The patch seems to work.
> > I think this should be fixed, somehow, for Emacs 24.3. I would agree
> > with your suggestion that isearch should simply yank the invisible text.
> This is not a regression, so this patch is intended for trunk:
Indeed, I tried it on some older Emacsen. It does go back some way.
> === modified file 'lisp/info.el'
> --- lisp/info.el 2013-02-12 07:57:04 +0000
> +++ lisp/info.el 2013-02-13 17:52:53 +0000
> @@ -2162,7 +2162,7 @@ (defun Info-isearch-filter (beg-found fo
> (let ((backward (< found beg-found)))
> (not
> (or
> - (and (not (eq search-invisible t))
> + (and (null search-invisible)
> (if backward
> (or (text-property-not-all found beg-found 'invisible nil)
> (text-property-not-all found beg-found 'display nil))
--
Alan Mackenzie (Nuremberg, Germany).
next prev parent reply other threads:[~2013-02-13 21:59 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-10 13:25 bug#13402: 24.2.92 pretest: bugs in isearch-yank-line in info page Alan Mackenzie
2013-01-10 18:21 ` Andreas Schwab
2013-01-11 0:43 ` Juri Linkov
2013-02-13 9:47 ` Alan Mackenzie
2013-02-13 17:53 ` Juri Linkov
2013-02-13 21:59 ` Alan Mackenzie [this message]
2013-02-14 9:16 ` Juri Linkov
2013-02-14 20:09 ` bug#13402: 24.2.92 pretest: bugs in isearch-yank-line in info page. [Patch] Alan Mackenzie
[not found] ` <20130214200937.GA3336@acm.acm>
2013-02-14 23:53 ` Glenn Morris
2013-02-15 7:47 ` Juri Linkov
2013-02-15 10:10 ` Juri Linkov
2013-02-15 11:55 ` Alan Mackenzie
2013-02-15 13:20 ` Alan Mackenzie
2013-02-16 21:50 ` Juri Linkov
2013-02-17 10:03 ` Juri Linkov
2013-02-19 14:50 ` Alan Mackenzie
2013-02-20 10:49 ` Juri Linkov
2013-02-20 22:37 ` Alan Mackenzie
2013-02-21 0:45 ` Juri Linkov
2013-02-21 12:27 ` Alan Mackenzie
2013-02-21 17:09 ` Glenn Morris
2013-02-21 17:48 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130213215936.GA5084@acm.acm \
--to=acm@muc.de \
--cc=13402@debbugs.gnu.org \
--cc=juri@jurta.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).