* bug#13616: [24.3.50] `interactive-p' is used
@ 2013-02-03 3:02 Xue Fuqiao
2013-02-03 3:12 ` Glenn Morris
2013-02-21 2:26 ` Xue Fuqiao
0 siblings, 2 replies; 7+ messages in thread
From: Xue Fuqiao @ 2013-02-03 3:02 UTC (permalink / raw)
To: 13616
In:
L1181 in lisp/progmodes/idlw-help.el
L1469 in lisp/vc/ediff.el
L3786, L3812 and L3844 in lisp/emulation/viper-cmd.el
`interactive-p' is used. Please use `called-interactively-p' instead.
Bzr-111664 trunk
--
Best regards, Xue Fuqiao.
http://www.emacswiki.org/emacs/XueFuqiao
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#13616: [24.3.50] `interactive-p' is used
2013-02-03 3:02 bug#13616: [24.3.50] `interactive-p' is used Xue Fuqiao
@ 2013-02-03 3:12 ` Glenn Morris
2013-02-03 3:29 ` Xue Fuqiao
2013-02-03 15:51 ` Stefan Monnier
2013-02-21 2:26 ` Xue Fuqiao
1 sibling, 2 replies; 7+ messages in thread
From: Glenn Morris @ 2013-02-03 3:12 UTC (permalink / raw)
To: Xue Fuqiao; +Cc: 13616
Thanks for the report. However, we are aware of the byte-compilation
warnings that are produced when building Emacs, and we don't need bug
reports filing about them to remind us, so I am just going to close this
and the other ones. For example, in some cases those modes wish to
remain compataible with older Emacs versions. This does no harm.
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#13616: [24.3.50] `interactive-p' is used
2013-02-03 3:12 ` Glenn Morris
@ 2013-02-03 3:29 ` Xue Fuqiao
2013-02-03 3:46 ` Glenn Morris
2013-02-03 15:51 ` Stefan Monnier
1 sibling, 1 reply; 7+ messages in thread
From: Xue Fuqiao @ 2013-02-03 3:29 UTC (permalink / raw)
To: Glenn Morris; +Cc: 13616
On Sat, 02 Feb 2013 22:12:27 -0500
Glenn Morris <rgm@gnu.org> wrote:
> Thanks for the report. However, we are aware of the byte-compilation
> warnings that are produced when building Emacs, and we don't need bug
> reports filing about them to remind us, so I am just going to close this
> and the other ones. For example, in some cases those modes wish to
> remain compataible with older Emacs versions. This does no harm.
As far as I'm concerned, if some modes wish to remain compatible with older Emacs versions, it can use:
(if (< emacs-major-version 23) ...
or
(when (fboundp ...
--
Best regards, Xue Fuqiao.
http://www.emacswiki.org/emacs/XueFuqiao
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#13616: [24.3.50] `interactive-p' is used
2013-02-03 3:29 ` Xue Fuqiao
@ 2013-02-03 3:46 ` Glenn Morris
2013-02-03 9:33 ` Xue Fuqiao
0 siblings, 1 reply; 7+ messages in thread
From: Glenn Morris @ 2013-02-03 3:46 UTC (permalink / raw)
To: Xue Fuqiao; +Cc: 13616
My comment about compatibility was parenthetical. My main point was that
bug reports about the Lisp compilation warnings are not helpful.
We know they are there and will deal with them when time/need arises.
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#13616: [24.3.50] `interactive-p' is used
2013-02-03 3:46 ` Glenn Morris
@ 2013-02-03 9:33 ` Xue Fuqiao
0 siblings, 0 replies; 7+ messages in thread
From: Xue Fuqiao @ 2013-02-03 9:33 UTC (permalink / raw)
To: Glenn Morris; +Cc: 13616
On Sat, 02 Feb 2013 22:46:03 -0500
Glenn Morris <rgm@gnu.org> wrote:
> My comment about compatibility was parenthetical. My main point was that
> bug reports about the Lisp compilation warnings are not helpful.
> We know they are there and will deal with them when time/need arises.
Thanks for your reply. If Emacs developers know they are there, I
think it will be good to mention them in somewhere like etc/PROBLEMS or
Emacs FAQ.
--
Best regards, Xue Fuqiao.
http://www.emacswiki.org/emacs/XueFuqiao
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#13616: [24.3.50] `interactive-p' is used
2013-02-03 3:12 ` Glenn Morris
2013-02-03 3:29 ` Xue Fuqiao
@ 2013-02-03 15:51 ` Stefan Monnier
1 sibling, 0 replies; 7+ messages in thread
From: Stefan Monnier @ 2013-02-03 15:51 UTC (permalink / raw)
To: Glenn Morris; +Cc: Xue Fuqiao, 13616
> Thanks for the report. However, we are aware of the byte-compilation
> warnings that are produced when building Emacs, and we don't need bug
> reports filing about them to remind us,
Indeed.
We welcome patches to fix them (but beware that it's not always as easy
as it seems to fix them, because of subtle differences with the
replacement, or because of the need to preserve backward compatibility
for packages that are also distributed for older Emacsen or for XEmacs).
Stefan
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#13616: [24.3.50] `interactive-p' is used
2013-02-03 3:02 bug#13616: [24.3.50] `interactive-p' is used Xue Fuqiao
2013-02-03 3:12 ` Glenn Morris
@ 2013-02-21 2:26 ` Xue Fuqiao
1 sibling, 0 replies; 7+ messages in thread
From: Xue Fuqiao @ 2013-02-21 2:26 UTC (permalink / raw)
To: 13616
Or maybe they can be put inside `with-no-warnings'.
--
Best regards, Xue Fuqiao.
http://www.emacswiki.org/emacs/XueFuqiao
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2013-02-21 2:26 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-03 3:02 bug#13616: [24.3.50] `interactive-p' is used Xue Fuqiao
2013-02-03 3:12 ` Glenn Morris
2013-02-03 3:29 ` Xue Fuqiao
2013-02-03 3:46 ` Glenn Morris
2013-02-03 9:33 ` Xue Fuqiao
2013-02-03 15:51 ` Stefan Monnier
2013-02-21 2:26 ` Xue Fuqiao
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).