* bug#13275: 24.2; Tramp regression: remote shells no longer work
@ 2012-12-25 3:13 Dima Kogan
2012-12-26 19:46 ` Glenn Morris
2012-12-27 19:10 ` Michael Albinus
0 siblings, 2 replies; 6+ messages in thread
From: Dima Kogan @ 2012-12-25 3:13 UTC (permalink / raw)
To: 13275
I'm observing that remote tramp shells no longer work with the most
recent emacs from git. I have only tried with recent linux kernels and
amd64 machines for both the client and the server.
My HEAD is currently at 9ca828f0bb329dcc50e68f52d19f17b4e53d68dd
(gnus-related commit made on 2012/12/24), although this issue has been
around for about a month now.
To reproduce:
1. launch emacs
2. open anything with tramp. For instance C-x C-f /server:
3. M-x shell then accept the defaults for the shell and path
You'll get a shell at this point, but even though emacs thinks it is
remote, it's actually local, as can be verified with 'uname -n'. Other
remote processes other than shell-mode are affected; for instance
gud-gdb now suffers from this issue as well.
A bisection indicates that this regression was introduced on Nov 13 in
commit 46d8d668c19b4f299b49856be204a419c15c0af5 : "Use faccessat, not
access, when checking file permissions".
I haven't investigated further.
Thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#13275: 24.2; Tramp regression: remote shells no longer work
2012-12-25 3:13 bug#13275: 24.2; Tramp regression: remote shells no longer work Dima Kogan
@ 2012-12-26 19:46 ` Glenn Morris
2012-12-26 19:50 ` Dima Kogan
2012-12-27 19:10 ` Michael Albinus
1 sibling, 1 reply; 6+ messages in thread
From: Glenn Morris @ 2012-12-26 19:46 UTC (permalink / raw)
To: Dima Kogan; +Cc: 13275
Dima Kogan wrote:
> My HEAD is currently at 9ca828f0bb329dcc50e68f52d19f17b4e53d68dd
> (gnus-related commit made on 2012/12/24), although this issue has been
> around for about a month now.
[...]
> A bisection indicates that this regression was introduced on Nov 13 in
> commit 46d8d668c19b4f299b49856be204a419c15c0af5 : "Use faccessat, not
> access, when checking file permissions".
Which is only on the trunk, so this issue is NOT present in Emacs 24.2
or 24.2.91, despite the subject, is that correct?
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#13275: 24.2; Tramp regression: remote shells no longer work
2012-12-26 19:46 ` Glenn Morris
@ 2012-12-26 19:50 ` Dima Kogan
2012-12-27 7:22 ` Michael Albinus
0 siblings, 1 reply; 6+ messages in thread
From: Dima Kogan @ 2012-12-26 19:50 UTC (permalink / raw)
To: 13275
> On Wed, 26 Dec 2012 14:46:35 -0500
> Glenn Morris <rgm@gnu.org> wrote:
>
> Dima Kogan wrote:
>
> > My HEAD is currently at 9ca828f0bb329dcc50e68f52d19f17b4e53d68dd
> > (gnus-related commit made on 2012/12/24), although this issue has
> > been around for about a month now.
> [...]
> > A bisection indicates that this regression was introduced on Nov 13
> > in commit 46d8d668c19b4f299b49856be204a419c15c0af5 : "Use
> > faccessat, not access, when checking file permissions".
>
> Which is only on the trunk, so this issue is NOT present in Emacs 24.2
> or 24.2.91, despite the subject, is that correct?
Correct. I apologize for the misleading subject; I was reporting the bug from an
older build of emacs, because I needed this functionality.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#13275: 24.2; Tramp regression: remote shells no longer work
2012-12-26 19:50 ` Dima Kogan
@ 2012-12-27 7:22 ` Michael Albinus
0 siblings, 0 replies; 6+ messages in thread
From: Michael Albinus @ 2012-12-27 7:22 UTC (permalink / raw)
To: Dima Kogan; +Cc: 13275
Dima Kogan <dima@secretsauce.net> writes:
>> Which is only on the trunk, so this issue is NOT present in Emacs 24.2
>> or 24.2.91, despite the subject, is that correct?
>
> Correct. I apologize for the misleading subject; I was reporting the
> bug from an older build of emacs, because I needed this functionality.
I could reproduce it locally. Once the Xmas dust has settled, I'll check
what's up (unless somebody else beats me).
Best regards, Michael.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#13275: 24.2; Tramp regression: remote shells no longer work
2012-12-25 3:13 bug#13275: 24.2; Tramp regression: remote shells no longer work Dima Kogan
2012-12-26 19:46 ` Glenn Morris
@ 2012-12-27 19:10 ` Michael Albinus
2012-12-27 22:00 ` Dima Kogan
1 sibling, 1 reply; 6+ messages in thread
From: Michael Albinus @ 2012-12-27 19:10 UTC (permalink / raw)
To: Dima Kogan; +Cc: 13275
Dima Kogan <dima@secretsauce.net> writes:
> I'm observing that remote tramp shells no longer work with the most
> recent emacs from git. I have only tried with recent linux kernels and
> amd64 machines for both the client and the server.
>
> A bisection indicates that this regression was introduced on Nov 13 in
> commit 46d8d668c19b4f299b49856be204a419c15c0af5 : "Use faccessat, not
> access, when checking file permissions".
>
> I haven't investigated further.
That's a pretty good investigation, thanks!
With that change, Ffile_accessible_directory_p got a new implementation,
which is not compatible with remote directories any longer.
I've added a new handler to Tramp. Shall work now; could you, please,
test? Bzr commit #111351.
> Thanks.
Best regards, Michael.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#13275: 24.2; Tramp regression: remote shells no longer work
2012-12-27 19:10 ` Michael Albinus
@ 2012-12-27 22:00 ` Dima Kogan
0 siblings, 0 replies; 6+ messages in thread
From: Dima Kogan @ 2012-12-27 22:00 UTC (permalink / raw)
To: Michael Albinus; +Cc: 13275-done
> On Thu, 27 Dec 2012 20:10:00 +0100
> Michael Albinus <michael.albinus@gmx.de> wrote:
>
> Dima Kogan <dima@secretsauce.net> writes:
>
> > I'm observing that remote tramp shells no longer work with the most
> > recent emacs from git. I have only tried with recent linux kernels
> > and amd64 machines for both the client and the server.
> >
> > A bisection indicates that this regression was introduced on Nov 13
> > in commit 46d8d668c19b4f299b49856be204a419c15c0af5 : "Use
> > faccessat, not access, when checking file permissions".
> >
> > I haven't investigated further.
>
> That's a pretty good investigation, thanks!
>
> With that change, Ffile_accessible_directory_p got a new
> implementation, which is not compatible with remote directories any
> longer.
>
> I've added a new handler to Tramp. Shall work now; could you, please,
> test? Bzr commit #111351.
It appears to work now. Thank you very much. I'm closing this bug.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-12-27 22:00 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-25 3:13 bug#13275: 24.2; Tramp regression: remote shells no longer work Dima Kogan
2012-12-26 19:46 ` Glenn Morris
2012-12-26 19:50 ` Dima Kogan
2012-12-27 7:22 ` Michael Albinus
2012-12-27 19:10 ` Michael Albinus
2012-12-27 22:00 ` Dima Kogan
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).