From: Dima Kogan <dima@secretsauce.net>
To: 11883@debbugs.gnu.org
Subject: bug#11883: Hints
Date: Tue, 6 Nov 2012 11:12:43 -0800 [thread overview]
Message-ID: <20121106111243.3b2d7965@fatty> (raw)
In-Reply-To: <87a9z9ec3k.fsf@shorty.local.i-did-not-set--mail-host-address--so-tickle-me>
Looking around, I discovered that this regression was introduced in
http://git.savannah.gnu.org/cgit/emacs.git/commit/lisp/ansi-color.el?id=cd49cea06bb1c492d4d024889f3f320bf4c9b507
Furthermore, starting from the recent sources, this regression can be fixed by
making the following changes to comint.el:
1. Not inheriting the comint-highlight-prompt face from minibuffer-prompt
2. In comint-output-filter, changing
;; Just move an existing overlay
(move-overlay comint-last-prompt-overlay
prompt-start (point))
to
(move-overlay (copy-overlay comint-last-prompt-overlay)
prompt-start (point))
Note that I don't understand this code sufficiently well to claim this as a fix,
but hopefully this will be helpful for the maintainer to make the final fix.
dima
next prev parent reply other threads:[~2012-11-06 19:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-09 5:29 bug#11883: 24.1.50; shell-mode doesn't colorize the prompt Dima Kogan
2012-11-06 19:12 ` Dima Kogan [this message]
2012-11-09 19:05 ` bug#11883: " Stefan Monnier
2021-07-15 23:06 ` bug#11883: 24.1.50; " Lars Ingebrigtsen
2021-07-30 12:04 ` Lars Ingebrigtsen
2021-07-30 18:38 ` Dima Kogan
2021-12-19 9:48 ` miha--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-12-19 11:02 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121106111243.3b2d7965@fatty \
--to=dima@secretsauce.net \
--cc=11883@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).