unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Dima Kogan <dima@secretsauce.net>
To: Wolfgang Jenkner <wjenkner@inode.at>
Cc: 12792@debbugs.gnu.org
Subject: bug#12792: 24.2.50; shell-mode renders all its output in a yellow face
Date: Mon, 5 Nov 2012 17:31:50 -0800	[thread overview]
Message-ID: <20121105173150.19d3290c@fatty> (raw)
In-Reply-To: <85mwyvplpu.fsf@iznogoud.viz>

> On Tue, 06 Nov 2012 02:24:29 +0100
> Wolfgang Jenkner <wjenkner@inode.at> wrote:
>
> On Tue, Nov 06 2012, Dima Kogan wrote:
> 
> > Previously, I would do M-x shell, and then evaluate the new defun;
> > this produced the results I described earlier.
> 
> Too late, the function must be redefined before the first prompt is
> sent.  I thought it would be simpler to give you the rewritten defun
> separately instead of having you patching ansi-color.el ;-)
> 
> > You just asked for a different order: load ansi-color, comint, THEN
> > eval defun, THEN M-x shell. That produces different colored
> > results: everything looks correct except the prompt is all blue all
> > the time. Nothing has nil face. Is this the expected behavior with
> > that defun
> 
> Yes.  As you found out in your original report the prompt coloring has
> been broken for longer.  If you customize the comint-highlight-prompt
> face so that it doesn't inherit from minibuffer-prompt (which does the
> blue colouring), you'll see that the current prompt is actually
> coloured correctly but for the previous prompts,
> comint-highlight-prompt just replaces the ansi-color faces.  That's
> weird.  Somebody should at some point do something about it ;-)
> 
> In any case, you submitted a separate report about the prompt issue,
> viz. bug#11883.
> 
> So, I'd say that the issue at hand is solved.  I'll just try to
> rewrite the new ansi-color-apply-sequence in a less ugly way.
> 
> Wolfgang

Sounds good. Thanks a lot.

dima





  reply	other threads:[~2012-11-06  1:31 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-03  8:55 bug#12792: 24.2.50; shell-mode renders all its output in a yellow face Dima Kogan
2012-11-03 11:16 ` Chong Yidong
2012-11-03 18:08   ` Dima Kogan
2012-11-03 15:37 ` Wolfgang Jenkner
2012-11-03 16:32   ` Eli Zaretskii
2012-11-03 17:59     ` Wolfgang Jenkner
2012-11-04  3:27       ` Wolfgang Jenkner
2012-11-04  7:45         ` Dima Kogan
2012-11-04 13:49           ` Wolfgang Jenkner
2012-11-04 20:24             ` Dima Kogan
2012-11-04 23:39               ` Wolfgang Jenkner
2012-11-05  3:23                 ` Dima Kogan
2012-11-05 15:00                   ` Wolfgang Jenkner
2012-11-05 15:25                     ` Wolfgang Jenkner
2012-11-05 23:57                     ` Dima Kogan
2012-11-06  1:24                       ` Wolfgang Jenkner
2012-11-06  1:31                         ` Dima Kogan [this message]
2012-11-09  1:50                           ` Wolfgang Jenkner
2012-11-09 17:30                             ` Stefan Monnier
2012-11-09 18:20                               ` Wolfgang Jenkner
2012-11-09 20:37                                 ` Stefan Monnier
2012-11-17 15:21 ` Paul Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121105173150.19d3290c@fatty \
    --to=dima@secretsauce.net \
    --cc=12792@debbugs.gnu.org \
    --cc=wjenkner@inode.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).