unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Alan Mackenzie <acm@muc.de>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: 11841@debbugs.gnu.org, vadimsks@gmail.com
Subject: bug#11841: 24.1; emacs hangs when opening cpp file with mixed eol styles
Date: Sun, 15 Jul 2012 17:02:12 +0000	[thread overview]
Message-ID: <20120715170212.GA2499@acm.acm> (raw)
In-Reply-To: <jwva9z9yhtl.fsf-monnier+emacs@gnu.org>

Hello again, Stefan.

On Sun, Jul 08, 2012 at 07:07:41PM -0400, Stefan Monnier wrote:
> > I've tried setting ^M's syntax to WS.  The code no longer loops.
> > However, ^M is syntactically a comment ender so that it can end a
> > comment when selective-display is active.

> ^M is only a comment ender when selective-display is active.  So only
> set its syntax to comment-end when selective-display is active.

Is that possible?  If so, is it possible without introducing horrible
couplings between disparate bits of code..

> Better yet: stop supporting selective-display.

That's more a decision for the Emacs boss.  selective-display is still
supported in Emacs 24, according to the elisp manual.

> > Would it not be better for ^M to be treated as WS by syntax.c?  The
> > current problem isn't really a CC Mode one; mixed line enders could
> > happen in a file of any major mode.  Emacs really ought to treat all
> > line endings the same.

> It does: it maps them all to ^J.

It does not, except in normal cases.  When most, but not all, line
endings are CRLFs, they are not converted to LFs.  (To do so would lose
information.)

We could have philosophical arguments about whether a CRLF really is a
line ending in this case.  I think, that in practice, an MS-DOS source
file containing an isolated LF (created by some other editor) is the
normal abuse-case for this scenario.  It is causing problems.

> ^M in a buffer is not a line-ender (except for the oddball case of
> selective-display which is a feature that needs to die).

How about treating ^M^J as WS in syntax.c?  At the very least, in
forward-comment?

>         Stefan

-- 
Alan Mackenzie (Nuremberg, Germany).





  reply	other threads:[~2012-07-15 17:02 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-02  0:51 bug#11841: 24.1; emacs hangs when opening cpp file with mixed eol styles Vadim K
2012-07-02 16:42 ` Eli Zaretskii
2012-07-02 18:22   ` Stefan Monnier
2012-07-07 21:10   ` Alan Mackenzie
2012-07-07 21:53     ` Stefan Monnier
2012-07-08  2:58       ` Eli Zaretskii
2012-07-08 14:50         ` Stefan Monnier
2012-07-08 15:34           ` Alan Mackenzie
2012-07-08 23:07             ` Stefan Monnier
2012-07-15 17:02               ` Alan Mackenzie [this message]
2012-07-15 22:56                 ` Stefan Monnier
2012-07-20 21:10   ` Alan Mackenzie
2012-07-22  9:54     ` Stefan Monnier
2012-07-25 20:58     ` Vadim K
2012-12-11 19:24   ` Alan Mackenzie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120715170212.GA2499@acm.acm \
    --to=acm@muc.de \
    --cc=11841@debbugs.gnu.org \
    --cc=monnier@IRO.UMontreal.CA \
    --cc=vadimsks@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).