unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Toby Cubitt <toby-undo-tree-dated-1342530392.127d50@dr-qubit.org>
To: Martin Pohlack <mp26@os.inf.tu-dresden.de>
Cc: Bastien <bzg@gnu.org>, 11774@debbugs.gnu.org
Subject: bug#11774: [O] bug#11774: org-mode causes undo boundaries to be lost
Date: Tue, 3 Jul 2012 11:57:29 +0200	[thread overview]
Message-ID: <20120703095729.GA6651@c3po> (raw)
In-Reply-To: <4FF14504.10609@os.inf.tu-dresden.de>

On Mon, Jul 02, 2012 at 08:51:48AM +0200, Martin Pohlack wrote:
> > I'm still not entirely convinced that the boundary discarding logic in
> > org-self-insert-command is correct. For example, if I do the following:
> > 
> > 1. Type some text at some location in an org-mode buffer
> > 2. Move to another location very far away
> >    (without invoking any commands other than point motion)
> > 3. Type some more text
> > 
> > then org-self-insert-cluster-for-undo collapses the undo changesets for
> > these two changes into one. Undoing then reverts both sets of changes at
> > once, even though those changes might be so far apart that they aren't
> > both visible at the same time in the buffer.
> > 
> > That seems very undesirable to me.
> 
> Having been involved in org-mode's collapsing code I am interested in
> this, but I cannot reproduce your problem.  I used a very large org-mode
> file, inserted some text, moved down some pages and inserted some text
> again (3 chars each).  Undoing was split between both parts, exactly as
> desired.  Could you provide more details please?


Sure. The following steps produce the effect I described, at least for
me. This is on a fairly recent (a couple of weeks old) bzr build of
Emacs, and a similarly recent git build of org-mode:

1. $ emacs -Q
2. C-x C-f test.org
3. M-x org-mode       [not really necessary since already in org-mode]
5. C-u 50 M-x newline
6. M-<
7. type "a"
8. M->
9. type "bc"

buffer-undo-list now contains:

(nil (52 . 54) (1 . 2) nil (1 . 51) (t . -1))

Note the lack of undo boundary between (52 . 54) and (1 . 2), which means
that undoing once (C-/) deletes both "bc" *and* "a" in one step.

HTH,

Toby
-- 
Dr T. S. Cubitt
Mathematics and Quantum Information group
Department of Mathematics
Complutense University
Madrid, Spain

email: tsc25@cantab.net
web:   www.dr-qubit.org





  reply	other threads:[~2012-07-03  9:57 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-24 21:27 bug#11774: org-mode causes undo boundaries to be lost Toby Cubitt
2012-06-24 21:39 ` Bastien
2012-06-24 21:52   ` Toby Cubitt
2012-06-25 11:35     ` Toby Cubitt
2012-07-02  6:51       ` bug#11774: [O] " Martin Pohlack
2012-07-03  9:57         ` Toby Cubitt [this message]
2012-07-03 15:18           ` Martin Pohlack
2012-07-03 17:29             ` Stefan Monnier
     [not found]             ` <jwvpq8coitq.fsf-monnier+emacs@gnu.org>
2012-07-03 18:13               ` bug#11774: [O] bug#11774: " Samuel Wales
2012-07-03 22:57                 ` Stefan Monnier
2012-07-04  0:18                   ` Samuel Wales
2012-07-04  0:24                     ` bug#11774: [O] bug#11774: " Samuel Wales
2012-07-04  9:40                     ` bug#11774: [O] " Toby Cubitt
2012-07-18 13:21                     ` Stefan Monnier
     [not found]                     ` <jwvpq7t1a4t.fsf-monnier+emacs@gnu.org>
2012-08-01 14:26                       ` bug#11774: " Bastien
     [not found]                       ` <CAJcAo8ux9Dw5Nu6x0jm59mWFaLWFG6SSeMs9dju-Jgy5nWkUcA@mail.gmail.com>
2014-11-03 14:35                         ` bug#11774: [O] " Stefan Monnier
2012-07-03 18:33       ` bug#11774: [O] " Martin Pohlack

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120703095729.GA6651@c3po \
    --to=toby-undo-tree-dated-1342530392.127d50@dr-qubit.org \
    --cc=11774@debbugs.gnu.org \
    --cc=bzg@gnu.org \
    --cc=mp26@os.inf.tu-dresden.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).