From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Toby Cubitt Newsgroups: gmane.emacs.bugs Subject: bug#11774: org-mode causes undo boundaries to be lost Date: Mon, 25 Jun 2012 13:35:29 +0200 Message-ID: <20120625113529.GA15913@c3po.home> References: <20120624212755.GA14501@c3po.home> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1340624194 14715 80.91.229.3 (25 Jun 2012 11:36:34 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 25 Jun 2012 11:36:34 +0000 (UTC) Cc: 11774@debbugs.gnu.org To: Bastien Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jun 25 13:36:30 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Sj7am-0005lR-2j for geb-bug-gnu-emacs@m.gmane.org; Mon, 25 Jun 2012 13:36:28 +0200 Original-Received: from localhost ([::1]:40723 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sj7al-0004On-Rn for geb-bug-gnu-emacs@m.gmane.org; Mon, 25 Jun 2012 07:36:27 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:39802) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sj7af-0004OX-QH for bug-gnu-emacs@gnu.org; Mon, 25 Jun 2012 07:36:26 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sj7ab-0006LG-65 for bug-gnu-emacs@gnu.org; Mon, 25 Jun 2012 07:36:21 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:47220) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sj7aR-0006KV-RO; Mon, 25 Jun 2012 07:36:07 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1Sj7eD-0000Fm-Ol; Mon, 25 Jun 2012 07:40:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Toby Cubitt Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org, emacs-orgmode@gnu.org Resent-Date: Mon, 25 Jun 2012 11:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11774 X-GNU-PR-Package: emacs,org-mode X-GNU-PR-Keywords: Original-Received: via spool by 11774-submit@debbugs.gnu.org id=B11774.1340624376920 (code B ref 11774); Mon, 25 Jun 2012 11:40:01 +0000 Original-Received: (at 11774) by debbugs.gnu.org; 25 Jun 2012 11:39:36 +0000 Original-Received: from localhost ([127.0.0.1]:56766 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Sj7dj-0000Eh-FT for submit@debbugs.gnu.org; Mon, 25 Jun 2012 07:39:35 -0400 Original-Received: from starfish.geekisp.com ([216.168.135.166]:28334) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Sj7dd-0000ES-4r for 11774@debbugs.gnu.org; Mon, 25 Jun 2012 07:39:29 -0400 Original-Received: (qmail 13750 invoked by uid 1003); 25 Jun 2012 11:35:29 -0000 Original-Received: from localhost (localhost.geekisp.com [127.0.0.1]) by localhost.geekisp.com (tmda-ofmipd) with ESMTP; Mon, 25 Jun 2012 07:35:27 -0400 Content-Disposition: inline In-Reply-To: <20120624215241.GA6205@c3po.home> X-PGP-Key: http://www.dr-qubit.org/gpg-toby.asc User-Agent: Mutt/1.5.21 (2010-09-15) X-Delivery-Agent: TMDA/1.1.11 (Ladyburn) X-Primary-Address: toby@dr-qubit.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:61273 Archived-At: On Sun, Jun 24, 2012 at 11:52:41PM +0200, Toby Cubitt wrote: > On Sun, Jun 24, 2012 at 11:39:08PM +0200, Bastien wrote: > > Hi Toby, > > > > Toby Cubitt writes: > > > > > For some unknown reason, org-mode is causing the undo boundary between > > > the (2 . 4) and (1 . 2) entries to be removed from `buffer-undo-list'. > > > > Can you try again with > > > > (setq org-self-insert-cluster-for-undo nil) > > > > and report? > > Yup, that fixes the problem. > > I don't fully understand the purpose of > `org-self-insert-cluster-for-undo', given that the Emacs command loop > already groups consecutive undo entries together, but presumably it > enables a more aggressive form of clustering. > [snip] > > I could try to work around this in undo-tree-mode, but it seems to me > that org-mode shouldn't be throwing away an undo boundary that comes > before an entry which definitely shouldn't be clustered with anything > (namely the undo-tree-canary symbol, which is meaningless to org-mode). I've now added a work-around for this in undo-tree-mode (currently only in git, but I'll push to ELPA once it's sufficiently tested). I'm still not entirely convinced that the boundary discarding logic in org-self-insert-command is correct. For example, if I do the following: 1. Type some text at some location in an org-mode buffer 2. Move to another location very far away (without invoking any commands other than point motion) 3. Type some more text then org-self-insert-cluster-for-undo collapses the undo changesets for these two changes into one. Undoing then reverts both sets of changes at once, even though those changes might be so far apart that they aren't both visible at the same time in the buffer. That seems very undesirable to me. But as I can work around it in undo-tree-mode, I'll leave it up to Bastien to decide whether or not this feature needs reworking in org-mode. Best, Toby -- Dr T. S. Cubitt Mathematics and Quantum Information group Department of Mathematics Complutense University Madrid, Spain email: tsc25@cantab.net web: www.dr-qubit.org