bug#11156: 24.0.95; require-final-newline and read-only files

bug#11156: 24.0.95; require-final-newline and read-only files

[Christopher Schmidt]

[-- Attachment #1: Type: text/plain, Size: 455 bytes --]

Hi,

I think I hit on a bug in GNU Emacs 24.0.95.1 (x86_64-unknown-linux-gnu,
GTK+ Version 2.24.10) of 2012-04-02.

Recipe:
cd /tmp
echo -n rms > rms
chmod u=r rms
emacs -q
eval: (setq require-final-newline 'visit)
C-x C-f /tmp/rms RET

There is a new buffer but no window displays it.  The *Messages*-buffer
contains `find-file-noselect-1: Buffer is read-only: #<buffer rms>'

Emacs tries to add a newline to the (read-only) buffer.  Here's a quick
fix:

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: patch.diff --]
[-- Type: text/x-diff, Size: 775 bytes --]

=== modified file 'lisp/ChangeLog'
--- lisp/ChangeLog	2012-04-02 16:32:06 +0000
+++ lisp/ChangeLog	2012-04-02 21:28:06 +0000
@@ -1,3 +1,8 @@
+2012-04-02  Christopher Schmidt  <christopher@ch.ristopher.com>
+
+	* files.el (after-find-file): Do not add a newline at the end when
+	buffer is read-only.
+
 2012-04-02  Glenn Morris  <rgm@gnu.org>
 
 	* emacs-lisp/authors.el (authors-aliases): Another addition.

=== modified file 'lisp/files.el'
--- lisp/files.el	2012-04-01 02:44:24 +0000
+++ lisp/files.el	2012-04-02 21:45:36 +0000
@@ -2152,6 +2152,7 @@
 	 (/= (char-after (1- (point-max))) ?\n)
 	 (not (and (eq selective-display t)
 		   (= (char-after (1- (point-max))) ?\r)))
+	 (not buffer-read-only)
 	 (save-excursion
 	   (goto-char (point-max))
 	   (insert "\n")))


[-- Attachment #3: Type: text/plain, Size: 21 bytes --]


        Christopher

bug#11156: 24.0.95; require-final-newline and read-only files

[Christopher Schmidt]

Christopher Schmidt <christopher@ch.ristopher.com> writes:

> I think I hit on a bug in GNU Emacs 24.0.95.1
> (x86_64-unknown-linux-gnu, GTK+ Version 2.24.10) of 2012-04-02.
>
> Recipe:
> cd /tmp
> echo -n rms > rms
> chmod u=r rms
> emacs -q
> eval: (setq require-final-newline 'visit)
> C-x C-f /tmp/rms RET
>
> There is a new buffer but no window displays it.  The
> *Messages*-buffer contains `find-file-noselect-1: Buffer is read-only:
> #<buffer rms>'

It is annoying that one needs to manually switch to the buffer after
finding a read-only file.  But, more important, find-file-hook is not
run.  This breaks lots of packages and makes this issue a severe one for
me.

        Christopher

bug#11156: 24.0.95; require-final-newline and read-only files

[martin rudalics]

 >> cd /tmp
 >> echo -n rms > rms
 >> chmod u=r rms
 >> emacs -q
 >> eval: (setq require-final-newline 'visit)
 >> C-x C-f /tmp/rms RET
 >>
 >> There is a new buffer but no window displays it.  The
 >> *Messages*-buffer contains `find-file-noselect-1: Buffer is read-only:
 >> #<buffer rms>'
 >
 > It is annoying that one needs to manually switch to the buffer after
 > finding a read-only file.  But, more important, find-file-hook is not
 > run.  This breaks lots of packages and makes this issue a severe one for
 > me.

`after-find-file' shouldn't try adding a newline if `buffer-read-only'
is non-nil.  And the values 'visit and 'visit-save should be documented
in the Elisp manual.

martin

bug#11156: 24.0.95; require-final-newline and read-only files

[Christopher Schmidt]

[-- Attachment #1: Type: text/plain, Size: 214 bytes --]

martin rudalics <rudalics@gmx.at> writes:

> `after-find-file' shouldn't try adding a newline if `buffer-read-only'
> is non-nil.  And the values 'visit and 'visit-save should be
> documented in the Elisp manual.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: require-final-newline.diff --]
[-- Type: text/x-diff, Size: 2542 bytes --]

=== modified file 'doc/lispref/ChangeLog'
--- doc/lispref/ChangeLog	2012-04-15 07:28:01 +0000
+++ doc/lispref/ChangeLog	2012-04-15 13:37:35 +0000
@@ -1,3 +1,8 @@
+2012-04-15  Christopher Schmidt  <christopher@ch.ristopher.com>
+
+	* files.texi (Saving Buffers): Document the values visit and
+	visit-save for require-final-newline.
+
 2012-04-15  Glenn Morris  <rgm@gnu.org>
 
 	* processes.texi (Processes, Subprocess Creation, Shell Arguments):

=== modified file 'doc/lispref/files.texi'
--- doc/lispref/files.texi	2012-04-14 01:59:01 +0000
+++ doc/lispref/files.texi	2012-04-15 13:47:26 +0000
@@ -489,11 +489,13 @@
 @defopt require-final-newline
 This variable determines whether files may be written out that do
 @emph{not} end with a newline.  If the value of the variable is
-@code{t}, then @code{save-buffer} silently adds a newline at the end of
-the file whenever the buffer being saved does not already end in one.
-If the value of the variable is non-@code{nil}, but not @code{t}, then
-@code{save-buffer} asks the user whether to add a newline each time the
-case arises.
+@code{t}, then @code{save-buffer} silently adds a newline at the end
+of the buffer whenever it does not already end in one.  If the value
+is @code{visit}, a newline is added at the end of buffer that doesn't
+have one, just after the file is visited.  If the value is
+@code{visit-save}, a newline is added both on visiting and on saving.
+For every other non-@code{nil} value, @code{save-buffer} asks the user
+whether to add a newline each time the case arises.
 
 If the value of the variable is @code{nil}, then @code{save-buffer}
 doesn't add newlines at all.  @code{nil} is the default value, but a few

=== modified file 'lisp/ChangeLog'
--- lisp/ChangeLog	2012-04-15 09:16:50 +0000
+++ lisp/ChangeLog	2012-04-15 13:17:00 +0000
@@ -445,6 +445,11 @@
 
 	* notifications.el (notifications-notify): Fix docstring.
 
+2012-04-02  Christopher Schmidt  <christopher@ch.ristopher.com>
+
+	* files.el (after-find-file): Do not add a newline at the end when
+	buffer is read-only.
+
 2012-04-02  Glenn Morris  <rgm@gnu.org>
 
 	* emacs-lisp/authors.el (authors-aliases): Another addition.

=== modified file 'lisp/files.el'
--- lisp/files.el	2012-04-14 01:46:06 +0000
+++ lisp/files.el	2012-04-15 13:15:13 +0000
@@ -2152,6 +2152,7 @@
 	 (/= (char-after (1- (point-max))) ?\n)
 	 (not (and (eq selective-display t)
 		   (= (char-after (1- (point-max))) ?\r)))
+	 (not buffer-read-only)
 	 (save-excursion
 	   (goto-char (point-max))
 	   (insert "\n")))


[-- Attachment #3: Type: text/plain, Size: 21 bytes --]


        Christopher

bug#11156: 24.0.95; require-final-newline and read-only files

[Chong Yidong]

Christopher Schmidt <christopher@ch.ristopher.com> writes:

>> `after-find-file' shouldn't try adding a newline if `buffer-read-only'
>> is non-nil.  And the values 'visit and 'visit-save should be
>> documented in the Elisp manual.
>
> === modified file 'doc/lispref/ChangeLog'
> ...

Thanks, committed to the repository.

bug#11156: 24.0.95; require-final-newline and read-only files

[Christopher Schmidt]

Chong Yidong <cyd@gnu.org> writes:

> Thanks, committed to the repository.

Thank you.  Could the patch also be applied to the emacs-24 branch?

        Christopher

bug#11156: 24.0.95; require-final-newline and read-only files

[Chong Yidong]

Christopher Schmidt <christopher@ch.ristopher.com> writes:

>> Thanks, committed to the repository.
>
> Thank you.  Could the patch also be applied to the emacs-24 branch?

Doesn't seem important enough for that.

bug#11156: 24.2.50; require-final-newline and read-only files (was: bug#11156: 24.0.95; require-final-newline and read-only files)

[Christopher Schmidt]

reopen 11156

Chong Yidong <cyd@gnu.org> writes:
> Christopher Schmidt <christopher@ch.ristopher.com> writes:
>
>>> `after-find-file' shouldn't try adding a newline if
>>> `buffer-read-only' is non-nil.  And the values 'visit and
>>> 'visit-save should be documented in the Elisp manual.
>>
>> === modified file 'doc/lispref/ChangeLog'
>> ...
>
> Thanks, committed to the repository.

There is still a minor bug in regard to require-final-newline.

Recipe:
emacs -q
M-: (setq require-final-newline 'visit)
Open an image file via C-x C-f

There is a new buffer but no window displays it.  The *Messages*-buffer
contains "find-file-noselect-1: Text is read-only".

This is because image-mode sets the read-only property of the whole
buffer string to t.  buffer-read-only is nil in this case, though.

I think all code fragments that try to add new lines due to
require-final-newline should ignore text-read-only errors.

        Christopher

bug#11156: 24.2.50; require-final-newline and read-only files

[Chong Yidong]

Christopher Schmidt <christopher@ch.ristopher.com> writes:

> There is still a minor bug in regard to require-final-newline.
>
> Recipe:
> emacs -q
> M-: (setq require-final-newline 'visit)
> Open an image file via C-x C-f
>
> There is a new buffer but no window displays it.  The *Messages*-buffer
> contains "find-file-noselect-1: Text is read-only".
>
> I think all code fragments that try to add new lines due to
> require-final-newline should ignore text-read-only errors.

Fixed, thanks.