From: Christopher Schmidt <christopher@ch.ristopher.com>
To: 11156@debbugs.gnu.org
Subject: bug#11156: 24.0.95; require-final-newline and read-only files
Date: Mon, 02 Apr 2012 23:52:11 +0200 [thread overview]
Message-ID: <20120402215210.3718F201C8@saturn.ch.ristopher.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 455 bytes --]
Hi,
I think I hit on a bug in GNU Emacs 24.0.95.1 (x86_64-unknown-linux-gnu,
GTK+ Version 2.24.10) of 2012-04-02.
Recipe:
cd /tmp
echo -n rms > rms
chmod u=r rms
emacs -q
eval: (setq require-final-newline 'visit)
C-x C-f /tmp/rms RET
There is a new buffer but no window displays it. The *Messages*-buffer
contains `find-file-noselect-1: Buffer is read-only: #<buffer rms>'
Emacs tries to add a newline to the (read-only) buffer. Here's a quick
fix:
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: patch.diff --]
[-- Type: text/x-diff, Size: 775 bytes --]
=== modified file 'lisp/ChangeLog'
--- lisp/ChangeLog 2012-04-02 16:32:06 +0000
+++ lisp/ChangeLog 2012-04-02 21:28:06 +0000
@@ -1,3 +1,8 @@
+2012-04-02 Christopher Schmidt <christopher@ch.ristopher.com>
+
+ * files.el (after-find-file): Do not add a newline at the end when
+ buffer is read-only.
+
2012-04-02 Glenn Morris <rgm@gnu.org>
* emacs-lisp/authors.el (authors-aliases): Another addition.
=== modified file 'lisp/files.el'
--- lisp/files.el 2012-04-01 02:44:24 +0000
+++ lisp/files.el 2012-04-02 21:45:36 +0000
@@ -2152,6 +2152,7 @@
(/= (char-after (1- (point-max))) ?\n)
(not (and (eq selective-display t)
(= (char-after (1- (point-max))) ?\r)))
+ (not buffer-read-only)
(save-excursion
(goto-char (point-max))
(insert "\n")))
[-- Attachment #3: Type: text/plain, Size: 21 bytes --]
Christopher
next reply other threads:[~2012-04-02 21:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-02 21:52 Christopher Schmidt [this message]
2012-04-14 13:49 ` bug#11156: 24.0.95; require-final-newline and read-only files Christopher Schmidt
2012-04-14 18:56 ` martin rudalics
2012-04-15 13:48 ` Christopher Schmidt
2012-04-18 6:25 ` Chong Yidong
2012-05-01 17:02 ` Christopher Schmidt
2012-05-06 5:01 ` Chong Yidong
2012-09-02 18:55 ` bug#11156: 24.2.50; require-final-newline and read-only files (was: bug#11156: 24.0.95; require-final-newline and read-only files) Christopher Schmidt
2012-09-07 10:53 ` bug#11156: 24.2.50; require-final-newline and read-only files Chong Yidong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120402215210.3718F201C8@saturn.ch.ristopher.com \
--to=christopher@ch.ristopher.com \
--cc=11156@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).