From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: jaalto Newsgroups: gmane.emacs.bugs Subject: bug#10956: make-mode.el - improve makefile-warn-suspicious-lines Date: Wed, 21 Mar 2012 14:52:42 -0400 Message-ID: <20120321185242.GE28863@taiko.cante.net> References: <62ehq5qt.fsf@test20.cante.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1332409667 27740 80.91.229.3 (22 Mar 2012 09:47:47 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 22 Mar 2012 09:47:47 +0000 (UTC) Cc: 10956@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Mar 22 10:47:44 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SAecS-0002jP-Bd for geb-bug-gnu-emacs@m.gmane.org; Thu, 22 Mar 2012 10:47:44 +0100 Original-Received: from localhost ([::1]:33884 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SAecR-0005Zz-Po for geb-bug-gnu-emacs@m.gmane.org; Thu, 22 Mar 2012 05:47:43 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:44018) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SAeNc-0008Km-1F for bug-gnu-emacs@gnu.org; Thu, 22 Mar 2012 05:32:28 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SAeNU-0005lz-DU for bug-gnu-emacs@gnu.org; Thu, 22 Mar 2012 05:32:23 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:53757) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SAeNU-0005ll-BL for bug-gnu-emacs@gnu.org; Thu, 22 Mar 2012 05:32:16 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SAerG-0000n1-A4 for bug-gnu-emacs@gnu.org; Thu, 22 Mar 2012 06:03:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: jaalto Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 22 Mar 2012 10:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10956 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 10956-submit@debbugs.gnu.org id=B10956.13324105242941 (code B ref 10956); Thu, 22 Mar 2012 10:03:02 +0000 Original-Received: (at 10956) by debbugs.gnu.org; 22 Mar 2012 10:02:04 +0000 Original-Received: from localhost ([127.0.0.1]:60587 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SAeqK-0000lL-DG for submit@debbugs.gnu.org; Thu, 22 Mar 2012 06:02:04 -0400 Original-Received: from emh06.mail.saunalahti.fi ([62.142.5.116]:49879) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SAeq0-0000ka-V2 for 10956@debbugs.gnu.org; Thu, 22 Mar 2012 06:01:46 -0400 Original-Received: from saunalahti-vams (vs3-11.mail.saunalahti.fi [62.142.5.95]) by emh06-2.mail.saunalahti.fi (Postfix) with SMTP id 5AC1DC7D38; Thu, 22 Mar 2012 11:30:57 +0200 (EET) Original-Received: from emh02.mail.saunalahti.fi ([62.142.5.108]) by vs3-11.mail.saunalahti.fi ([62.142.5.95]) with SMTP (gateway) id A06F5E571D7; Thu, 22 Mar 2012 11:30:57 +0200 Original-Received: from bongo.cante.net (a91-155-176-245.elisa-laajakaista.fi [91.155.176.245]) by emh02.mail.saunalahti.fi (Postfix) with ESMTP id 03AB82BD44; Thu, 22 Mar 2012 11:30:54 +0200 (EET) Original-Received: from test20.cante.net ([192.168.1.20]) by bongo.cante.net with esmtp (Exim 4.77) (envelope-from ) id 1SAeJ6-0001U7-3Y; Thu, 22 Mar 2012 11:27:44 +0200 Original-Received: from jaalto by test20.cante.net with local (Exim 4.77) (envelope-from ) id 1SAQeI-0003R4-Ne; Wed, 21 Mar 2012 14:52:42 -0400 Content-Disposition: inline In-Reply-To: X-Gpg-Key-Id: 0xD189E680 X-Gpg-Key-Info: http://key-server.de:11371/pks/lookup?search=0xD189E680&op=vindex X-Gpg-Key-Get: ttp://key-server.de:11371/pks/lookup?search=0xD189E680&op=get User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: jaalto@taiko.cante.net X-SA-Exim-Scanned: No (on test20.cante.net); SAEximRunCond expanded to false X-Antivirus: VAMS X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:57956 Archived-At: On 2012-03-21 13:54, Stefan Monnier wrote: | > Here is a small patch to check any extra whitespace at the beginning of | > line. The patch is against Emacs Vcs-Git ba7322c dated 2012-02-29. | | I must be missing something. All it does is change a "\t+$" to | "[ \t]+$", so it's not really "at the beginning of line" (tho there's | also a "^" in the regexp, so it really only applies to whitespace-only | lines). | I don't think we want to consider lines made up of spaces as suspicious. It would be good if any whitespace only line were flagged as suspicious, not just \t, like in: [SPACE][TAB][SPACE] [SPACE][TAB] [TAB][SPACE] [TAB] These extra "whitespace" lines are easily missed unless whitespace-mode is on. Jari