From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Christopher Schmidt Newsgroups: gmane.emacs.bugs Subject: bug#10987: ibuffer: remove "No Buffers" error Date: Sun, 11 Mar 2012 19:34:24 +0100 Message-ID: <20120311183439.779981FDFB@saturn.ch.ristopher.com> References: <20120310121820.042301FDFB@saturn.ch.ristopher.com> <877gyrt55n.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: dough.gmane.org 1331490959 4785 80.91.229.3 (11 Mar 2012 18:35:59 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 11 Mar 2012 18:35:59 +0000 (UTC) To: 10987@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Mar 11 19:35:58 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1S6ncb-00011w-Jl for geb-bug-gnu-emacs@m.gmane.org; Sun, 11 Mar 2012 19:35:57 +0100 Original-Received: from localhost ([::1]:33747 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S6nca-0003Hj-W9 for geb-bug-gnu-emacs@m.gmane.org; Sun, 11 Mar 2012 14:35:56 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:44936) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S6ncR-0003Gq-3L for bug-gnu-emacs@gnu.org; Sun, 11 Mar 2012 14:35:54 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S6nbx-0007pn-34 for bug-gnu-emacs@gnu.org; Sun, 11 Mar 2012 14:35:46 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:38457) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S6nbw-0007pf-TR for bug-gnu-emacs@gnu.org; Sun, 11 Mar 2012 14:35:17 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1S6o4k-0000rY-EH for bug-gnu-emacs@gnu.org; Sun, 11 Mar 2012 15:05:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Christopher Schmidt Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Mar 2012 19:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10987 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.13314926893293 (code B ref -1); Sun, 11 Mar 2012 19:05:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 11 Mar 2012 19:04:49 +0000 Original-Received: from localhost ([127.0.0.1]:45289 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S6o4V-0000r1-Fq for submit@debbugs.gnu.org; Sun, 11 Mar 2012 15:04:49 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:51793) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S6o4J-0000qm-Oh for submit@debbugs.gnu.org; Sun, 11 Mar 2012 15:04:46 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S6nbT-0007fn-U9 for submit@debbugs.gnu.org; Sun, 11 Mar 2012 14:34:49 -0400 Original-Received: from lists.gnu.org ([208.118.235.17]:56907) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S6nbT-0007fi-O2 for submit@debbugs.gnu.org; Sun, 11 Mar 2012 14:34:47 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:44740) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S6nbR-0002qC-Ro for bug-gnu-emacs@gnu.org; Sun, 11 Mar 2012 14:34:47 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S6nbP-0007fQ-LC for bug-gnu-emacs@gnu.org; Sun, 11 Mar 2012 14:34:45 -0400 Original-Received: from ristopher.com ([146.185.21.93]:35029 helo=saturn.ch.ristopher.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S6nbP-0007fJ-7s for bug-gnu-emacs@gnu.org; Sun, 11 Mar 2012 14:34:43 -0400 Original-Received: by saturn.ch.ristopher.com (Postfix, from userid 0) id 779981FDFB; Sun, 11 Mar 2012 18:34:39 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=ch.ristopher.com; s=mail; t=1331490879; bh=/ChmEkrg3nYmBdOPdlPS8MxQvg8aXRsZFo/O4kQtkIY=; h=From:To:Subject:In-Reply-To:References:Date:MIME-Version: Content-Type:Message-Id; b=rP3HLqS2DnOQ8pqTIVbszk4y4VbLkEhNlbmlugUOx0uShSyvT2LJ2UGWMXNBU2oFb YDvjxF8gHkLpLl4YSe9awsu9XaN7lvrfDJ5s87jGxU2zYYUMLaZGobYKwONXX7ppGH 1loiZ+Va03SFyuh984Tv5515fGU+XmjIIl9LBeGo= In-Reply-To: <877gyrt55n.fsf@gnu.org> (Chong Yidong's message of "Mon, 12 Mar 2012 01:32:20 +0800") Mail-Followup-To: bug-gnu-emacs@gnu.org X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:57686 Archived-At: --=-=-= Content-Type: text/plain Chong Yidong writes: > Thanks. I committed your patch to trunk. Thank you very much. I just skimmed through ibuffer.el and found the same error in ibuffer-redisplay. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=ibuffer2.diff diff --git a/lisp/ChangeLog b/lisp/ChangeLog index 4710434..5b11660 100644 --- a/lisp/ChangeLog +++ b/lisp/ChangeLog @@ -1,3 +1,8 @@ +2012-03-11 Christopher Schmidt + + * ibuffer.el (ibuffer-redisplay): Remove gratuitous error + (Bug#10987). + 2012-03-11 Michael Albinus * autorevert.el (auto-revert-handler): Ensure, that diff --git a/lisp/ibuffer.el b/lisp/ibuffer.el index 7db4cc4..7e5a4aa 100644 --- a/lisp/ibuffer.el +++ b/lisp/ibuffer.el @@ -2173,11 +2173,10 @@ If optional arg SILENT is non-nil, do not display progress messages." (cadr bufs)) (ibuffer-current-buffers-with-marks bufs) ibuffer-display-maybe-show-predicates))) - (when (null blist) - (if (and (featurep 'ibuf-ext) + (when (and (null blist) + (featurep 'ibuf-ext) ibuffer-filtering-qualifiers) - (message "No buffers! (note: filtering in effect)") - (error "No buffers!"))) + (message "No buffers! (note: filtering in effect)")) (unless silent (message "Updating buffer list...")) (ibuffer-redisplay-engine blist arg) --=-=-= Content-Type: text/plain Christopher --=-=-=--