From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Christopher J. White" Newsgroups: gmane.emacs.bugs Subject: bug#8931: url-http-create-request needs extra CRLF for https Date: Sat, 24 Sep 2011 00:04:43 -0400 Message-ID: <20110924000443.00007b72@unknown> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1316887976 23834 80.91.229.12 (24 Sep 2011 18:12:56 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 24 Sep 2011 18:12:56 +0000 (UTC) To: 8931@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Sep 24 20:12:52 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1R7Wia-0003FE-5X for geb-bug-gnu-emacs@m.gmane.org; Sat, 24 Sep 2011 20:12:52 +0200 Original-Received: from localhost ([::1]:41129 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R7WiZ-00082A-AG for geb-bug-gnu-emacs@m.gmane.org; Sat, 24 Sep 2011 14:12:51 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:38784) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R7WhI-0007xl-74 for bug-gnu-emacs@gnu.org; Sat, 24 Sep 2011 14:11:33 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R7WhF-0001ZZ-Rq for bug-gnu-emacs@gnu.org; Sat, 24 Sep 2011 14:11:32 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:48437) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R7WhF-0001ZV-P4 for bug-gnu-emacs@gnu.org; Sat, 24 Sep 2011 14:11:29 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1R7Whm-0006AF-SN for bug-gnu-emacs@gnu.org; Sat, 24 Sep 2011 14:12:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: "Christopher J. White" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 24 Sep 2011 18:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8931 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 8931-submit@debbugs.gnu.org id=B8931.131688787523597 (code B ref 8931); Sat, 24 Sep 2011 18:12:02 +0000 Original-Received: (at 8931) by debbugs.gnu.org; 24 Sep 2011 18:11:15 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R7Wh0-00068W-GN for submit@debbugs.gnu.org; Sat, 24 Sep 2011 14:11:15 -0400 Original-Received: from mail13c25.carrierzone.com ([64.29.147.23]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R7JUK-00028J-Nq for 8931@debbugs.gnu.org; Sat, 24 Sep 2011 00:05:18 -0400 X-Authenticated-User: cjwhite.grierwhite.com Original-Received: from unknown (pool-108-20-106-149.bstnma.east.verizon.net [108.20.106.149]) (authenticated bits=0) by mail13c25.carrierzone.com (8.13.6/8.13.1) with ESMTP id p8O44h8S032006 for <8931@debbugs.gnu.org>; Sat, 24 Sep 2011 04:04:45 GMT X-Mailer: Claws Mail 3.7.8cvs63 (GTK+ 2.16.6; i586-pc-mingw32msvc) X-CSC: 0 X-CHA: v=1.1 cv=N3L/Tfa42wsFdH1QQdn+g2RYVyTg+YMnn+m4ceAfmfI= c=1 sm=1 a=fQTFhOV4UH4A:10 a=3pyGGIT-qAEA:10 a=kj9zAlcOel0A:10 a=xfvl1eDjdgK2iLzGOqA5FA==:17 a=mDV3o1hIAAAA:8 a=mi8sYjtdou5l2NjRwBkA:9 a=CjuIK1q_8ugA:10 a=xfvl1eDjdgK2iLzGOqA5FA==:117 X-Mailman-Approved-At: Sat, 24 Sep 2011 14:11:13 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sat, 24 Sep 2011 14:12:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-Received-From: 140.186.70.43 X-Mailman-Approved-At: Sat, 24 Sep 2011 14:12:49 -0400 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:51787 Archived-At: There is a tug of war going on here. Prior to 100681, the code had no CRLF after url-http-data. Mark Hershberger submitted a patch to add the CRLF because without it, POSTs with content to https urls just hang: http://bzr.savannah.gnu.org/lh/emacs/trunk/revision/100681 This change was undone by Nicola Avrutin in 104908: http://bzr.savannah.gnu.org/lh/emacs/trunk/revision/104908 The problem was that with no url-http-data, the request ends with a double CRLF, which apparently confuses some servers. I recently came across the exact same problem (with url-http.el without the extra CRL), and Mark's patch above works just fine for me (also POSTs to https). I'm thinking the correct solution is to only add the CRLF if there is http-data: - url-http-data)) + url-http-data (if url-http-data "\r\n"))) ...cj