unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Steve Revilak <steve@srevilak.net>
To: Chong Yidong <cyd@stupidchicken.com>
Cc: 7850@debbugs.gnu.org
Subject: bug#7850: 23.2.91; emacs runs svn status -v after every file save
Date: Sat, 22 Jan 2011 16:58:21 -0500	[thread overview]
Message-ID: <20110122215820.GG5014@srevilak.net> (raw)
In-Reply-To: <8762thbpc9.fsf@stupidchicken.com>

[-- Attachment #1: Type: text/plain, Size: 2025 bytes --]

> Though this wouldn't handle modified properties (cf bug#7861).
> Perhaps one should parse .svn/entries (?) like the bzr heuristic does.
> I guess since svn is generally fast, no-one's bothered to do this.

Glenn,

Thanks for looking into this.  When I wrote 7850, I wasn't thinking of
svn properties.  Once you bring properties into the picture, running
"svn status -v" makes more sense.


>What are the implications if vc-svn-state-heuristic does not detect
>modified properties?

http://debbugs.gnu.org/cgi/bugreport.cgi?bug=7861 might answer that
question.  As far as svn is concerned, properties are separate from
the contents of files, and can change independently.  Changing file
properties does not change the file mtime.

Here is a small example, where a property changes, but the file
contents do not.

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# foo.txt has a modified property
$ svn status
  M      foo.txt

# svn diff shows that only properties have changed
$ svn diff foo.txt 

Property changes on: foo.txt
___________________________________________________________________
Modified: svn:keywords
    - Id Revision Date Author URL
    + Id
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

I am surprised that vc-dir does not notice this change (this is the
subject of 7861).  I am equally surprised that

   C-x C-f foo.txt
   C-x v v

tells me "Fileset is up-to-date".  So, you really cannot use emacs to
commit a file that has only property changes.  This also implies that
emacs is not getting much benefit from running svn status after file
saves.

Would it make sense to run "svn status" during vc actions, but not
during file saves?

One thing I noticed while writing this example: when I change a
property on foo.txt, svn 1.6 creates a .svn/props/foo.txt.svn-work,
which contains a description of the property change.  If I commit (or
revert) foo.txt, then svn deletes .svn/props/foo.txt.svn-work.  This
might be a cheap way to test for properties changes.

Steve


[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

  reply	other threads:[~2011-01-22 21:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-16 16:48 bug#7850: 23.2.91; emacs runs svn status -v after every file save Steve Revilak
2011-01-21  2:39 ` Glenn Morris
2011-01-21  3:22   ` Glenn Morris
2011-01-22  3:16     ` Chong Yidong
2011-01-22 21:58       ` Steve Revilak [this message]
2012-11-04  4:22   ` Glenn Morris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110122215820.GG5014@srevilak.net \
    --to=steve@srevilak.net \
    --cc=7850@debbugs.gnu.org \
    --cc=cyd@stupidchicken.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).