unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Alan Mackenzie <acm@muc.de>
To: Chong Yidong <cyd@stupidchicken.com>
Cc: Daniel Colascione <dan.colascione@gmail.com>, 7477@debbugs.gnu.org
Subject: bug#7477: [PATCH] cc-mode tries to recognize template in non-templated language
Date: Thu, 9 Dec 2010 22:35:49 +0000	[thread overview]
Message-ID: <20101209223549.GB4636__26789.774062536$1291947984$gmane$org@muc.de> (raw)
In-Reply-To: <87d3pek6w8.fsf@stupidchicken.com>

Hi, both!

On Mon, Dec 06, 2010 at 03:01:27PM -0500, Chong Yidong wrote:
> Hi Alan, could you take a look at this patch?  Thanks.
> 
> Daniel Colascione <dan.colascione@gmail.com> writes:
> 
> > If a file in c-mode contains constructs that look like C++ templates,
> > c-mode will try to use parts of the template-matching infrastructure
> > that have not been initialized.
> >
> > === modified file 'lisp/progmodes/cc-engine.el'
> > --- lisp/progmodes/cc-engine.el	2010-11-15 04:13:16 +0000
> > +++ lisp/progmodes/cc-engine.el	2010-11-25 03:09:29 +0000
> > @@ -5889,7 +5889,8 @@
> >    ;; `c-record-type-identifiers' is non-nil.
> >    ;;
> >    ;; This function might do hidden buffer changes.
> > -  (when (looking-at "<")
> > +  (when (and c-recognize-<>-arglists
> > +             (looking-at "<"))
> >      (c-forward-<>-arglist t)
> >      (c-forward-syntactic-ws))

The patch looks exactly right.  I'll commit it sometime soon.

Thanks, Daniel!

-- 
Alan Mackenzie (Nuremberg, Germany).





  reply	other threads:[~2010-12-09 22:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-25  3:12 bug#7477: [PATCH] cc-mode tries to recognize template in non-templated language Daniel Colascione
2010-12-06 20:01 ` Chong Yidong
2010-12-09 22:35   ` Alan Mackenzie [this message]
2010-12-12 13:50 ` Alan Mackenzie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='20101209223549.GB4636__26789.774062536$1291947984$gmane$org@muc.de' \
    --to=acm@muc.de \
    --cc=7477@debbugs.gnu.org \
    --cc=cyd@stupidchicken.com \
    --cc=dan.colascione@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).