unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Alan Mackenzie <acm@muc.de>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>,
	martin rudalics <rudalics@gmx.at>
Cc: 6688@debbugs.gnu.org
Subject: bug#6688: Acknowledgement (23.2; Auto-fill broken in C/C++ modes.)
Date: Sat, 24 Jul 2010 20:26:05 +0000	[thread overview]
Message-ID: <20100724202605.GA4406@muc.de> (raw)
In-Reply-To: <vpq1vawwxrq.fsf@bauges.imag.fr>

Hi, Matthieu,

thanks for such a wonderfully helpful bug report!

On Wed, Jul 21, 2010 at 07:27:37PM +0200, Matthieu Moy wrote:
> Digging a bit further, I found out in this example:

> /*
>   Test

> */

> * The problems seems to be that the last */ is at the beginning of
>   line. If I add a space before, the problem disapears. It seems to be
>   a problem with `c-mask-paragraph', around this

> 		(let* ((ender-start (save-excursion
> 				      (goto-char (cdr c-lit-limits))
> 				      (skip-syntax-backward "^w ")
> 				      (point)))

The problem is indeed nearby, in c-mask-paragraph.  Would you please try
out the patch below, indeed please test it as intensively as possible
and let me know if there are any remaining problems.  The code here is
complicated enough for me not to be totally confident about the patch.

>   since the skip-syntax-backward will skip the newline and move out of
>   the line of the */.

> * If I download version 5.31.3 of cc-mode and install it, the problem
>   goes away.

> Hope this helps,

Very much so!

#########################################################################

Hi, Martin,

would you please try this patch out on the test case for which you
committed change 83096, and let me know if that bug remains fixed.
83096 is this one:

------------------------------------------------------------
revno: 83096
committer: Martin Rudalics <rudalics@gmx.at>
timestamp: Sat 2007-12-08 09:55:18 +0000
message:
  (c-mask-paragraph): Avoid invalid search
    bound error in block comment branch.
    
Thanks!

#########################################################################

> -- 
> Matthieu Moy
> http://www-verimag.imag.fr/~moy/

-- 
Alan Mackenzie (Nuremberg, Germany).






  reply	other threads:[~2010-07-24 20:26 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-21 13:33 bug#6688: 23.2; Auto-fill broken in C/C++ modes Matthieu Moy
     [not found] ` <handler.6688.B.127972470023881.ack@debbugs.gnu.org>
2010-07-21 17:27   ` bug#6688: Acknowledgement (23.2; Auto-fill broken in C/C++ modes.) Matthieu Moy
2010-07-24 20:26     ` Alan Mackenzie [this message]
2010-07-25  9:50       ` martin rudalics
     [not found]     ` <20100725130939.GA1141@muc.de>
2010-07-25 13:35       ` martin rudalics
2010-07-25 16:18         ` Alan Mackenzie
2010-07-26  5:50           ` martin rudalics
2010-07-26 19:34             ` Alan Mackenzie
2010-07-27  7:23               ` martin rudalics
2010-07-26  8:27       ` Matthieu Moy
2010-07-31  9:49       ` Alan Mackenzie
2010-08-04 20:19 ` bug#6688: bug #6688 fixed Alan Mackenzie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100724202605.GA4406@muc.de \
    --to=acm@muc.de \
    --cc=6688@debbugs.gnu.org \
    --cc=Matthieu.Moy@grenoble-inp.fr \
    --cc=rudalics@gmx.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).