From: Dan Nicolaescu <dann@ics.uci.edu>
To: Glenn Morris <rgm@gnu.org>
Cc: 3214@debbugs.gnu.org
Subject: bug#3214: vc-dir problem when committing removed file to bzr
Date: Tue, 19 Jan 2010 23:16:08 -0800 (PST) [thread overview]
Message-ID: <201001200716.o0K7G8aC013349@godzilla.ics.uci.edu> (raw)
In-Reply-To: <fr1vhll94x.fsf@fencepost.gnu.org> (Glenn Morris's message of "Tue, 19 Jan 2010 22:58:54 -0500")
Glenn Morris <rgm@gnu.org> writes:
> Just had what seems to be a same problem as this (bug#3214) with the
> trunk from 2010-01-10.
>
> In the emacs admin/ directory, I did (from the command-line):
>
> bzr remove revdiff
>
> Then I edited the ChangeLog file, then did M-x vc-dir on the admin
> directory.
>
> In the resulting buffer, the ChangeLog was marked as modified, and
> revdiff as removed.
>
> I marked both files, hit `v', entered a log message, and tried to
> commit. The vc-dir process finished with an error:
>
> Running bzr status ChangeLog in foreground...
> Running bzr status ChangeLog...OK = 0
> Running bzr status revdiff in foreground...
> vc-do-command: Running bzr status revdiff...FAILED (status 3)
> Matches vc-do-command: Running bzr status revdiff...FAILED (... [-1-]
We get to vc-do-command like this:
vc-bzr-state -> vc-bzr-status -> vc-bzr-command -> vc-do-command
vc-bzr-command is passed a 0 for OKSTATUS.
but
bzr status revdiff
returns 3, that is why the message above is printed.
Changing that 0 to 3 helps, but then vc-bzr-state prints
"bzr: ERROR: Path(s) do not exist: revdiff".
Maybe we can make vc-bzr-status ignore that message.
I'd like to get a second opinion before making the 2 changes above (0->3
and ignore the error message).
> I'm left with a vc-dir buffer which looks like:
>
> * up-to-date ChangeLog
> * removed revdiff
>
> However, the commit to the repository did complete OK.
The calls above occur after the checkin has been completed.
next prev parent reply other threads:[~2010-01-20 7:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-04 22:38 bug#3214: 23.0.92; VC dir mode fails after commit when files are deleted Bob Rogers
2010-01-20 3:58 ` bug#3214: vc-dir problem when committing removed file to bzr Glenn Morris
2010-01-20 7:16 ` Dan Nicolaescu [this message]
2023-10-15 10:34 ` bug#3214: 23.0.92; VC dir mode fails after commit when files are deleted Mauro Aranda
2023-10-21 1:29 ` Bob Rogers
2023-10-21 10:21 ` Mauro Aranda
2023-10-21 10:36 ` Stefan Kangas
2023-10-21 11:24 ` Mauro Aranda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201001200716.o0K7G8aC013349@godzilla.ics.uci.edu \
--to=dann@ics.uci.edu \
--cc=3214@debbugs.gnu.org \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).