unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: Juri Linkov <juri@linkov.net>, Lars Ingebrigtsen <larsi@gnus.org>
Cc: 42708@debbugs.gnu.org, rms@gnu.org,
	"積丹尼 Dan Jacobson" <jidanni@jidanni.org>
Subject: bug#42708: Let users copy "*Char Help*" buffer
Date: Tue, 10 Nov 2020 12:26:35 -0800 (PST)	[thread overview]
Message-ID: <20098a09-7605-4b1e-8ff4-a49316f367cb@default> (raw)
In-Reply-To: <878sb9j7l0.fsf@mail.linkov.net>

> No other effect, cursor-in-echo-area was necessary when
> 'read-char-choice' relied on 'read-key'.

Seriously?  You've not only introduced a new function,
`read-char-from-minibuffer', AND used it here and there
(everywhere?) in place of `read-char` and `read-key`,
but you've ALSO changed the behavior of `read-char-choice`,
so it too no longer reads a char in the longstanding,
useful way, which we can count to NOT use the minibuffer?

FTR, here's one user who strongly objects.  You knew that,
generally.  Now you know it for `read-char-choice' in
particular.  Hey, why didn't you just redefine `read-char'
while you were at it?

> Then what remains in 'read-char-choice' after this clean-up,
> is just a call to 'read-char-from-minibuffer' and handling 'help-char'
> by calling 'help-form-show'.  OTOH, 'help-form-show' can be simply
> bound
> to 'help-char' in 'read-char-from-minibuffer-map'.  So I'm lost what
> would be better to do.  I see 2 variants:
> 
> 1. Declare 'read-char-choice' as an equivalent of 'read-char-from-
>    minibuffer', but with additional handling of 'help-char';
> 
> 2. Add handling of 'help-char' to 'read-char-from-minibuffer',
>    and leave 'read-char-choice' unchanged, then replace all calls
>    of 'read-char-choice' with 'read-char-from-minibuffer' calls
>    in the Emacs source tree.

Alas.





  reply	other threads:[~2020-11-10 20:26 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-04 13:41 bug#42708: Let users copy "*Char Help*" buffer 積丹尼 Dan Jacobson
2020-08-04 23:42 ` Juri Linkov
2020-08-05  9:24   ` Lars Ingebrigtsen
2020-08-05 23:52     ` Juri Linkov
2020-08-06  7:12       ` Lars Ingebrigtsen
2020-10-13  2:59         ` Lars Ingebrigtsen
2020-10-13 15:27           ` Drew Adams
2020-11-03 18:57           ` Juri Linkov
2020-11-09 13:39             ` Lars Ingebrigtsen
2020-11-10 19:51               ` Juri Linkov
2020-11-10 20:26                 ` Drew Adams [this message]
2020-11-11  5:40                   ` Richard Stallman
2020-11-11  8:09                   ` Juri Linkov
2020-11-11 19:41                     ` Drew Adams
2020-11-11 20:07                       ` Juri Linkov
2020-11-11 21:24                         ` Drew Adams
2020-11-12  7:32                           ` Juri Linkov
2020-11-12 18:09                             ` Drew Adams
2020-11-11 10:28                 ` Lars Ingebrigtsen
2020-11-11 19:19                   ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20098a09-7605-4b1e-8ff4-a49316f367cb@default \
    --to=drew.adams@oracle.com \
    --cc=42708@debbugs.gnu.org \
    --cc=jidanni@jidanni.org \
    --cc=juri@linkov.net \
    --cc=larsi@gnus.org \
    --cc=rms@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).