From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.bugs Subject: bug#5211: Color escape codes in the output of vc-git-print-log Date: Tue, 15 Dec 2009 06:57:30 -0800 (PST) Message-ID: <200912151457.nBFEvUT3007406@godzilla.ics.uci.edu> References: Reply-To: Dan Nicolaescu , 5211@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1260889804 11212 80.91.229.12 (15 Dec 2009 15:10:04 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 15 Dec 2009 15:10:04 +0000 (UTC) Cc: 5211@emacsbugs.donarmstrong.com To: Juanma Barranquero Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Dec 15 16:09:57 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NKZ28-0001EE-NB for geb-bug-gnu-emacs@m.gmane.org; Tue, 15 Dec 2009 16:09:53 +0100 Original-Received: from localhost ([127.0.0.1]:43975 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NKZ28-0004UI-Jg for geb-bug-gnu-emacs@m.gmane.org; Tue, 15 Dec 2009 10:09:52 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NKZ01-0002aE-Aa for bug-gnu-emacs@gnu.org; Tue, 15 Dec 2009 10:07:41 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NKYzv-0002Wq-D8 for bug-gnu-emacs@gnu.org; Tue, 15 Dec 2009 10:07:39 -0500 Original-Received: from [199.232.76.173] (port=33126 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NKYzu-0002WZ-KD for bug-gnu-emacs@gnu.org; Tue, 15 Dec 2009 10:07:34 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:50686) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NKYzs-0005DU-9o for bug-gnu-emacs@gnu.org; Tue, 15 Dec 2009 10:07:32 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nBFF7TSF022284; Tue, 15 Dec 2009 07:07:29 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id nBFF55oo021505; Tue, 15 Dec 2009 07:05:05 -0800 Resent-Date: Tue, 15 Dec 2009 07:05:05 -0800 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Dan Nicolaescu Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs , owner@emacsbugs.donarmstrong.com 2Resent-Date: Tue, 15 Dec 2009 15:05:05 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 5211 X-Emacs-PR-Package: emacs,vc X-Emacs-PR-Keywords: patch Original-Received: via spool by 5211-submit@emacsbugs.donarmstrong.com id=B5211.126088906320706 (code B ref 5211); Tue, 15 Dec 2009 15:05:05 +0000 Original-Received: (at 5211) by emacsbugs.donarmstrong.com; 15 Dec 2009 14:57:43 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from colin-baker-v0.ics.uci.edu (colin-baker-v0.ics.uci.edu [128.195.1.153]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nBFEvgE1020702 for <5211@emacsbugs.donarmstrong.com>; Tue, 15 Dec 2009 06:57:43 -0800 Original-Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by colin-baker-v0.ics.uci.edu (8.13.8/8.13.8) with ESMTP id nBFEvUrx004966 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 15 Dec 2009 06:57:30 -0800 Original-Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id nBFEvUT3007406; Tue, 15 Dec 2009 06:57:30 -0800 (PST) In-Reply-To: (Juanma Barranquero's message of "Mon, 14 Dec 2009 17:12:24 +0100") Original-Lines: 34 X-ICS-MailScanner-Information: Please send mail to helpdesk@ics.uci.edu or more information X-ICS-MailScanner-ID: nBFEvUrx004966 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Resent-Date: Tue, 15 Dec 2009 10:07:39 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:33613 Archived-At: Juanma Barranquero writes: > Package: emacs,vc > Tags: patch > Version: 23.1.90 > Severity: minor > > > Depending of your setting of color.diff, color is used for log output, > and vc-print-log shows garbage (OK, escape codes for color): > > ^[[33mcommit 43a3bf88e5e495ad048b3a6d3cf852e1e7a02f1c^[[m > Author: xxx > Date: 2009-12-14 17:11:35 +0200 > > blah blah blah > > > As color in *vc-change-log* buffers is an issue for font-locking, and > not for git log, the command should be called with --no-color. > > OK to the following patch? > > Juanma > > > 2009-12-14 Juanma Barranquero > > * vc-git.el (vc-git-print-log): Pass --no-color to `git log'. When did the --no-color option appear? If we pass it by default, then it will break C-x v l for git versions that do not support it. If --no-color is old enough, the it might not matter...