unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Dan Nicolaescu <dann@ics.uci.edu>
To: Magnus Henoch <magnus.henoch@gmail.com>
Cc: 4972@emacsbugs.donarmstrong.com
Subject: bug#4972: 23.1.50; Can't view revision log from Hg annotate buffer
Date: Thu, 19 Nov 2009 10:43:57 -0800 (PST)	[thread overview]
Message-ID: <200911191843.nAJIhv1G022475@godzilla.ics.uci.edu> (raw)
In-Reply-To: <84aayilgmw.fsf@linux-b2a3.site> (Magnus Henoch's message of "Thu, 19 Nov 2009 14:43:19 +0000")

Magnus Henoch <magnus.henoch@gmail.com> writes:

  > Please write in English if possible, because the Emacs maintainers
  > usually do not have translators to read other languages for them.
  > 
  > Your bug report will be posted to the emacs-pretest-bug@gnu.org mailing list.
  > 
  > Please describe exactly what actions triggered the bug
  > and the precise symptoms of the bug.  If you can, give
  > a recipe starting from `emacs -Q':
  > 
  > When I open a file managed by Mercurial, hit C-x v g to annotate it, and
  > hit `l' to view the log message of the revision of the current line, I
  > get this:
  > 
  > Debugger entered--Lisp error: (wrong-number-of-arguments #[(backend files working-revision limit) "*byte code removed*" [pl-return vc-short-log dir-present files file --cl-dolist-temp-- nil file-directory-p t directory vc-call-backend print-log "*vc-change-log*" pop-to-buffer vc-exec-after let (inhibit-read-only t) quote ((quote log-view-mode)) set (make-local-variable (quote log-view-vc-backend)) (make-local-variable (quote log-view-vc-fileset)) when and ((not (eq (quote limit-unsupported) pl-return))) (goto-char (point-max)) widget-create (quote push-button) :notify lambda (&rest ignore) vc-print-log-internal * 2 (:help-echo "Show the log again, and double the number of log entries shown" "Show 2X entries") (widget-insert "    ") (quote push-button) (&rest ignore) (nil) (:help-echo "Show the log again, showing all entries" "Show unlimited entries") ((widget-setup)) (shrink-window-if-larger-than-buffer) (quote show-log-entry) ((setq vc-sentinel-movepoint (point)) (set-buffer-modified-p nil)) vc-log-short-style backend limit working-revision] 21] 3)
  >   vc-print-log-internal(Hg ("/home/magnus/foo.erl") "23")
  >   (if (not rev-at-line) (message "Cannot extract revision number from the current line") (vc-print-log-internal vc-annotate-backend (list ...) (car rev-at-line)))
  >   (let ((rev-at-line ...)) (if (not rev-at-line) (message "Cannot extract revision number from the current line") (vc-print-log-internal vc-annotate-backend ... ...)))
  >   (if (not (equal major-mode ...)) (message "Cannot be invoked outside of a vc annotate buffer") (let (...) (if ... ... ...)))
  >   vc-annotate-show-log-revision-at-line()
  >   call-interactively(vc-annotate-show-log-revision-at-line nil nil)

This should fix it.

--- vc-annotate.el.~1.10.~                                     Thu Nov 19 07:37:30 2009
+++ vc-annotate.el                                             Thu Nov 19 10:42:54 2009
@@ -487,7 +487,7 @@ Return a cons (REV . FILENAME)."
       (if (not rev-at-line)
         (message "Cannot extract revision number from the current line")
         (vc-print-log-internal
-         vc-annotate-backend (list (cdr rev-at-line)) (car rev-at-line))))))
+          vc-annotate-backend (list (cdr rev-at-line)) (car rev-at-line) nil)))))
 
 (defun vc-annotate-show-diff-revision-at-line-internal (filediff)
   (if (not (equal major-mode 'vc-annotate-mode))





  reply	other threads:[~2009-11-19 18:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200911201629.nAKGTxUA024571@godzilla.ics.uci.edu>
2009-11-19 14:43 ` bug#4972: 23.1.50; Can't view revision log from Hg annotate buffer Magnus Henoch
2009-11-19 18:43   ` Dan Nicolaescu [this message]
2009-11-20 16:35   ` bug#4972: marked as done (23.1.50; Can't view revision log from Hg annotate buffer) Emacs bug Tracking System

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200911191843.nAJIhv1G022475@godzilla.ics.uci.edu \
    --to=dann@ics.uci.edu \
    --cc=4972@emacsbugs.donarmstrong.com \
    --cc=magnus.henoch@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).