unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Dan Nicolaescu <dann@ics.uci.edu>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 4868@emacsbugs.donarmstrong.com, Tom Tromey <tromey@redhat.com>
Subject: bug#4868: 23.1; "No fileset is available here"
Date: Wed, 4 Nov 2009 18:14:42 -0800 (PST)	[thread overview]
Message-ID: <200911050214.nA52EgL4009793@godzilla.ics.uci.edu> (raw)
In-Reply-To: <jwvocnh3f3x.fsf-monnier+emacsbugreports@gnu.org> (Stefan Monnier's message of "Wed, 04 Nov 2009 21:02:23 -0500")

Stefan Monnier <monnier@iro.umontreal.ca> writes:

  > >> I modified a file in a git-managed directory.
  > >> Then I typed `C-x v ='.
  > >> I got an error: "No fileset is available here".
  > 
  > > Is this file not registered with Git?
  > 
  > > If yes, then that's the error it would get.
  > > emacs-22 used to have a nicer looking error in that case: "File is not
  > > under version control".   Not sure why that check got removed, there's
  > > nothing in the ChangeLog to explain it :-(
  > 
  > Would the patch below make sense?  After all, at that point we've

Looks fine to me.

  > already checked we're visiting a file, there's no backend and we're not
  > in vc-dir-mode, so a message like "No fileset is available here" is
  > probably never right.



  > 
  >         Stefan
  > 
  > 
  > === modified file 'lisp/vc.el'
  > --- lisp/vc.el	2009-10-24 18:33:25 +0000
  > +++ lisp/vc.el	2009-11-05 02:00:24 +0000
  > @@ -922,7 +922,7 @@
  >  		nil)
  >  	(list (vc-backend-for-registration (buffer-file-name))
  >  	      (list buffer-file-name))))
  > -     (t (error "No fileset is available here")))))
  > +     (t (error "File is not under version control")))))
  >  
  >  (defun vc-ensure-vc-buffer ()
  >    "Make sure that the current buffer visits a version-controlled file."





  reply	other threads:[~2009-11-05  2:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-04 19:18 bug#4868: 23.1; "No fileset is available here" Tom Tromey
2009-11-04 21:15 ` Dan Nicolaescu
2009-11-05  2:02   ` Stefan Monnier
2009-11-05  2:14     ` Dan Nicolaescu [this message]
2009-11-08 17:03   ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200911050214.nA52EgL4009793@godzilla.ics.uci.edu \
    --to=dann@ics.uci.edu \
    --cc=4868@emacsbugs.donarmstrong.com \
    --cc=monnier@iro.umontreal.ca \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).