From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.bugs Subject: bug#4429: purecopy calls needed for :help and in menu-bar.el Date: Tue, 3 Nov 2009 17:50:28 -0800 (PST) Message-ID: <200911040150.nA41oSjV027181@godzilla.ics.uci.edu> References: <200909141843.n8EIhIpg023585@godzilla.ics.uci.edu> <200909161050.n8GAoSZR011819@godzilla.ics.uci.edu> <877hux22uj.fsf@mail.jurta.org> <873a5kwb2j.fsf@mail.jurta.org> <200911030645.nA36j7QM019013@godzilla.ics.uci.edu> <87aaz4qd6h.fsf@mail.jurta.org> Reply-To: Dan Nicolaescu , 4429@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1257300457 439 80.91.229.12 (4 Nov 2009 02:07:37 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 4 Nov 2009 02:07:37 +0000 (UTC) Cc: 4429@emacsbugs.donarmstrong.com To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Nov 04 03:07:30 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1N5VHV-0007it-Ve for geb-bug-gnu-emacs@m.gmane.org; Wed, 04 Nov 2009 03:07:30 +0100 Original-Received: from localhost ([127.0.0.1]:49512 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N5VHV-0002c2-Fj for geb-bug-gnu-emacs@m.gmane.org; Tue, 03 Nov 2009 21:07:29 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N5VHQ-0002b3-Cv for bug-gnu-emacs@gnu.org; Tue, 03 Nov 2009 21:07:24 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N5VHL-0002X9-KO for bug-gnu-emacs@gnu.org; Tue, 03 Nov 2009 21:07:23 -0500 Original-Received: from [199.232.76.173] (port=45204 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N5VHL-0002Wx-CC for bug-gnu-emacs@gnu.org; Tue, 03 Nov 2009 21:07:19 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:44586) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1N5VHK-0002tB-Hh for bug-gnu-emacs@gnu.org; Tue, 03 Nov 2009 21:07:18 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nA427GoX028260; Tue, 3 Nov 2009 18:07:16 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id nA41t6Qr026484; Tue, 3 Nov 2009 17:55:06 -0800 Resent-Date: Tue, 3 Nov 2009 17:55:06 -0800 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Dan Nicolaescu Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Wed, 04 Nov 2009 01:55:05 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 4429 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 4429-submit@emacsbugs.donarmstrong.com id=B4429.125729944026372 (code B ref 4429); Wed, 04 Nov 2009 01:55:05 +0000 Original-Received: (at 4429) by emacsbugs.donarmstrong.com; 4 Nov 2009 01:50:40 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from paul-mcgann-v0.ics.uci.edu (paul-mcgann-v0.ics.uci.edu [128.195.1.147]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nA41odAd026366 for <4429@emacsbugs.donarmstrong.com>; Tue, 3 Nov 2009 17:50:40 -0800 Original-Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by paul-mcgann-v0.ics.uci.edu (8.13.8/8.13.8) with ESMTP id nA41oSL8015379 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 3 Nov 2009 17:50:28 -0800 Original-Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id nA41oSjV027181; Tue, 3 Nov 2009 17:50:28 -0800 (PST) In-Reply-To: <87aaz4qd6h.fsf@mail.jurta.org> (Juri Linkov's message of "Tue, 03 Nov 2009 09:29:11 +0200") Original-Lines: 31 X-ICS-MailScanner-Information: Please send mail to helpdesk@ics.uci.edu or more information X-ICS-MailScanner-ID: nA41oSL8015379 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Resent-Date: Tue, 03 Nov 2009 21:07:23 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:32399 Archived-At: Juri Linkov writes: > > > >> Does anyone know a reason why one menu item in menu-bar.el > > > >> (`separator-exit') doesn't use the standard format with `menu-item' > > > >> like all other menu items use? > > > > > > > > Accident? > > > > > > Probably. Fixed. > > > > I think that a better fix would be to purecopy '("--"), there are >60 > > instances of this in GC memory right when emacs starts up. > > > > Maybe define a constant menu-bar-standard-separator and use that > > everywhere? > > I think a constant for "--" is a good idea. Why not '("--"), it's an extra cons? > BTW, I just added a quote in 3 calls of `menu-bar-make-mm-toggle' > in menu-bar.el since this is necessary after your recent changes > in `menu-bar-make-mm-toggle'. Sorry about that. > I hope that no code outside Emacs calls `menu-bar-make-mm-toggle'. > Otherwise, it will be broken. Do you mean the menu-bar-make-mm-toggle is not incompatible with what it was before? Do you see a way to make it compatible?