unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Dan Nicolaescu <dann@ics.uci.edu>
To: Juri Linkov <juri@jurta.org>
Cc: 4677@emacsbugs.donarmstrong.com
Subject: bug#4677: allow VC operations from dired
Date: Fri, 23 Oct 2009 11:21:07 -0700 (PDT)	[thread overview]
Message-ID: <200910231821.n9NIL7Qk000637@godzilla.ics.uci.edu> (raw)
In-Reply-To: <87vdiks99u.fsf@mail.jurta.org> (Juri Linkov's message of "Mon, 12 Oct 2009 23:27:09 +0300")

Juri Linkov <juri@jurta.org> writes:

  > >   > > This patch allows VC operations to be run from dired.
  > >   > > State changing VC operations are not supported.
  > >   > > (only the various variations of log and diff)
  > >   >
  > >   > Thanks, it works right except in one case: when called outside of
  > >   > a repository controlled directory, it traverses all subdirectories
  > >   > trying to find a repository (I think traversing subdirectories
  > >   > makes no sense in this case) and later fails with:
  > >   >
  > >   >   Wrong type argument: stringp, nil
  > >
  > > Thanks.  Here's an updated patch.
  > 
  > Hmm, now it fails with "Directory not under VC" in all directories
  > even under version control since (vc-backend default-directory)
  > always returns nil.

The version that uses vc-responsible-backend should work correctly now
(i.e. it will throw an error) when used in a non VC controlled directory.





  parent reply	other threads:[~2009-10-23 18:21 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200911201637.nAKGb9go024620@godzilla.ics.uci.edu>
2009-10-08 20:19 ` bug#4677: allow VC operations from dired Dan Nicolaescu
2009-10-11 23:55   ` Juri Linkov
2009-10-12  2:46     ` Dan Nicolaescu
2009-10-12 20:27       ` Juri Linkov
2009-10-12 20:51         ` Dan Nicolaescu
2009-10-13 22:38           ` Juri Linkov
2009-10-13 23:22             ` Dan Nicolaescu
2009-10-23 18:21         ` Dan Nicolaescu [this message]
2009-11-19 16:50       ` Dan Nicolaescu
2009-11-19 21:08         ` Stefan Monnier
2009-11-20 16:45   ` bug#4677: marked as done (allow VC operations from dired) Emacs bug Tracking System

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200910231821.n9NIL7Qk000637@godzilla.ics.uci.edu \
    --to=dann@ics.uci.edu \
    --cc=4677@emacsbugs.donarmstrong.com \
    --cc=juri@jurta.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).