From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Bob Rogers Newsgroups: gmane.emacs.bugs,gmane.emacs.pretest.bugs Subject: bug#3261: 23.0.93; minor vc-dir initialization bug Date: Mon, 11 May 2009 22:30:07 -0400 (EDT) Message-ID: <20090512023007.5F56E484BF@rgr.rgrjr.com> Reply-To: Bob Rogers , 3261@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org X-Trace: ger.gmane.org 1242136722 25591 80.91.229.12 (12 May 2009 13:58:42 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 12 May 2009 13:58:42 +0000 (UTC) To: emacs-pretest-bug@gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue May 12 15:58:32 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1M3sUt-0001mY-F3 for geb-bug-gnu-emacs@m.gmane.org; Tue, 12 May 2009 15:58:19 +0200 Original-Received: from localhost ([127.0.0.1]:41162 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M3sUs-0000pw-TD for geb-bug-gnu-emacs@m.gmane.org; Tue, 12 May 2009 09:58:18 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M3i66-0007CG-KG for bug-gnu-emacs@gnu.org; Mon, 11 May 2009 22:52:02 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M3i62-0007C0-QT for bug-gnu-emacs@gnu.org; Mon, 11 May 2009 22:52:02 -0400 Original-Received: from [199.232.76.173] (port=32784 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M3i62-0007Bq-FL for bug-gnu-emacs@gnu.org; Mon, 11 May 2009 22:51:58 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:56967) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1M3i61-000151-PS for bug-gnu-emacs@gnu.org; Mon, 11 May 2009 22:51:58 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n4C2pt3w002542; Mon, 11 May 2009 19:51:55 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n4C2Z4dh029732; Mon, 11 May 2009 19:35:04 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Bob Rogers Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Tue, 12 May 2009 02:35:04 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: report 3261 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by submit@emacsbugs.donarmstrong.com id=B.124209542228582 (code B ref -1); Tue, 12 May 2009 02:35:04 +0000 Original-Received: (at submit) by emacsbugs.donarmstrong.com; 12 May 2009 02:30:22 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n4C2UEoR028415 for ; Mon, 11 May 2009 19:30:15 -0700 Original-Received: from mail.gnu.org ([199.232.76.166]:38469 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1M3hkz-0001Nh-J3 for emacs-pretest-bug@gnu.org; Mon, 11 May 2009 22:30:13 -0400 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1M3hkw-000830-MH for emacs-pretest-bug@gnu.org; Mon, 11 May 2009 22:30:12 -0400 Original-Received: from rgrjr.com ([216.146.47.5]:57181) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1M3hkw-00082p-B2 for emacs-pretest-bug@gnu.org; Mon, 11 May 2009 22:30:10 -0400 Original-Received: from rgrjr.dyndns.org (c-66-30-196-77.hsd1.ma.comcast.net [66.30.196.77]) by rgrjr.com (Postfix on CentOS) with ESMTP id EB09F1600DC for ; Tue, 12 May 2009 02:30:08 +0000 (UTC) Original-Received: (qmail 15913 invoked by uid 89); 12 May 2009 02:30:08 -0000 Original-Received: from unknown (HELO rgr.rgrjr.com) (192.168.57.1) by home with SMTP; 12 May 2009 02:30:08 -0000 Original-Received: by rgr.rgrjr.com (Postfix, from userid 500) id 5F56E484BF; Mon, 11 May 2009 22:30:07 -0400 (EDT) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Mon, 11 May 2009 22:52:02 -0400 X-Mailman-Approved-At: Tue, 12 May 2009 09:57:51 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:27847 gmane.emacs.pretest.bugs:24410 Archived-At: To reproduce in Emacs trunk (as of Friday): 1. "emacs -Q" in a VC directory, preferably one in which updates take more than a few seconds (large tree, distant/slow server, or both). 2. "C-x v d" to get into the *vc-dir* buffer, and *immediately* type "n" (vc-dir-next-line) before the buffer has any file lines. This gives me a "wrong type argument" error (backtrace below) when ewoc-goto-node tries to treat "nil" as a node. The tweak to ewoc-goto-next (below the backtrace) produces a better error message, but is still too generic. -- Bob Rogers http://www.rgrjr.com/ ======================================================================== Backtrace: Debugger entered--Lisp error: (wrong-type-argument arrayp nil) ewoc-goto-node([cl-struct-ewoc # (lambda (&rest --cl-rest--) (apply #[... "J !=3fff88=3fffc2c=3fff87" [G39800 data "\n"] 2] ... --cl-rest--)) [[[#1 #2 "" #] #1 DL-LIST #] [#1 [#2 #1 DL-LIST #] "" #] #("VC backend : SVN\nWorking dir: /shared.local/mgi/modest/\nRepository : https://www.modulargenetics.com/svn/modest\n" 0 13 ... 13 17 ... 17 30 ... 30 56 ... 56 69 ... 69 111 ...) #] [[[#1 #2 DL-LIST #] #1 #("VC backend : SVN\nWorking dir: /shared.local/mgi/modest/\nRepository : https://www.modulargenetics.com/svn/modest\n" 0 13 ... 13 17 ... 17 30 ... 30 56 ... 56 69 ... 69 111 ...) #] [#1 [ #2 #1 #("VC backend : SVN\nWorking dir: /shared.local/mgi/modest/\nRepository : https://www.modulargenetics.com/svn/modest\n" 0 13 ... 13 17 ... 17 30 ... 30 56 ... 56 69 ... 69 111 ...) #] DL-LIST #] "" #] [[[#1 #2 #("VC backend : SVN\nWorking dir: /shared.local/mgi/modest/\nRepository : https://www.modulargenetics.com/svn/modest\n" 0 13 ... 13 17 ... 17 30 ... 30 56 ... 56 69 ... 69 111 ...) #] #1 "" #] [#1 [#2 #1 "" #] #("VC backend : SVN\nWorking dir: /shared.local/mgi/modest/\nRepository : https://www.modulargenetics.com/svn/modest\n" 0 13 ... 13 17 ... 17 30 ... 30 56 ... 56 69 ... 69 111 ...) #] DL-LIST #] nil (lambda (&rest --cl-rest--) (apply #[... "J !=3fff88=3fffc2c=3fff87" [G39800 data "\n"] 2] ... --cl-rest--))] nil) ewoc-goto-next([cl-struct-ewoc # (lambda (&rest --cl-rest--) (apply #[... "J !=3fff88=3fffc2c=3fff87" [G39800 data "\n"] 2] ... --cl-rest--)) [[[#1 #2 "" #] #1 DL-LIST #] [#1 [#2 #1 DL-LIST #] "" #] #("VC backend : SVN\nWorking dir: /shared.local/mgi/modest/\nRepository : https://www.modulargenetics.com/svn/modest\n" 0 13 ... 13 17 ... 17 30 ... 30 56 ... 56 69 ... 69 111 ...) #] [[[#1 #2 DL-LIST #] #1 #("VC backend : SVN\nWorking dir: /shared.local/mgi/modest/\nRepository : https://www.modulargenetics.com/svn/modest\n" 0 13 ... 13 17 ... 17 30 ... 30 56 ... 56 69 ... 69 111 ...) #] [#1 [ #2 #1 #("VC backend : SVN\nWorking dir: /shared.local/mgi/modest/\nRepository : https://www.modulargenetics.com/svn/modest\n" 0 13 ... 13 17 ... 17 30 ... 30 56 ... 56 69 ... 69 111 ...) #] DL-LIST #] "" #] [[[#1 #2 #("VC backend : SVN\nWorking dir: /shared.local/mgi/modest/\nRepository : https://www.modulargenetics.com/svn/modest\n" 0 13 ... 13 17 ... 17 30 ... 30 56 ... 56 69 ... 69 111 ...) #] #1 "" #] [#1 [#2 #1 "" #] #("VC backend : SVN\nWorking dir: /shared.local/mgi/modest/\nRepository : https://www.modulargenetics.com/svn/modest\n" 0 13 ... 13 17 ... 17 30 ... 30 56 ... 56 69 ... 69 111 ...) #] DL-LIST #] nil (lambda (&rest --cl-rest--) (apply #[... "J !=3fff88=3fffc2c=3fff87" [G39800 data "\n"] 2] ... --cl-rest--))] 1) vc-dir-next-line(1) call-interactively(vc-dir-next-line nil nil) =================================================================== Patch: RCS file: /sources/emacs/emacs/lisp/emacs-lisp/ewoc.el,v retrieving revision 1.47 diff -u -r1.47 ewoc.el --- lisp/emacs-lisp/ewoc.el 5 Jan 2009 03:21:00 -0000 1.47 +++ lisp/emacs-lisp/ewoc.el 12 May 2009 02:21:47 -0000 @@ -496,6 +496,8 @@ ;; Never step below the first element. ;; (unless (ewoc--filter-hf-nodes ewoc node) ;; (setq node (ewoc--node-nth dll -2))) + (unless node + (error "No next.")) (ewoc-goto-node ewoc node))) (defun ewoc-goto-node (ewoc node) ======================================================================== In GNU Emacs 23.0.93.1 (i686-pc-linux-gnu, GTK+ Version 2.12.9) of 2009-05-08 on rgr Windowing system distributor `The X.Org Foundation', version 11.0.10400090 Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: en_US.UTF-8 value of $XMODIFIERS: nil locale-coding-system: utf-8-unix default-enable-multibyte-characters: t