bug#2989: implement bash's ignoredups

bug#2989: implement bash's ignoredups

[jidanni]

M-p (translated from <escape> p) runs the command previous-history-element

Which gets rather frustrating when one runs into a long patch of the
same command, e.g.,

(compile "make" nil)
(compile "make" nil)
(compile "make" nil)

That's because emacs hasn't implement bash's ignoredups:

       HISTCONTROL

              ...value of
              ignoredups causes lines matching the previous history
              entry to not be saved...A value of erasedups
              causes all previous lines matching the current line to be
              removed from the history list before that line is saved.

Note I'm not talking about the *shell* buffer, but instead
repeat-complex-command's previous-history-element etc.

bug#2989: marked as done (implement bash's ignoredups)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 878 bytes --]


Your message dated Mon, 13 Apr 2009 18:20:38 -0700 (PDT)
with message-id <200904140120.n3E1Kbm2006695@godzilla.ics.uci.edu>
and subject line Re: bug#2989: implement bash's ignoredups
has caused the Emacs bug report #2989,
regarding implement bash's ignoredups
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
2989: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=2989
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 2728 bytes --]

From: jidanni@jidanni.org
To: bug-gnu-emacs@gnu.org
Subject: implement bash's ignoredups
Date: Tue, 14 Apr 2009 08:00:17 +0800
Message-ID: <87d4bgt88e.fsf@jidanni.org>

M-p (translated from <escape> p) runs the command previous-history-element

Which gets rather frustrating when one runs into a long patch of the
same command, e.g.,

(compile "make" nil)
(compile "make" nil)
(compile "make" nil)

That's because emacs hasn't implement bash's ignoredups:

       HISTCONTROL

              ...value of
              ignoredups causes lines matching the previous history
              entry to not be saved...A value of erasedups
              causes all previous lines matching the current line to be
              removed from the history list before that line is saved.

Note I'm not talking about the *shell* buffer, but instead
repeat-complex-command's previous-history-element etc.




[-- Attachment #3: Type: message/rfc822, Size: 2867 bytes --]

From: Dan Nicolaescu <dann@ics.uci.edu>
To: jidanni@jidanni.org
Cc: 2989-done@emacsbugs.donarmstrong.com
Subject: Re: bug#2989: implement bash's ignoredups
Date: Mon, 13 Apr 2009 18:20:38 -0700 (PDT)
Message-ID: <200904140120.n3E1Kbm2006695@godzilla.ics.uci.edu>

jidanni@jidanni.org writes:

  > M-p (translated from <escape> p) runs the command previous-history-element
  > 
  > Which gets rather frustrating when one runs into a long patch of the
  > same command, e.g.,
  > 
  > (compile "make" nil)
  > (compile "make" nil)
  > (compile "make" nil)
  > 
  > That's because emacs hasn't implement bash's ignoredups:
  > 
  >        HISTCONTROL
  > 
  >               ...value of
  >               ignoredups causes lines matching the previous history
  >               entry to not be saved...A value of erasedups
  >               causes all previous lines matching the current line to be
  >               removed from the history list before that line is saved.
  > 
  > Note I'm not talking about the *shell* buffer, but instead
  > repeat-complex-command's previous-history-element etc.

emacs/etc/NEWS.22
*** New user option `history-delete-duplicates'.
If set to t when adding a new history element, all previous identical
elements are deleted from the history list.

bug#2989: marked as done (history-delete-duplicates does not apply to command history)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 942 bytes --]


Your message dated Tue, 14 Apr 2009 17:09:54 -0700 (PDT)
with message-id <200904150009.n3F09sos005185@godzilla.ics.uci.edu>
and subject line Re: bug#2989: history-delete-duplicates does not apply to command history
has caused the Emacs bug report #2989,
regarding history-delete-duplicates does not apply to command history
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
2989: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=2989
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 2728 bytes --]

From: jidanni@jidanni.org
To: bug-gnu-emacs@gnu.org
Subject: implement bash's ignoredups
Date: Tue, 14 Apr 2009 08:00:17 +0800
Message-ID: <87d4bgt88e.fsf@jidanni.org>

M-p (translated from <escape> p) runs the command previous-history-element

Which gets rather frustrating when one runs into a long patch of the
same command, e.g.,

(compile "make" nil)
(compile "make" nil)
(compile "make" nil)

That's because emacs hasn't implement bash's ignoredups:

       HISTCONTROL

              ...value of
              ignoredups causes lines matching the previous history
              entry to not be saved...A value of erasedups
              causes all previous lines matching the current line to be
              removed from the history list before that line is saved.

Note I'm not talking about the *shell* buffer, but instead
repeat-complex-command's previous-history-element etc.




[-- Attachment #3: Type: message/rfc822, Size: 2852 bytes --]

From: Dan Nicolaescu <dann@ics.uci.edu>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 2989-done@emacsbugs.donarmstrong.com, jidanni@jidanni.org
Subject: Re: bug#2989: history-delete-duplicates does not apply to command history
Date: Tue, 14 Apr 2009 17:09:54 -0700 (PDT)
Message-ID: <200904150009.n3F09sos005185@godzilla.ics.uci.edu>

Stefan Monnier <monnier@iro.umontreal.ca> writes:

  > >> > You probably want to open another bug saying that
  > >> I'll just hopefully hereby reopen and retitle this one.
  > >> > history-delete-duplicates does not apply to command history.
  > >> (OK, but not sure you don't want two independent variables...)
  > >> > You can try this (not even compile tested) patch:
  > >> > --- callint.c.~1.172.~	Tue Mar 31 16:28:30 2009
  > >> (Please test for me, I don't own a c-compiler here :-) )
  > 
  > > The patch needed an extra declaration to compile, and it seems to work fine.
  > 
  > > I am not sure if it's acceptable to check in such a change at this point
  > > in the release process.
  > 
  > Yes, it's fine, thank you, please install it.

Done.

bug#2989: implement bash's ignoredups

[jidanni]

Dan Nicolaescu <dann@ics.uci.edu> writes:
> *** New user option `history-delete-duplicates'.
Well, OK, but see, there they still are at the <escape> p's below.
$ cd /tmp
$ echo a:\;date>Makefile
$ emacs -Q -eval '(setq history-delete-duplicates t)' Makefile
<escape> x c o m p i l e <return> <return> <escape> x <up>
<return> <return> <escape> x <up> <return> <return>
C-x <escape> <escape> <escape> p <escape> p <escape> p
emacs-version "22.3.1" (Yes, I still use <escape>).

bug#2989: implement bash's ignoredups

[Dan Nicolaescu]

jidanni@jidanni.org writes:

  > Dan Nicolaescu <dann@ics.uci.edu> writes:
  > > *** New user option `history-delete-duplicates'.
  > Well, OK, but see, there they still are at the <escape> p's below.
  > $ cd /tmp
  > $ echo a:\;date>Makefile
  > $ emacs -Q -eval '(setq history-delete-duplicates t)' Makefile
  > <escape> x c o m p i l e <return> <return> <escape> x <up>
  > <return> <return> <escape> x <up> <return> <return>
  > C-x <escape> <escape> <escape> p <escape> p <escape> p
  > emacs-version "22.3.1" (Yes, I still use <escape>).

You probably want to open another bug saying that
history-delete-duplicates does not apply to command history.

You can try this (not even compile tested) patch:

--- callint.c.~1.172.~	Tue Mar 31 16:28:30 2009
+++ callint.c	Mon Apr 13 18:54:56 2009
@@ -370,8 +370,12 @@
 	     and turn them into things we can eval.  */
 	  values = quotify_args (Fcopy_sequence (specs));
 	  fix_command (input, values);
-	  Vcommand_history
-	    = Fcons (Fcons (function, values), Vcommand_history);
+	  {
+	    Lisp_Object this_cmd = Fcons (function, values);
+	    if (history_delete_duplicates) 
+	      Vcommand_history = Fdelete (this_cmd, Vcommand_history);
+	    Vcommand_history = Fcons (this_cmd, Vcommand_history);
+	  }
 
 	  /* Don't keep command history around forever.  */
 	  if (INTEGERP (Vhistory_length) && XINT (Vhistory_length) > 0)

bug#2989: history-delete-duplicates does not apply to command history

[jidanni]

reopen 2989
retitle 2989 history-delete-duplicates does not apply to command history
thanks
Dan Nicolaescu <dann@ics.uci.edu> writes:
> You probably want to open another bug saying that
I'll just hopefully hereby reopen and retitle this one.
> history-delete-duplicates does not apply to command history.
(OK, but not sure you don't want two independent variables...)
> You can try this (not even compile tested) patch:
> --- callint.c.~1.172.~	Tue Mar 31 16:28:30 2009
(Please test for me, I don't own a c-compiler here :-) )

Processed: history-delete-duplicates does not apply to command history

[Emacs bug Tracking System]

Processing commands for control@emacsbugs.donarmstrong.com:

> reopen 2989
bug#2989: implement bash's ignoredups
bug reopened, originator not changed.

> retitle 2989 history-delete-duplicates does not apply to command history
bug#2989: implement bash's ignoredups
Changed bug title to `history-delete-duplicates does not apply to command history' from `implement bash's ignoredups'.

> thanks
Stopping processing here.

Please contact me if you need assistance.

Don Armstrong
(administrator, Emacs bugs database)

bug#2989: history-delete-duplicates does not apply to command history

[Dan Nicolaescu]

jidanni@jidanni.org writes:

  > Dan Nicolaescu <dann@ics.uci.edu> writes:
  > > You probably want to open another bug saying that
  > I'll just hopefully hereby reopen and retitle this one.
  > > history-delete-duplicates does not apply to command history.
  > (OK, but not sure you don't want two independent variables...)
  > > You can try this (not even compile tested) patch:
  > > --- callint.c.~1.172.~	Tue Mar 31 16:28:30 2009
  > (Please test for me, I don't own a c-compiler here :-) )

The patch needed an extra declaration to compile, and it seems to work fine.

I am not sure if it's acceptable to check in such a change at this point
in the release process.

bug#2989: history-delete-duplicates does not apply to command history

[Stefan Monnier]

>> > You probably want to open another bug saying that
>> I'll just hopefully hereby reopen and retitle this one.
>> > history-delete-duplicates does not apply to command history.
>> (OK, but not sure you don't want two independent variables...)
>> > You can try this (not even compile tested) patch:
>> > --- callint.c.~1.172.~	Tue Mar 31 16:28:30 2009
>> (Please test for me, I don't own a c-compiler here :-) )

> The patch needed an extra declaration to compile, and it seems to work fine.

> I am not sure if it's acceptable to check in such a change at this point
> in the release process.

Yes, it's fine, thank you, please install it.


        Stefan