From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.bugs Subject: bug#2604: 23.0.91; key bindings in vc-annotate incompatible w/ Emacs 22 Date: Mon, 9 Mar 2009 17:42:26 -0700 (PDT) Message-ID: <200903100042.n2A0gQm6022368@rodan.ics.uci.edu> References: <87wsazehs7.fsf@marauder.physik.uni-ulm.de> <200903091748.n29HmjcZ018979@rodan.ics.uci.edu> <87k56ycvvy.fsf@marauder.physik.uni-ulm.de> Reply-To: Dan Nicolaescu , 2604@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1236647098 19498 80.91.229.12 (10 Mar 2009 01:04:58 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 10 Mar 2009 01:04:58 +0000 (UTC) To: 2604@emacsbugs.donarmstrong.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Mar 10 02:06:15 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LgqPD-0000vH-U4 for geb-bug-gnu-emacs@m.gmane.org; Tue, 10 Mar 2009 02:05:43 +0100 Original-Received: from localhost ([127.0.0.1]:42456 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LgqNr-0002Cs-UO for geb-bug-gnu-emacs@m.gmane.org; Mon, 09 Mar 2009 21:03:51 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LgqNm-0002C7-Kj for bug-gnu-emacs@gnu.org; Mon, 09 Mar 2009 21:03:46 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LgqNk-00028V-AV for bug-gnu-emacs@gnu.org; Mon, 09 Mar 2009 21:03:46 -0400 Original-Received: from [199.232.76.173] (port=60534 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LgqNj-00028H-W0 for bug-gnu-emacs@gnu.org; Mon, 09 Mar 2009 21:03:44 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:44999) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LgqNj-0005Pz-1Z for bug-gnu-emacs@gnu.org; Mon, 09 Mar 2009 21:03:43 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n2A13eRZ021135; Mon, 9 Mar 2009 18:03:41 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n2A0o3m7017372; Mon, 9 Mar 2009 17:50:03 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Dan Nicolaescu Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Tue, 10 Mar 2009 00:50:03 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 2604 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 2604-submit@emacsbugs.donarmstrong.com id=B2604.123664576415910 (code B ref 2604); Tue, 10 Mar 2009 00:50:03 +0000 Original-Received: (at 2604) by emacsbugs.donarmstrong.com; 10 Mar 2009 00:42:44 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from sallyv2.ics.uci.edu (sallyv2.ics.uci.edu [128.195.1.120]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n2A0gffW015903 for <2604@emacsbugs.donarmstrong.com>; Mon, 9 Mar 2009 17:42:42 -0700 Original-Received: from rodan.ics.uci.edu (rodan.ics.uci.edu [128.195.6.9]) by sallyv2.ics.uci.edu (8.13.7+Sun/8.13.7) with ESMTP id n2A0gRp2019101 for <2604@emacsbugs.donarmstrong.com>; Mon, 9 Mar 2009 17:42:27 -0700 (PDT) Original-Received: (from dann@localhost) by rodan.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id n2A0gQm6022368; Mon, 9 Mar 2009 17:42:26 -0700 (PDT) In-Reply-To: <87k56ycvvy.fsf@marauder.physik.uni-ulm.de> (Reiner Steib's message of "Mon, 09 Mar 2009 20:57:05 +0100") Original-Lines: 71 X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: n2A0gRp2019101 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@rodan.ics.uci.edu X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Mon, 09 Mar 2009 21:03:46 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:26197 Archived-At: Reiner Steib writes: > On Mon, Mar 09 2009, Dan Nicolaescu wrote: > > > Reiner Steib writes: > > > - D > > > > > > Instead of showing diff of revision at line (as in Emacs 22), I get: > > > > > > ,----[ *Messages* ] > > > | vc-annotate-show-changeset-diff-revision-at-line: > > > | The CVS backend does not support changeset diffs > > > `---- > > > > > > Is this change intended? > > > > It is. > > > > > I could understand that `D' should now work > > > on change sets, but please at least mention it in NEWS and tell the > > > user to try `d' instead or better just display the warning and than > > > call `vc-annotate-show-diff-revision-at-line' if no change set > > > operation is available. > > > > I am not sure that is better. But if you can suggest a better wording > > for the error message, go for it. > > How about this? (Same in `log-view-diff-changeset', probably.) > > --- vc-annotate.el 09 Jan 2009 09:52:59 +0100 1.7 > +++ vc-annotate.el 09 Mar 2009 20:35:28 +0100 > @@ -506,7 +506,10 @@ > "Visit the diff of the revision at line from its previous revision for all files in the changeset." > (interactive) > (when (eq 'file (vc-call-backend vc-annotate-backend 'revision-granularity)) > - (error "The %s backend does not support changeset diffs" vc-annotate-backend)) > + (error > + (substitute-command-keys "The %s backend does not support changeset diffs. \ > +Use \\[vc-annotate-show-diff-revision-at-line] to diff this file.") > + vc-annotate-backend)) > (vc-annotate-show-diff-revision-at-line-internal nil)) > > (defun vc-annotate-warp-revision (revspec) > > > > - L > > > > > > Instead of showing log of revision at line (as in Emacs 22), nothing > > > happens. > > > > > > If there's no useful binding for `L', why not bind it to > > > `vc-annotate-show-log-revision-at-line' or at least tell the user to > > > use `l' (lowercase L) and also document it in NEWS. > > > > That would be a bad idea. > > Do you also consider the following as bad? Yup. There are other keys too. So the choice is not just do `L', it's do all or none. I think none is preferable in order to avoid complications and future burden. > > Yes, it would take a tiny bit of effort for the users to get used to > > the lower case bindings, but given that they are easier to type it > > should not be too bad. > > My first reaction was that I really thought these feature won't work > anymore Emacs 23 because of the (partial) rewrite of Emacs' VC system. Users can look at the menus, and see the functions are still there. For experienced users that don't use menus, they can figure out in a number of ways what the key bindings are.