From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.bugs Subject: bug#2604: 23.0.91; key bindings in vc-annotate incompatible w/ Emacs 22 Date: Mon, 9 Mar 2009 10:49:08 -0700 (PDT) Message-ID: <200903091749.n29Hn8eo018980@rodan.ics.uci.edu> References: <87wsazehs7.fsf@marauder.physik.uni-ulm.de> Reply-To: Dan Nicolaescu , 2604@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1236621893 32296 80.91.229.12 (9 Mar 2009 18:04:53 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 9 Mar 2009 18:04:53 +0000 (UTC) Cc: 2604@emacsbugs.donarmstrong.com To: Reiner Steib Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Mar 09 19:06:09 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from terminus-est.gnu.org ([66.92.78.210] helo=lists.gnu.org) by lo.gmane.org with esmtp (Exim 4.50) id 1Lgjr1-0001mY-Jw for geb-bug-gnu-emacs@m.gmane.org; Mon, 09 Mar 2009 19:05:55 +0100 Original-Received: from localhost ([127.0.0.1]:57894 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Lgjpf-0006Zj-4O for geb-bug-gnu-emacs@m.gmane.org; Mon, 09 Mar 2009 14:04:07 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LgjpM-0006C1-F8 for bug-gnu-emacs@gnu.org; Mon, 09 Mar 2009 14:03:48 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LgjpK-00069G-W6 for bug-gnu-emacs@gnu.org; Mon, 09 Mar 2009 14:03:47 -0400 Original-Received: from [199.232.76.173] (port=57258 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LgjpK-00068e-Ng for bug-gnu-emacs@gnu.org; Mon, 09 Mar 2009 14:03:46 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:44733) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LgjpJ-0003UB-Md for bug-gnu-emacs@gnu.org; Mon, 09 Mar 2009 14:03:46 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n29I3eAd005429; Mon, 9 Mar 2009 11:03:40 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n29Ht5nI003129; Mon, 9 Mar 2009 10:55:05 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Dan Nicolaescu Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Mon, 09 Mar 2009 17:55:05 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 2604 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 2604-submit@emacsbugs.donarmstrong.com id=B2604.12366209621561 (code B ref 2604); Mon, 09 Mar 2009 17:55:05 +0000 Original-Received: (at 2604) by emacsbugs.donarmstrong.com; 9 Mar 2009 17:49:22 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from sallyv2.ics.uci.edu (sallyv2.ics.uci.edu [128.195.1.120]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n29HnJWk001555 for <2604@emacsbugs.donarmstrong.com>; Mon, 9 Mar 2009 10:49:20 -0700 Original-Received: from rodan.ics.uci.edu (rodan.ics.uci.edu [128.195.6.9]) by sallyv2.ics.uci.edu (8.13.7+Sun/8.13.7) with ESMTP id n29Hn8Yt028080; Mon, 9 Mar 2009 10:49:08 -0700 (PDT) Original-Received: (from dann@localhost) by rodan.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id n29Hn8eo018980; Mon, 9 Mar 2009 10:49:08 -0700 (PDT) Original-Lines: 51 X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: n29Hn8Yt028080 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@rodan.ics.uci.edu X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Mon, 09 Mar 2009 14:03:47 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:26184 Archived-At: Reiner Steib writes: > Hi, > > > Please describe exactly what actions triggered the bug > > and the precise symptoms of the bug: > > - C-x C-f lisp/gnus/gnus.el RET > > - M-x vc-annotate RET > > - D > > Instead of showing diff of revision at line (as in Emacs 22), I get: > > ,----[ *Messages* ] > | vc-annotate-show-changeset-diff-revision-at-line: > | The CVS backend does not support changeset diffs > `---- > > Is this change intended? It is. > I could understand that `D' should now work > on change sets, but please at least mention it in NEWS and tell the > user to try `d' instead or better just display the warning and than > call `vc-annotate-show-diff-revision-at-line' if no change set > operation is available. I am not sure that is better. But if you can suggest a better wording for the error message, go for it. > - L > > Instead of showing log of revision at line (as in Emacs 22), nothing > happens. > > If there's no useful binding for `L', why not bind it to > `vc-annotate-show-log-revision-at-line' or at least tell the user to > use `l' (lowercase L) and also document it in NEWS. That would be a bad idea. All the bindings for vc-annotate were upper case. And that was only because vc-annotate was derived from `view-mode' which was binding almost all lower case keys. With more keys to bind we can add better functionality to vc-annotate (like the 'd' and 'D' bindings), so it would be a bad idea to Yes, it would take a tiny bit of effort for the users to get used to the lower case bindings, but given that they are easier to type it should not be too bad. I'll make a note in NEWS about the changed bindings.