bug#2549: 23.0.60; doc-view: scrolling other window wraps unexpectedly

bug#2549: 23.0.60; doc-view: scrolling other window wraps unexpectedly

[Markus Triska]

With p.ps from:

   http://www.logic.at/prolog/p.ps

when I do:

   $ emacs -Q p.ps

and press:

   C-c C-c C-x 2

and then press C-M-v repeatedly, the other window eventually wraps
around instead of stopping at the image border like C-v does.


In GNU Emacs 23.0.60.2 (i386-apple-darwin8.11.1, GTK+ Version 2.12.9)
 of 2009-01-06 on mt-computer.local
Windowing system distributor `The XFree86 Project, Inc', version 11.0.40400000
Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_GB.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: nil
  default-enable-multibyte-characters: t

bug#2549: 23.0.60; doc-view: scrolling other window wraps unexpectedly

[Tassilo Horn]

Markus Triska <markus.triska@gmx.at> writes:

Hi Markus,

> With p.ps from:
>
>    http://www.logic.at/prolog/p.ps
>
> when I do:
>
>    $ emacs -Q p.ps
>
> and press:
>
>    C-c C-c C-x 2
>
> and then press C-M-v repeatedly, the other window eventually wraps
> around instead of stopping at the image border like C-v does.

That's because `scroll-other-window' calls scroll-up/down in the other
window, but if the other window contains an doc-view buffer it should
ideally call image-scroll-up/down.

The only good solution I see is to define buffer local variables
`scroll-up-function' and `scroll-down-function' which are used by
`scroll-up' and `scroll-down' and then binding them appropriate in each
mode.

Anyway, that's not really related to doc-view.  All non-text modes are
pertained here.  Comments?

Bye,
Tassilo

bug#2549: 23.0.60; doc-view: scrolling other window wraps unexpectedly

[Stefan Monnier]

> That's because `scroll-other-window' calls scroll-up/down in the other
> window, but if the other window contains an doc-view buffer it should
> ideally call image-scroll-up/down.

> The only good solution I see is to define buffer local variables
> `scroll-up-function' and `scroll-down-function' which are used by
> `scroll-up' and `scroll-down' and then binding them appropriate in
> each mode.

Indeed, something like a hook seems necessary.  I'd rather leave it as
is for Emacs-23.1, tho.  Makes me wonder: do we have a way to tag bugs
as "post-23.1"?


        Stefan

bug#2549: 23.0.60; doc-view: scrolling other window wraps unexpectedly

[Tassilo Horn]

Stefan Monnier <monnier@IRO.UMontreal.CA> writes:

>> That's because `scroll-other-window' calls scroll-up/down in the
>> other window, but if the other window contains an doc-view buffer it
>> should ideally call image-scroll-up/down.
>
>> The only good solution I see is to define buffer local variables
>> `scroll-up-function' and `scroll-down-function' which are used by
>> `scroll-up' and `scroll-down' and then binding them appropriate in
>> each mode.
>
> Indeed, something like a hook seems necessary.  I'd rather leave it as
> is for Emacs-23.1, tho.  Makes me wonder: do we have a way to tag bugs
> as "post-23.1"?

We could abuse the "Version:" pseudo-header for that or create a new tag
for that.  The latter seems more desirable, but I don't know how to
create a tag.  Maybe they're created automagically?  I'll try by sending

  tags 2549 + post-23.1

to the control server address...

Bye,
Tassilo

bug#2549: 23.0.60; doc-view: scrolling other window wraps unexpectedly

[Stefan Monnier]

> We could abuse the "Version:" pseudo-header for that or create a new tag
> for that.  The latter seems more desirable, but I don't know how to
> create a tag.  Maybe they're created automagically?  I'll try by sending

>   tags 2549 + post-23.1

> to the control server address...

Actually, I think there's a way to classify bugs w.r.t releases.
So probably not tagging this as "post-23.1" but rather tagging the
others as "needs to be fixed before we can release Emacs-23.1".
But I can't figure out how to do it.


        Stefan

bug#2549: 23.0.60; doc-view: scrolling other window wraps unexpectedly

[martin rudalics]

 > That's because `scroll-other-window' calls scroll-up/down in the other
 > window, but if the other window contains an doc-view buffer it should
 > ideally call image-scroll-up/down.

Just a technical note: `scroll-other-window' calls window_scroll and not
scroll-up/down.

martin

bug#2549: Bug still present

[Marcin Borkowski]

As of GNU Emacs 25.1.50.1, this bug still persists (both in doc-view and
a third-party module pdf-tools, see https://github.com/politza/pdf-tools).

-- 
Marcin Borkowski
http://octd.wmi.amu.edu.pl/en/Marcin_Borkowski
Faculty of Mathematics and Computer Science
Adam Mickiewicz University

bug#2549: Bug still present

[Alan Mackenzie]

In article <mailman.2298.1452706808.843.bug-gnu-emacs@gnu.org> you wrote:
> As of GNU Emacs 25.1.50.1, this bug still persists (both in doc-view and
> a third-party module pdf-tools, see https://github.com/politza/pdf-tools).

Just a small matter, but it might be helpful if you could give some
indication within the body of posts what the bugs referred to are about.
Even just giving the original titles would be most appreciated.

> -- 
> Marcin Borkowski
> http://octd.wmi.amu.edu.pl/en/Marcin_Borkowski
> Faculty of Mathematics and Computer Science
> Adam Mickiewicz University

-- 
Alan Mackenzie (Nuremberg, Germany).

bug#2549: Bug still present

[Eli Zaretskii]

> From: Marcin Borkowski <mbork@mbork.pl>
> Date: Wed, 13 Jan 2016 18:38:53 +0100
> 
> As of GNU Emacs 25.1.50.1, this bug still persists (both in doc-view and
> a third-party module pdf-tools, see https://github.com/politza/pdf-tools).

Would you like to propose a patch along the lines discussed in the
beginning of this bug analysis?

Thanks.

bug#21439: 25.0.50; Make scroll-other-window work with special modes such as doc-view-mode

[Lars Ingebrigtsen]

Markus Triska <markus.triska@gmx.at> writes:

> With p.ps from:
>
>    http://www.logic.at/prolog/p.ps
>
> when I do:
>
>    $ emacs -Q p.ps
>
> and press:
>
>    C-c C-c C-x 2
>
> and then press C-M-v repeatedly, the other window eventually wraps
> around instead of stopping at the image border like C-v does.

(I'm going through old bug reports that unfortunately weren't resolved
at the time.)

I can reproduce this in Emacs 28.1, but not in Emacs 29 --
scroll-other-window was recently changed to respect how scrolling
commands are defined in the "other window".

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no