From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Nick Roberts Newsgroups: gmane.emacs.bugs,gmane.emacs.pretest.bugs Subject: bug#2092: 23.0.60; vc-svn-diff Date: Wed, 28 Jan 2009 19:34:34 +1300 (NZDT) Message-ID: <20090128063434.74C018FC6D@kahikatea.snap.net.nz> Reply-To: Nick Roberts , 2092@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org X-Trace: ger.gmane.org 1233127432 26379 80.91.229.12 (28 Jan 2009 07:23:52 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 28 Jan 2009 07:23:52 +0000 (UTC) To: emacs-pretest-bug@gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jan 28 08:25:05 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LS4nI-0004rO-AH for geb-bug-gnu-emacs@m.gmane.org; Wed, 28 Jan 2009 08:25:04 +0100 Original-Received: from localhost ([127.0.0.1]:40624 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LS4m0-000371-6K for geb-bug-gnu-emacs@m.gmane.org; Wed, 28 Jan 2009 02:23:44 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LS4ls-00034r-IQ for bug-gnu-emacs@gnu.org; Wed, 28 Jan 2009 02:23:36 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LS4lp-000332-6r for bug-gnu-emacs@gnu.org; Wed, 28 Jan 2009 02:23:34 -0500 Original-Received: from [199.232.76.173] (port=50190 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LS4lp-00032s-2w for bug-gnu-emacs@gnu.org; Wed, 28 Jan 2009 02:23:33 -0500 Original-Received: from mx20.gnu.org ([199.232.41.8]:56473) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LS4lo-00014q-9Z for bug-gnu-emacs@gnu.org; Wed, 28 Jan 2009 02:23:32 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LS4ln-0001aZ-Av for bug-gnu-emacs@gnu.org; Wed, 28 Jan 2009 02:23:31 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0S7NTBG001862; Tue, 27 Jan 2009 23:23:30 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n0S7F2TP031991; Tue, 27 Jan 2009 23:15:02 -0800 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Nick Roberts Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Wed, 28 Jan 2009 07:15:02 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: report 2092 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by submit@emacsbugs.donarmstrong.com id=B.123312632530634 (code B ref -1); Wed, 28 Jan 2009 07:15:02 +0000 Original-Received: (at submit) by emacsbugs.donarmstrong.com; 28 Jan 2009 07:05:25 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0S75LAn030628 for ; Tue, 27 Jan 2009 23:05:22 -0800 Original-Received: from mail.gnu.org ([199.232.76.166]:60245 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1LS4Sc-0006no-1b for emacs-pretest-bug@gnu.org; Wed, 28 Jan 2009 02:03:42 -0500 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1LS4U8-0007Rw-HU for emacs-pretest-bug@gnu.org; Wed, 28 Jan 2009 02:05:19 -0500 Original-Received: from viper.snap.net.nz ([202.37.101.23]:50958) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LS4U8-0007R5-47 for emacs-pretest-bug@gnu.org; Wed, 28 Jan 2009 02:05:16 -0500 Original-Received: from kahikatea.snap.net.nz (unknown [123.255.31.95]) by viper.snap.net.nz (Postfix) with ESMTP id 0DAD73DA8C9 for ; Wed, 28 Jan 2009 19:35:46 +1300 (NZDT) Original-Received: by kahikatea.snap.net.nz (Postfix, from userid 1000) id 74C018FC6D; Wed, 28 Jan 2009 19:34:34 +1300 (NZDT) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.4-2.6 X-detected-kernel: by mx20.gnu.org: Linux 2.6 (newer, 3) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) Resent-Date: Wed, 28 Jan 2009 02:23:34 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:24668 gmane.emacs.pretest.bugs:23796 Archived-At: vc-svn-diff fails when oldvers equals (vc-working-revision f). In that case "svn diff" executes with no -r argument and only gives a diff if the file is locally modified. To see this bug, do vc-print-log on a file under Subversion control that needs an update (newer revisions have been committed by someone else). Place the cursor over the revision after (in time) the working-revision (the revison with the number in the modeline) and press d (log-viw-diff). I think this clause needs to be removed: (and oldvers files (catch 'no (dolist (f files) (or (equal oldvers (vc-working-revision f)) (throw 'no nil))) t) ;; Use nil rather than the current revision because svn handles ;; it better (i.e. locally). Note that if _any_ of the files ;; has a different revision, we fetch the lot, which is ;; obviously sub-optimal. (setq oldvers nil)) I don't see how it could ever work (please note that I'm not saying that it could never work just that I don't see how it could). -- Nick http://www.inet.net.nz/~nickrob