From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.bugs Subject: bug#1191: How to contribute back changes for Emacs on Solaris Date: Thu, 11 Dec 2008 10:14:51 -0800 (PST) Message-ID: <200812111814.mBBIEpki000573@mothra.ics.uci.edu> References: <48F80A14.7010502@emvision.com> <200812111747.mBBHl5Vb000507@mothra.ics.uci.edu> <4941579A.9050603@emvision.com> Reply-To: Dan Nicolaescu , 1191@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1229019966 25976 80.91.229.12 (11 Dec 2008 18:26:06 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 11 Dec 2008 18:26:06 +0000 (UTC) Cc: 1191@emacsbugs.donarmstrong.com To: Ali Bahrami Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Dec 11 19:27:07 2008 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LAqFQ-00049f-Lh for geb-bug-gnu-emacs@m.gmane.org; Thu, 11 Dec 2008 19:26:53 +0100 Original-Received: from localhost ([127.0.0.1]:36899 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LAqEF-0007jV-6D for geb-bug-gnu-emacs@m.gmane.org; Thu, 11 Dec 2008 13:25:39 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LAqD2-0007Mq-Gu for bug-gnu-emacs@gnu.org; Thu, 11 Dec 2008 13:24:24 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LAqD0-0007KZ-3w for bug-gnu-emacs@gnu.org; Thu, 11 Dec 2008 13:24:23 -0500 Original-Received: from [199.232.76.173] (port=38031 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LAqCz-0007KN-Pn for bug-gnu-emacs@gnu.org; Thu, 11 Dec 2008 13:24:21 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:43591) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LAqCy-00059w-Ro for bug-gnu-emacs@gnu.org; Thu, 11 Dec 2008 13:24:21 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mBBIOIVg026910; Thu, 11 Dec 2008 10:24:18 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id mBBIK3Ok025494; Thu, 11 Dec 2008 10:20:03 -0800 X-Loop: don@donarmstrong.com Resent-From: Dan Nicolaescu Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Thu, 11 Dec 2008 18:20:03 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 1191 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 1191-submit@emacsbugs.donarmstrong.com id=B1191.122901931424327 (code B ref 1191); Thu, 11 Dec 2008 18:20:03 +0000 X-Spam-Bayes: score:0.0000 Tokens: new, 28; hammy, 151; neutral, 229; spammy, 0. spammytokens: hammytokens:0.000-+--emacs, 0.000-+--Emacs, 0.000-+--H*i:message, 0.000-+--H*i:2008, 0.000-+--cvs Original-Received: (at 1191) by emacsbugs.donarmstrong.com; 11 Dec 2008 18:15:14 +0000 Original-Received: from barrelv2.ics.uci.edu (barrelv2.ics.uci.edu [128.195.1.114]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mBBIF9Qs023815 for <1191@emacsbugs.donarmstrong.com>; Thu, 11 Dec 2008 10:15:10 -0800 Original-Received: from mothra.ics.uci.edu (mothra.ics.uci.edu [128.195.6.93]) by barrelv2.ics.uci.edu (8.13.8+Sun/8.13.8) with ESMTP id mBBIEq4N006227; Thu, 11 Dec 2008 10:14:53 -0800 (PST) Original-Received: (from dann@localhost) by mothra.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id mBBIEpki000573; Thu, 11 Dec 2008 10:14:51 -0800 (PST) In-Reply-To: <4941579A.9050603@emvision.com> (Ali Bahrami's message of "Thu, 11 Dec 2008 11:10:34 -0700") Original-Lines: 93 X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: mBBIEq4N006227 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@mothra.ics.uci.edu X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Thu, 11 Dec 2008 13:24:23 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:23192 Archived-At: Ali Bahrami writes: > Dan Nicolaescu wrote: > > Ali Bahrami writes: > > > > > This message is a follow up to one I sent to emacs-devel > > > last July: > > > > > > http://lists.gnu.org/archive/html/emacs-devel/2008-07/msg00070.html > > > > The question had to do with why emacs wasn't using dldump() > > > to produce the dumped executable under Solaris. It had been using it > > > up until 2002, at which point it was commented out, and it wasn't > > > clear why. No one knew the reason, and the consensus was "try it and see". > > > > Since then, I've done some work to integrate emacs with > > > OpenSolaris as a standard package. I turned on dldump(), > > > and have been using the emacs binaries built with it daily > > > since July without issue. > > > > So now, I have some things I'd like to send back up stream > > > and get integrated into the emacs distribution: > > > > - Man pages for things installed to /usr/bin that > > didn't > > > already have a manpage: > > > b2m.1 > > > ebrowse.1 > > > grep-changelog.1 > > > rcs-checkin.1 > > > - Small changes to config.guess and configure to properly > > > detect amd64 hardware running Solaris. > > > - Use dldump() instead of the generic ELF dump code > > > under Solaris. > > > - Use the system malloc under Solaris (at least with > > > amd64, emacs crashes without this). > > > > The manpages can be viewed at: > > > > > > http://src.opensolaris.org/source/xref/sfw/usr/src/cmd/emacs/augment/man/man1/b2m.1 > > > http://src.opensolaris.org/source/xref/sfw/usr/src/cmd/emacs/augment/man/man1/ebrowse.1 > > > http://src.opensolaris.org/source/xref/sfw/usr/src/cmd/emacs/augment/man/man1/grep-changelog.1 > > > http://src.opensolaris.org/source/xref/sfw/usr/src/cmd/emacs/augment/man/man1/rcs-checkin.1 > > > > and the patches at: > > > > > > http://src.opensolaris.org/source/xref/sfw/usr/src/cmd/emacs/augment/patch/config.guess.patch > > > http://src.opensolaris.org/source/xref/sfw/usr/src/cmd/emacs/augment/patch/configure.patch > > > http://src.opensolaris.org/source/xref/sfw/usr/src/cmd/emacs/augment/patch/dldump.patch > > > http://src.opensolaris.org/source/xref/sfw/usr/src/cmd/emacs/augment/patch/sysmalloc.patch > > > > The patches are for emacs 22.1. I've examined 22.3, and the > > > changes are applicable there as well. If 22.1 diffs are OK, > > > that's easiest for me, but if not, then please let me know what > > > I need to supply. These diffs are all very short, affecting a > > > small number of lines in each file. > > > > So my questions: How can I go about submitting these > > changes? > > > Is there someone who might work with me to get this done? > > > What format would you need to get them in, and where can > > > I send them? > > > > Your patches for the Solaris configuration are now in. > > config.guess has been updated from upstream with your changes. > > There's a man page for ebrowse now. > > Not sure what to do about the man pages for b2m, grep-changelog, and > > rcs-checkin. You might want to open a separate bug for them. > > > > Thanks > > > > --dan > > > I'm not sure what I'll do about the manpages, but I don't consider them part of > this bug anymore. > > So, we appear to be done, except for the issue I flagged a couple > of days ago. Ben made a modification to my patch for config.guess > (dropping the use of a fully qualified path for 'echo') that causes > emacs to not build correctly for a Solaris user using the bash shell. > It does build successfully, but will always choose to build a 64-bit binary. > > I sent mail to Ben about it, and we'll see what he says. However, you > should probably hold off on closing things out just yet. Ben made the changes you requested: commit 7086ee26381fdcc645d12c3177ee0be072dd82ef Author: Ben Elliston Date: Thu Dec 11 15:31:45 2008 +1100 * config.guess (i86pc:SunOS:5.*:*, i86xen:SunOS:5.*:*): The full path to /usr/bin/echo is necessary to work around the shell builtins for echo that do not handle newlines. From Ali Bahrami. and those are checked in the emacs CVS now. Is that what you had in mind? If yes, please verify that things work for you now. --dan