From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.bugs Subject: bug#1107: #1107 - 23.0.60; Emacs --daemon crashes when emacsclient tries to establish a connection on OS X - Emacs bug report logs Date: Tue, 9 Dec 2008 22:58:37 -0800 (PST) Message-ID: <200812100658.mBA6wbAA024526@mothra.ics.uci.edu> References: Reply-To: Dan Nicolaescu , 1107@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1228893879 26806 80.91.229.12 (10 Dec 2008 07:24:39 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 10 Dec 2008 07:24:39 +0000 (UTC) Cc: 1107@emacsbugs.donarmstrong.com To: Adrian Robert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Dec 10 08:25:45 2008 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LAJS5-0002az-6i for geb-bug-gnu-emacs@m.gmane.org; Wed, 10 Dec 2008 08:25:45 +0100 Original-Received: from localhost ([127.0.0.1]:57055 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LAJQt-0006ro-Dh for geb-bug-gnu-emacs@m.gmane.org; Wed, 10 Dec 2008 02:24:31 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LAJQp-0006rE-1S for bug-gnu-emacs@gnu.org; Wed, 10 Dec 2008 02:24:27 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LAJQn-0006r2-D8 for bug-gnu-emacs@gnu.org; Wed, 10 Dec 2008 02:24:25 -0500 Original-Received: from [199.232.76.173] (port=42403 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LAJQn-0006qz-70 for bug-gnu-emacs@gnu.org; Wed, 10 Dec 2008 02:24:25 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:35735) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LAJQm-000637-Ph for bug-gnu-emacs@gnu.org; Wed, 10 Dec 2008 02:24:25 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mBA7OH1k019051; Tue, 9 Dec 2008 23:24:17 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id mBA755hh014137; Tue, 9 Dec 2008 23:05:05 -0800 X-Loop: don@donarmstrong.com Resent-From: Dan Nicolaescu Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs , don@donarmstrong.com Resent-Date: Wed, 10 Dec 2008 07:05:05 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 1107 X-Emacs-PR-Package: emacs,ns X-Emacs-PR-Keywords: patch Original-Received: via spool by 1107-submit@emacsbugs.donarmstrong.com id=B1107.122889233311927 (code B ref 1107); Wed, 10 Dec 2008 07:05:05 +0000 X-Spam-Bayes: score:0.0000 Tokens: new, 34; hammy, 133; neutral, 55; spammy, 2. spammytokens:0.972-6--hopes, 0.929-+--chance hammytokens:0.000-+--emacs, 0.000-+--23.0.60, 0.000-+--23060, 0.000-+--Emacs, 0.000-+--H*i:message Original-Received: (at 1107) by emacsbugs.donarmstrong.com; 10 Dec 2008 06:58:53 +0000 Original-Received: from barrelv2.ics.uci.edu (barrelv2.ics.uci.edu [128.195.1.114]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mBA6wodH011911 for <1107@emacsbugs.donarmstrong.com>; Tue, 9 Dec 2008 22:58:51 -0800 Original-Received: from mothra.ics.uci.edu (mothra.ics.uci.edu [128.195.6.93]) by barrelv2.ics.uci.edu (8.13.8+Sun/8.13.8) with ESMTP id mBA6wcTZ028086; Tue, 9 Dec 2008 22:58:38 -0800 (PST) Original-Received: (from dann@localhost) by mothra.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id mBA6wbAA024526; Tue, 9 Dec 2008 22:58:37 -0800 (PST) Mail-Followup-To: 1107@emacsbugs.donarmstrong.com In-Reply-To: (Adrian Robert's message of "Tue, 9 Dec 2008 23:18:01 -0500") Original-Lines: 26 X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: mBA6wcTZ028086 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-0.34, required 5, autolearn=disabled, ALL_TRUSTED -1.44, FM_MULTI_ODD2 1.10) X-ICS-MailScanner-From: dann@mothra.ics.uci.edu X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Wed, 10 Dec 2008 02:24:25 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:23135 Archived-At: Adrian Robert writes: > I have not had the chance to refine my fix so I'm attaching my patch > here in hopes that someone else can work on it. It uses exec() > instead of fork() to launch the child, using a daemon name argument to > differentiate the child. This prevents normal use of the name > argument. Moreover, the pipe connection does not work (not sure why), > so it is disabled. > > Index: src/emacs.c > =================================================================== > RCS file: /sources/emacs/emacs/src/emacs.c,v > retrieving revision 1.456 > diff -u -p -r1.456 emacs.c > --- src/emacs.c 8 Dec 2008 16:22:40 -0000 1.456 > +++ src/emacs.c 10 Dec 2008 04:16:16 -0000 > @@ -1102,21 +1102,26 @@ main (int argc, char **argv) > use a pipe for synchronization. The parent waits for the child > to close its end of the pipe (using `daemon-initialized') > before exiting. */ > +#ifndef HAVE_NS Is this a problem just for MacOSX or also for GNUStep? All these #ifdefs are very ugly, IMHO it would be better to separate the NS functionality in a different function, that way only a single #ifdef is needed here.