From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.bugs Subject: bug#1483: cleanup: replace NO_SOCKETS_IN_FILE_SYSTEM in emacsclient.c Date: Wed, 3 Dec 2008 14:03:45 -0800 (PST) Message-ID: <200812032203.mB3M3jGD028987@mothra.ics.uci.edu> References: <200812030635.mB36Z9mk024296@mothra.ics.uci.edu> <1228291406.49363d4ebc7d8@webmail.freedom2surf.net> <200812031524.mB3FOBqt025290@mothra.ics.uci.edu> <200812031915.mB3JF4ts026816@mothra.ics.uci.edu> Reply-To: Dan Nicolaescu , 1483@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1228342252 16812 80.91.229.12 (3 Dec 2008 22:10:52 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 3 Dec 2008 22:10:52 +0000 (UTC) Cc: 1483@emacsbugs.donarmstrong.com, jasonr@f2s.com To: "Juanma Barranquero" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Dec 03 23:11:55 2008 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1L7zwo-0005VT-2A for geb-bug-gnu-emacs@m.gmane.org; Wed, 03 Dec 2008 23:11:54 +0100 Original-Received: from localhost ([127.0.0.1]:54675 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L7zvd-0002CX-Jo for geb-bug-gnu-emacs@m.gmane.org; Wed, 03 Dec 2008 17:10:41 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L7zvG-00025E-Nt for bug-gnu-emacs@gnu.org; Wed, 03 Dec 2008 17:10:18 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L7zvE-00024O-M8 for bug-gnu-emacs@gnu.org; Wed, 03 Dec 2008 17:10:18 -0500 Original-Received: from [199.232.76.173] (port=48982 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L7zvE-000248-9b for bug-gnu-emacs@gnu.org; Wed, 03 Dec 2008 17:10:16 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:48081) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1L7zvD-0005kd-Kn for bug-gnu-emacs@gnu.org; Wed, 03 Dec 2008 17:10:15 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mB3MADRX030630; Wed, 3 Dec 2008 14:10:13 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id mB3MA4Pm029953; Wed, 3 Dec 2008 14:10:04 -0800 X-Loop: don@donarmstrong.com Resent-From: Dan Nicolaescu Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Wed, 03 Dec 2008 22:10:03 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 1483 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 1483-submit@emacsbugs.donarmstrong.com id=B1483.122834184127826 (code B ref 1483); Wed, 03 Dec 2008 22:10:03 +0000 Original-Received: (at 1483) by emacsbugs.donarmstrong.com; 3 Dec 2008 22:04:01 +0000 Original-Received: from sallyv2.ics.uci.edu (sallyv2.ics.uci.edu [128.195.1.120]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mB3M3wWJ027813 for <1483@emacsbugs.donarmstrong.com>; Wed, 3 Dec 2008 14:03:59 -0800 Original-Received: from mothra.ics.uci.edu (mothra.ics.uci.edu [128.195.6.93]) by sallyv2.ics.uci.edu (8.13.7+Sun/8.13.7) with ESMTP id mB3M3kbb004842; Wed, 3 Dec 2008 14:03:46 -0800 (PST) Original-Received: (from dann@localhost) by mothra.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id mB3M3jGD028987; Wed, 3 Dec 2008 14:03:45 -0800 (PST) In-Reply-To: (Juanma Barranquero's message of "Wed, 3 Dec 2008 22:08:00 +0100") Original-Lines: 42 X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: mB3M3kbb004842 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@mothra.ics.uci.edu X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Wed, 03 Dec 2008 17:10:18 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:22927 Archived-At: "Juanma Barranquero" writes: > On Wed, Dec 3, 2008 at 20:15, Dan Nicolaescu wrote: > > > should only need a single #ifdef. > > Why? Because it's simpler. > > The clear precedent is that WINDOWSNT already encompasses a bazillion > > features, why would a bazillion + 1 won't make any difference? > > As Eli pointed out, we should be moving towards decreasing the > bazillion things conflated into #ifdef WINDOWSNT, not increasing them. Good luck convincing anyone about that. There are 378 undocumented macros in admin/CPP-DEFINES, and probably 1000-2000 in use in src/*, increasing that number does not seem such a hot idea. > > It would > > make a difference for the vast majority of people that write to the > > emacs repository, most do not use windows and can just ignore the #ifdef > > WINDOWSNT code. > > Apparently it's not that confusing. There has been no complain until > now from the people who's hacked on emacsclient. This is not a valid proof. Maybe people didn't want to complain, or didn't figure out the difference, etc. > > On a not so related note, why are there #includes on line 671 in > > emacsclient.c instead of at the beginning of the file? > > Because they affect code inside a big #else which goes from there to > the end of the file. > > They were already there before the TCP socket support, indeed from > version 1.1 of the file (though it was line 49 back then...) Still not too good, and a deviation from the normal style of not having includes in the middle of the file.