unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Dan Nicolaescu <dann@ics.uci.edu>
To: Ali Bahrami <ali_gnu@emvision.com>
Cc: 1191@emacsbugs.donarmstrong.com
Subject: bug#1191: How to contribute back changes for Emacs on Solaris
Date: Thu, 23 Oct 2008 17:22:46 -0700 (PDT)	[thread overview]
Message-ID: <200810240022.m9O0Mki1011139@mothra.ics.uci.edu> (raw)
In-Reply-To: <490106F5.1090708@emvision.com> (Ali Bahrami's message of "Thu, 23 Oct 2008 17:21:25 -0600")

Ali Bahrami <ali_gnu@emvision.com> writes:

  > Dan Nicolaescu wrote:
  > > Ali Bahrami <ali_gnu@emvision.com> writes:
  > ...
  > >   >     % ./config.guess
  > >   >     i386-pc-solaris2.11
  > >   >     % CC='gcc -m64' ./config.guess
  > >   >     amd64-solaris2.11
  > >        ^^^^^^^^^^^^^^^^^^
  > > This does not look right, it needs to be a triplet, not a pair, so amd64-pc-solaris2.11
  > 
  > I found that interesting too, which is one reason I showed that output
  > to Ben in our other discussion. I trust that he'll flag it if its wrong.
  > However, emacs configure is happy with this, so perhaps it's really OK,

IMHO amd64-solaris2 is not a good idea.  config.guess is used by
anything that uses autoconf, there are many many scripts that depend on
having a triple.  What you had to fix in configure.in is just one such
example.

  > I'll fix whatever is needed there.
  > 
  > Isn't the idea of having a "vendor" for instruction sets rather
  > dated? I surely don't care who made my CPU, only what ISA it
  > supports and what OS is running.

Probably, but it's been around for a while, so it's ingrained in many
places... 

  > > BTW, context or unified diffs are preferred here. 
  > 
  > Understood, and I have been sending context diffs until this
  > last one. The bits that got missed made me think that perhaps
  > it was the wrong thing. Sorry, I'll go back to doing that.

The patch did not apply cleanly, I got rejects so I had to hand edit the
change.  Hence the problem, but don't worry about it, it's all good as
long as things move forward.






  reply	other threads:[~2008-10-24  0:22 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200812120309.mBC392kD002742@mothra.ics.uci.edu>
2008-10-17  3:44 ` bug#1191: How to contribute back changes for Emacs on Solaris Ali Bahrami
2008-10-17  6:22   ` Dan Nicolaescu
2008-10-17 16:27     ` Ali Bahrami
2008-10-17 23:52       ` Dan Nicolaescu
2008-10-19  3:18         ` Ali Bahrami
2008-10-20 22:29           ` Dan Nicolaescu
2008-10-23  6:45             ` Ali Bahrami
2008-10-23 16:23               ` Ali Bahrami
2008-10-23 19:35               ` Dan Nicolaescu
2008-10-23 22:51                 ` Ali Bahrami
2008-10-23 23:06                   ` Dan Nicolaescu
2008-10-23 23:21                     ` Ali Bahrami
2008-10-24  0:22                       ` Dan Nicolaescu [this message]
2008-12-11 17:47   ` Dan Nicolaescu
2008-12-11 18:10     ` Ali Bahrami
2008-12-11 18:14       ` Dan Nicolaescu
2008-12-11 18:21         ` Ali Bahrami
2008-12-12  2:55         ` Ali Bahrami
2008-12-12  3:15   ` bug#1191: marked as done (How to contribute back changes for Emacs on Solaris) Emacs bug Tracking System

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200810240022.m9O0Mki1011139@mothra.ics.uci.edu \
    --to=dann@ics.uci.edu \
    --cc=1191@emacsbugs.donarmstrong.com \
    --cc=ali_gnu@emvision.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).