From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#1154: C-x 4 a in struct [] diff does not work anymore Date: Fri, 17 Oct 2008 21:17:50 +0000 Message-ID: <20081017211750.GA2157@muc.de> References: <200810130238.m9D2cut9000668@mothra.ics.uci.edu> Reply-To: Alan Mackenzie , 1154@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1224279055 30162 80.91.229.12 (17 Oct 2008 21:30:55 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 17 Oct 2008 21:30:55 +0000 (UTC) Cc: bug-gnu-emacs@gnu.org To: Dan Nicolaescu , 1154@emacsbugs.donarmstrong.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Oct 17 23:31:55 2008 connect(): Connection refused Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KqwvK-00081S-Ep for geb-bug-gnu-emacs@m.gmane.org; Fri, 17 Oct 2008 23:31:54 +0200 Original-Received: from localhost ([127.0.0.1]:46228 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KqwuF-0003Ge-Cb for geb-bug-gnu-emacs@m.gmane.org; Fri, 17 Oct 2008 17:30:47 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KqwuB-0003Fu-Hu for bug-gnu-emacs@gnu.org; Fri, 17 Oct 2008 17:30:43 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KqwuA-0003Ei-12 for bug-gnu-emacs@gnu.org; Fri, 17 Oct 2008 17:30:43 -0400 Original-Received: from [199.232.76.173] (port=55574 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Kqwu9-0003Ea-Sd for bug-gnu-emacs@gnu.org; Fri, 17 Oct 2008 17:30:41 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:56560) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Kqwu9-0003wF-BV for bug-gnu-emacs@gnu.org; Fri, 17 Oct 2008 17:30:41 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m9HLU03T032369; Fri, 17 Oct 2008 14:30:00 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id m9HLF3OB028859; Fri, 17 Oct 2008 14:15:03 -0700 X-Loop: don@donarmstrong.com Resent-From: Alan Mackenzie Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs , don@donarmstrong.com Resent-Date: Fri, 17 Oct 2008 21:15:02 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 1154 X-Emacs-PR-Package: emacs,cc-mode X-Emacs-PR-Keywords: Original-Received: via spool by submit@emacsbugs.donarmstrong.com id=B.122427774027617 (code B ref -1); Fri, 17 Oct 2008 21:15:02 +0000 Original-Received: (at submit) by emacsbugs.donarmstrong.com; 17 Oct 2008 21:09:00 +0000 Original-Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m9HL8voP027611 for ; Fri, 17 Oct 2008 14:08:58 -0700 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KqwZ6-0005nf-NY for bug-gnu-emacs@gnu.org; Fri, 17 Oct 2008 17:08:56 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KqwZ5-0005mU-9n for bug-gnu-emacs@gnu.org; Fri, 17 Oct 2008 17:08:55 -0400 Original-Received: from [199.232.76.173] (port=47259 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KqwZ4-0005mM-Vt for bug-gnu-emacs@gnu.org; Fri, 17 Oct 2008 17:08:54 -0400 Original-Received: from colin.muc.de ([193.149.48.1]:1106 helo=mail.muc.de) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KqwZ4-00022c-Em for bug-gnu-emacs@gnu.org; Fri, 17 Oct 2008 17:08:54 -0400 Original-Received: (qmail 78186 invoked by uid 3782); 17 Oct 2008 21:08:49 -0000 Original-Received: from acm.muc.de (pD9E53977.dip.t-dialin.net [217.229.57.119]) by colin2.muc.de (tmda-ofmipd) with ESMTP; Fri, 17 Oct 2008 23:08:47 +0200 Original-Received: (qmail 5531 invoked by uid 1000); 17 Oct 2008 21:17:50 -0000 Content-Disposition: inline In-Reply-To: <200810130238.m9D2cut9000668@mothra.ics.uci.edu> User-Agent: Mutt/1.5.9i X-Delivery-Agent: TMDA/1.1.5 (Fettercairn) X-Primary-Address: acm@muc.de X-detected-operating-system: by monty-python.gnu.org: FreeBSD 4.6-4.9 X-CrossAssassin-Score: 2 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Fri, 17 Oct 2008 17:30:43 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:21639 Archived-At: Hi, Dan: I've just commited a fix to ..../lisp/progmodes/cc-cmds.el which fixes the first bug (longopts). I can't reproduce the second bug (C-x 4 a can't find the name for the second hunk). Could you let me know whether or not it's still a problem. Thanks! On Sun, Oct 12, 2008 at 07:38:56PM -0700, Dan Nicolaescu wrote: > For the patch below, with the point on the first + line, C-x 4 a > adds an entry called: > > * emacsclient.c (]): > > emacs-22.2 added the correct entry: > > * emacsclient.c (longopts): > > Also, for the second hunk C-x 4 a cannot find the function name. > > > Index: emacsclient.c > =================================================================== > RCS file: /cvsroot/emacs/emacs/lib-src/emacsclient.c,v > retrieving revision 1.132 > diff -u -3 -p -u -p -r1.132 emacsclient.c > --- emacsclient.c 19 Sep 2008 16:45:12 -0000 1.132 > +++ emacsclient.c 13 Oct 2008 01:34:25 -0000 > @@ -156,6 +156,7 @@ struct option longopts[] = > { "help", no_argument, NULL, 'H' }, > { "version", no_argument, NULL, 'V' }, > { "tty", no_argument, NULL, 't' }, > + { "nw", no_argument, NULL, 't' }, > { "create-frame", no_argument, NULL, 'c' }, > { "alternate-editor", required_argument, NULL, 'a' }, > #ifndef NO_SOCKETS_IN_FILE_SYSTEM > @@ -474,7 +475,7 @@ decode_options (argc, argv) > > while (1) > { > - int opt = getopt_long (argc, argv, > + int opt = getopt_long_only (argc, argv, > #ifndef NO_SOCKETS_IN_FILE_SYSTEM > "VHnea:s:f:d:tc", > #else > -- Alan Mackenzie (Nuremberg, Germany).