unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Peter De Wachter <pdewacht@gmail.com>
To: martin rudalics <rudalics@gmx.at>,
	Chong Yidong <cyd@stupidchicken.com>,
	1039@emacsbugs.donarmstrong.com
Subject: bug#1039: 23.0.60; emacs forgets EOL convention after revert-buffer
Date: Mon, 13 Oct 2008 21:53:42 +0200	[thread overview]
Message-ID: <20081013215342.2be48064@tleilaxu> (raw)
In-Reply-To: <48F2468D.3040705@gmx.at>

On Sun, 12 Oct 2008 20:48:45 +0200
martin rudalics <rudalics@gmx.at> wrote:

>  > That patch fixes the bug I reported, but it creates a new one:
> 
> Are you sure that this worked _before_ my patch?

Hm, I must have tried it with Emacs 22. It doesn't work in 23. Too many
versions to juggle around. Sorry for the confusion.

>  > if you
>  > change the EOL convention outside of emacs, revert-buffer no longer
>  > detects this.
> 
> Indeed.  BTW, can you confirm that when you delete the entire buffer
> text first reverting works correctly?  Unfortunately, I don't

Yes, it works if I clear the buffer first, both with and without your
patch.

> understand this part of `insert-file-contents' at all.  I suppose
> Emacs should redecode when it finds out that the eol-types of the
> buffer and the part of the file it has already read differ.  But
> somehow this doesn't happen.  Handa-san do you have any ideas?

-- 
Peter De Wachter






  reply	other threads:[~2008-10-13 19:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-08 16:15 bug#1039: 23.0.60; emacs forgets EOL convention after revert-buffer Chong Yidong
2008-10-08 18:03 ` martin rudalics
2008-10-11 22:10   ` Peter De Wachter
2008-10-12 18:48     ` martin rudalics
2008-10-13 19:53       ` Peter De Wachter [this message]
  -- strict thread matches above, loose matches on Subject: below --
2009-01-29  4:20 Kenichi Handa
2008-09-27 21:15 Peter De Wachter
2008-09-27 22:12 ` martin rudalics

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081013215342.2be48064@tleilaxu \
    --to=pdewacht@gmail.com \
    --cc=1039@emacsbugs.donarmstrong.com \
    --cc=cyd@stupidchicken.com \
    --cc=rudalics@gmx.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).