bug#576: 23.0.60; displaying SVG leaks memory

bug#576: 23.0.60; displaying SVG leaks memory

[Markus Triska]

The following form makes Emacs use increasingly more memory:

   (progn
     (find-file "~/emacs/etc/images/splash.svg")
     (while t
       (image-toggle-display)
       (redisplay)))

Memory use remains bounded if I instead use e.g. ".../splash8.xpm".

In GNU Emacs 23.0.60.2 (i386-apple-darwin8.11.1, GTK+ Version 2.12.9)
 of 2008-07-17 on mt-computer.local
Windowing system distributor `The XFree86 Project, Inc', version 11.0.40400000
Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: nil
  value of $XMODIFIERS: nil
  locale-coding-system: nil
  default-enable-multibyte-characters: t

bug#576: 23.0.60; displaying SVG leaks memory

[Chong Yidong]

> The following form makes Emacs use increasingly more memory:
>
>   (progn
>     (find-file "~/emacs/etc/images/splash.svg")
>     (while t
>       (image-toggle-display)
>       (redisplay)))

Does the following patch fix the memory leak for you?

*** trunk/src/image.c.~1.106.~	2008-07-22 00:51:50.000000000 -0400
--- trunk/src/image.c	2008-07-25 01:23:04.000000000 -0400
***************
*** 9025,9030 ****
--- 9025,9031 ----
       went ok.  */
    pixbuf = fn_rsvg_handle_get_pixbuf (rsvg_handle);
    eassert (pixbuf);
+   fn_rsvg_handle_free (rsvg_handle);

    /* Extract some meta data from the svg handle.  */
    width     = fn_gdk_pixbuf_get_width (pixbuf);

bug#576: 23.0.60; displaying SVG leaks memory

[Markus Triska]

Chong Yidong <cyd@MIT.EDU> writes:

> Does the following patch fix the memory leak for you?

Yes, thank you!