From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.bugs Subject: bug#308: vc-delete-file Date: Fri, 23 May 2008 14:38:24 -0700 Message-ID: <200805232138.m4NLcPCC026047@sallyv1.ics.uci.edu> References: Reply-To: Dan Nicolaescu , 308@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1211579543 31324 80.91.229.12 (23 May 2008 21:52:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 23 May 2008 21:52:23 +0000 (UTC) Cc: 308@emacsbugs.donarmstrong.com To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri May 23 23:53:01 2008 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JzfBm-0000Ed-Di for geb-bug-gnu-emacs@m.gmane.org; Fri, 23 May 2008 23:52:38 +0200 Original-Received: from localhost ([127.0.0.1]:48326 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JzfB1-0001Ef-SY for geb-bug-gnu-emacs@m.gmane.org; Fri, 23 May 2008 17:51:51 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JzfAx-0001Ea-Im for bug-gnu-emacs@gnu.org; Fri, 23 May 2008 17:51:47 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JzfAv-0001EC-Ri for bug-gnu-emacs@gnu.org; Fri, 23 May 2008 17:51:47 -0400 Original-Received: from [199.232.76.173] (port=52587 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JzfAv-0001E9-Od for bug-gnu-emacs@gnu.org; Fri, 23 May 2008 17:51:45 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:33671) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JzfAv-0007wr-D7 for bug-gnu-emacs@gnu.org; Fri, 23 May 2008 17:51:45 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m4NLpgUQ007427; Fri, 23 May 2008 14:51:43 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id m4NLj3lv005145; Fri, 23 May 2008 14:45:03 -0700 X-Loop: don@donarmstrong.com Resent-From: Dan Nicolaescu Original-Sender: dann@ics.uci.edu Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Fri, 23 May 2008 21:45:03 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 308 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 308-submit@emacsbugs.donarmstrong.com id=B308.12115787903852 (code B ref 308); Fri, 23 May 2008 21:45:03 +0000 Original-Received: (at 308) by emacsbugs.donarmstrong.com; 23 May 2008 21:39:50 +0000 Original-Received: from sallyv1.ics.uci.edu (sallyv1.ics.uci.edu [128.195.1.109]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m4NLdhmC003846 for <308@emacsbugs.donarmstrong.com>; Fri, 23 May 2008 14:39:44 -0700 X-ICS-MailScanner-Watermark: 1212183506.75219@FfLDT91UitOi5lk5xuaOqw Original-Received: from mothra.ics.uci.edu (mothra.ics.uci.edu [128.195.6.93]) by sallyv1.ics.uci.edu (8.13.7+Sun/8.13.7) with ESMTP id m4NLcPCC026047; Fri, 23 May 2008 14:38:25 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Fri, 23 May 2008 17:00:11 -0400") Original-Lines: 28 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@mothra.ics.uci.edu X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) Resent-Date: Fri, 23 May 2008 17:51:47 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:18116 Archived-At: Stefan Monnier writes: > No need to argue that it's a bug, I agree. > [ For what it's worth, I'd recommend you vc-delete-file before doing > your tests, tho. After all, you can always undo it before committing > if it turns out it was a bad idea. ] > > > Debugger entered--Lisp error: (error "File myfilename no longer exists!") > > signal(error ("File myfilename no longer exists!")) > > error("File %s no longer exists!" "myfilename") > > revert-buffer(t t t) > > vc-revert-buffer-internal(t t) > > vc-resynch-window("myfilename" # t) > > vc-resynch-buffer("myfilename" # t) > > vc-delete-file("myfilename") > > call-interactively(vc-delete-file t nil) > > execute-extended-command(nil) > > call-interactively(execute-extended-command nil nil) > > > i.e., you just deleted it yourself - and now you are complaining that > > the file does not exist! > > I would rather expect kill-buffer instead of revert-buffer. > > I've just changed the code to kill the buffer, indeed. That's not quite right, the *vc-dir* buffers where this file might have been displayed need to be updated. I checked in an alternative fix that I've had in my tree and seems to DTRT.