unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Dan Nicolaescu <dann@ics.uci.edu>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 308@emacsbugs.donarmstrong.com
Subject: bug#308: vc-delete-file
Date: Fri, 23 May 2008 14:38:24 -0700	[thread overview]
Message-ID: <200805232138.m4NLcPCC026047@sallyv1.ics.uci.edu> (raw)
In-Reply-To: <jwvk5hk21kh.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Fri, 23 May 2008 17:00:11 -0400")

Stefan Monnier <monnier@iro.umontreal.ca> writes:

  > No need to argue that it's a bug, I agree.
  > [ For what it's worth, I'd recommend you vc-delete-file before doing
  >   your tests, tho.  After all, you can always undo it before committing
  >   if it turns out it was a bad idea.  ]
  > 
  > > Debugger entered--Lisp error: (error "File myfilename no longer exists!")
  > >   signal(error ("File myfilename no longer exists!"))
  > >   error("File %s no longer exists!" "myfilename")
  > >   revert-buffer(t t t)
  > >   vc-revert-buffer-internal(t t)
  > >   vc-resynch-window("myfilename" #<buffer convert_config.mli> t)
  > >   vc-resynch-buffer("myfilename" #<buffer convert_config.mli> t)
  > >   vc-delete-file("myfilename")
  > >   call-interactively(vc-delete-file t nil)
  > >   execute-extended-command(nil)
  > >   call-interactively(execute-extended-command nil nil)
  > 
  > > i.e., you just deleted it yourself - and now you are complaining that
  > > the file does not exist!
  > > I would rather expect kill-buffer instead of revert-buffer.
  > 
  > I've just changed the code to kill the buffer, indeed.

That's not quite right, the *vc-dir* buffers where this file might have
been displayed need to be updated.   I checked in an alternative fix
that I've had in my tree and seems to DTRT.






  reply	other threads:[~2008-05-23 21:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <al8wy1f4bm.fsf@nyc-qws-005.delacy.com>
2008-05-23 21:00 ` bug#308: vc-delete-file Stefan Monnier
2008-05-23 21:38   ` Dan Nicolaescu [this message]
2008-05-24  2:23     ` Stefan Monnier
2008-05-23 15:06 Sam Steingold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200805232138.m4NLcPCC026047@sallyv1.ics.uci.edu \
    --to=dann@ics.uci.edu \
    --cc=308@emacsbugs.donarmstrong.com \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).