Re: Emacs 21.2 -- debugger-frame-offset is 8, should be 6

[Derek Peschel <dpeschel@eskimo.com>]

[-- Attachment #1: Type: text/plain, Size: 148 bytes --]

Sorry, I used mutt with a command line format I don't normally use, and
didn't have a chance to attach the patches and other files.  Here they are.

[-- Attachment #2: debug.el.patch-fix --]
[-- Type: text/plain, Size: 434 bytes --]

--- debug.el	Mon Jan 28 13:10:09 2008
+++ debug.el	Mon Jan 28 13:10:34 2008
@@ -300,7 +300,7 @@
 ;; within the first one that appears in the backtrace buffer.
 ;; Assumes debugger-frame is called from a key;
 ;; will be wrong if it is called with Meta-x.
-(defconst debugger-frame-offset 8 "")
+(defconst debugger-frame-offset 6 "")
 
 (defun debugger-jump ()
   "Continue to exit from this frame, with all debug-on-entry suspended."

[-- Attachment #3: debug.el.patch-test-fix --]
[-- Type: text/plain, Size: 1228 bytes --]

--- debug.el.new	Mon Jan 28 13:23:15 2008
+++ debug.el.new	Mon Jan 28 13:25:05 2008
@@ -300,7 +300,7 @@
 ;; within the first one that appears in the backtrace buffer.
 ;; Assumes debugger-frame is called from a key;
 ;; will be wrong if it is called with Meta-x.
-(defconst debugger-frame-offset 8 "")
+(defconst debugger-frame-offset 6 "")
 
 (defun debugger-jump ()
   "Continue to exit from this frame, with all debug-on-entry suspended."
@@ -379,6 +379,11 @@
 	(insert ? )))
   (beginning-of-line))
 
+(defun debugger-frame-info ()
+  "Show information about the frame at point."
+  (interactive)
+  (beginning-of-line)
+  (message "%s" (prin1-to-string (backtrace-frame (+ (debugger-frame-number) debugger-frame-offset)))))
 
 
 (put 'debugger-env-macro 'lisp-indent-function 0)
@@ -452,6 +457,7 @@
     (define-key debugger-mode-map "j" 'debugger-jump)
     (define-key debugger-mode-map "r" 'debugger-return-value)
     (define-key debugger-mode-map "u" 'debugger-frame-clear)
+    (define-key debugger-mode-map "i" 'debugger-frame-info)
     (define-key debugger-mode-map "d" 'debugger-step-through)
     (define-key debugger-mode-map "l" 'debugger-list-functions)
     (define-key debugger-mode-map "h" 'describe-mode)

[-- Attachment #4: debug.el.patch-test-orig --]
[-- Type: text/plain, Size: 862 bytes --]

--- debug.el	Mon Jan 28 13:23:15 2008
+++ debug.el	Mon Jan 28 13:24:00 2008
@@ -379,6 +379,11 @@
 	(insert ? )))
   (beginning-of-line))
 
+(defun debugger-frame-info ()
+  "Show information about the frame at point."
+  (interactive)
+  (beginning-of-line)
+  (message "%s" (prin1-to-string (backtrace-frame (+ (debugger-frame-number) debugger-frame-offset)))))
 
 
 (put 'debugger-env-macro 'lisp-indent-function 0)
@@ -452,6 +457,7 @@
     (define-key debugger-mode-map "j" 'debugger-jump)
     (define-key debugger-mode-map "r" 'debugger-return-value)
     (define-key debugger-mode-map "u" 'debugger-frame-clear)
+    (define-key debugger-mode-map "i" 'debugger-frame-info)
     (define-key debugger-mode-map "d" 'debugger-step-through)
     (define-key debugger-mode-map "l" 'debugger-list-functions)
     (define-key debugger-mode-map "h" 'describe-mode)

[-- Attachment #5: debugger-frame-offset-test.el --]
[-- Type: text/plain, Size: 223 bytes --]

q(defun fun1 ()
  (fun2))
(defun fun2 ()
  (fun3))
(defun fun3 ()
  (fun4))
(defun fun4 ()
  (fun5))
(defun fun5 ()
  (fun6))
(defun fun6 ()
  (fun7))
(defun fun7 ()
  (fun8))
(defun fun8 ()
  (debug nil "in fun8"))
(fun1)