From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.bugs Subject: Re: Setting term-default-fg-color/term-default-bg-color has no effect Date: Wed, 01 Aug 2007 19:28:40 -0700 Message-ID: <200708020228.l722SeaF022313@oogie-boogie.ics.uci.edu> References: <200708010410.l714Ad7e022199@oogie-boogie.ics.uci.edu> <875463.46907.qm@web57309.mail.re1.yahoo.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1186021858 32043 80.91.229.12 (2 Aug 2007 02:30:58 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 2 Aug 2007 02:30:58 +0000 (UTC) Cc: bug-gnu-emacs@gnu.org To: Peter Povinec Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Aug 02 04:30:51 2007 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IGQSg-0004qL-Pq for geb-bug-gnu-emacs@m.gmane.org; Thu, 02 Aug 2007 04:30:51 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IGQSg-0000yb-6m for geb-bug-gnu-emacs@m.gmane.org; Wed, 01 Aug 2007 22:30:50 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IGQSd-0000y2-C4 for bug-gnu-emacs@gnu.org; Wed, 01 Aug 2007 22:30:47 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IGQSb-0000xe-SD for bug-gnu-emacs@gnu.org; Wed, 01 Aug 2007 22:30:46 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IGQSb-0000xb-MU for bug-gnu-emacs@gnu.org; Wed, 01 Aug 2007 22:30:45 -0400 Original-Received: from oogie-boogie.ics.uci.edu ([128.195.1.41]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IGQSb-0002oE-7n for bug-gnu-emacs@gnu.org; Wed, 01 Aug 2007 22:30:45 -0400 Original-Received: from mothra.ics.uci.edu (mothra.ics.uci.edu [128.195.6.93]) by oogie-boogie.ics.uci.edu (8.13.6/8.13.6) with ESMTP id l722SeaF022313; Wed, 1 Aug 2007 19:28:40 -0700 (PDT) In-Reply-To: <875463.46907.qm@web57309.mail.re1.yahoo.com> (Peter Povinec's message of "Wed\, 1 Aug 2007 17\:50\:43 -0700 \(PDT\)") Original-Lines: 39 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-0.84, required 5, autolearn=disabled, ALL_TRUSTED -1.44, J_CHICKENPOX_42 0.60) X-ICS-MailScanner-From: dann@mothra.ics.uci.edu X-Detected-Kernel: Solaris 9 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:16265 Archived-At: Peter Povinec writes: > > I tested your changes by setting term-default-fg-color to blue and > > term-default-bg-color to red on an emacs run with -Q and comparing > > with running various curses applications in M-x term and "xterm -fg > > blue -bg red". The results are not the same. > Please be specific: what applications and how were the results different? I'd > just like to know. I tried "emacs -nw", all empty lines did not use term-default-bg-color. > > The problem is that the screen is updated in a lot of places in > > term.el not only term-handle-colors-array. So this could not have > > worked correctly in emacs 21 either. > That is quite possible. The patch I submitted was intended to merely remove > the regression in functionality introduced in Emacs 22. I believe it does > that and is useful on its own, whether additional color handling fixes are > applied or not. It's hard to call a regression replacing one type of broken behavior with another type of just slightly different broken behavior. > > Given that AFAIK nothing else in emacs changes the default foreground > > and background for a buffer, it's kind of hard to find a convincing > > argument that such a feature is needed for term.el. It can probably be > > done with some effort, but is it worth the added complexity? Not > > sure... > The additional complexity introduced by the patch is negligible. We can look > at what it would take to fix the other color related issues you have seen, but > if those existed in version 21, I'd say they are separate issues and should be > treated as such. I only see 2 possible fixes for this: either a patch that makes changing the default fg and bg for M-x term work correctly, or simply removing this configurability for the user. Anything else seems to be just busy work. As I said, I am inclined to believe that the right thing to do is the latter.