From: Dan Nicolaescu <dann@ics.uci.edu>
To: Peter Povinec <pp_publiclists@yahoo.com>
Cc: bug-gnu-emacs@gnu.org
Subject: Re: Setting term-default-fg-color/term-default-bg-color has no effect
Date: Tue, 31 Jul 2007 21:10:39 -0700 [thread overview]
Message-ID: <200708010410.l714Ad7e022199@oogie-boogie.ics.uci.edu> (raw)
In-Reply-To: <831335.3790.qm@web57313.mail.re1.yahoo.com> (Peter Povinec's message of "Mon\, 23 Jul 2007 12\:22\:56 -0700 \(PDT\)")
Peter Povinec <pp_publiclists@yahoo.com> writes:
> > Can you please describe exactly what are you doing and how? How did
> > you test your patch?
>
> The basic idea is the same as it was in Emacs 21. Take the user preferences
> in terms of fg/bg colors as stored in term-default-fg-color and
> term-default-bg-color and apply them consistently every time term-current-face
> is set. This is done for the initial value of term-current-face, when the
> terminal is reset in term-reset-terminal, and when the escape sequences
> setting the default fg/bg colors are interpreted in term-handle-color-array.
> Note that this was partially done already in term-handle-color-array, e.g. in
> the case of setting reverse+invisible.
>
> For the testing, I've tested with my color customizations, including colored
> terminal prompt in csh. I verified the reverse video logic by running 'top'
> and 'emacs -nw' inside an ansi-term, both with my customizations, and plain
> emacs. Customizations to term-default-fg-color or term-default-bg-color while
> one or more term sessions are running take effect as expected, e.g. by running
> 'reset'.
I tested your changes by setting term-default-fg-color to blue and
term-default-bg-color to red on an emacs run with -Q and comparing
with running various curses applications in M-x term and "xterm -fg
blue -bg red". The results are not the same.
The problem is that the screen is updated in a lot of places in
term.el not only term-handle-colors-array. So this could not have
worked correctly in emacs 21 either.
Given that AFAIK nothing else in emacs changes the default foreground
and background for a buffer, it's kind of hard to find a convincing
argument that such a feature is needed for term.el. It can probably be
done with some effort, but is it worth the added complexity? Not
sure...
next prev parent reply other threads:[~2007-08-01 4:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-30 0:17 Setting term-default-fg-color/term-default-bg-color has no effect Peter Povinec
2007-07-02 17:28 ` Dan Nicolaescu
2007-07-23 19:22 ` Peter Povinec
2007-08-01 4:10 ` Dan Nicolaescu [this message]
2007-08-02 0:50 ` Peter Povinec
2007-08-02 2:28 ` Dan Nicolaescu
2007-08-03 6:35 ` Peter Povinec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200708010410.l714Ad7e022199@oogie-boogie.ics.uci.edu \
--to=dann@ics.uci.edu \
--cc=bug-gnu-emacs@gnu.org \
--cc=pp_publiclists@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).