vc-next-action-dired fails if file is in a subdirectory

vc-next-action-dired fails if file is in a subdirectory

[Chet Wood]

This bug report will be sent to the Free Software Foundation,
not to your local site managers!
Please write in English, because the Emacs maintainers do not have
translators to read other languages for them.

Your bug report will be posted to the bug-gnu-emacs@gnu.org mailing list,
and to the gnu.emacs.bug news group.

In GNU Emacs 21.3.1 (sparc-sun-solaris2.9, X toolkit)
 of 2004-06-09 on camillia
configured using `configure  --prefix=/import/freetools/local/emacs/21.3-64 --enable-gcc --enable-largefile '--x-libraries=-R/usr/openwin/lib/sparcv9 -R/usr/lib/sparcv9 -L/usr/openwin/lib/sparcv9 -L/usr/lib/sparcv9''
Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: nil
  locale-coding-system: nil
  default-enable-multibyte-characters: t

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:

When using recursive vc-dired with SCCS, and the parent directory
is one or more levels above the directory where the file is, vcdiff
cannot find the file. It expects it to be in the current directory.

The following diffs for vc-next-action-dired seem to fix the immediate
problem, but I don't believe the fix is correct or complete---for
example vc-dired doesn't automatically refresh its state after the
file is checked in.

--- vc.el.~1~	2006-10-27 11:13:51.703361000 -0700
+++ vc.el	2006-10-27 11:46:26.419703000 -0700
@@ -1181,15 +1181,18 @@
 Ignores FILE and REV, but passes on COMMENT."
   (let ((dired-buffer (current-buffer))
 	(dired-dir default-directory))
+    (setq odefault default-directory)
     (dired-map-over-marks
      (let ((file (dired-get-filename)))
        (message "Processing %s..." file)
+       (setq default-directory (file-name-directory file))
        (vc-next-action-on-file file nil comment)
        (set-buffer dired-buffer)
        (set-window-configuration vc-dired-window-configuration)
        (message "Processing %s...done" file))
-    nil t))
-  (dired-move-to-filename))
+     nil t))
+  (dired-move-to-filename)
+  (setq default-directory odefault))
 
 ;; Here's the major entry point.
---------- end of diffs -------------


Recent input:
<backspace> C-a <tab> C-n C-n C-n C-n C-n C-a C-M-n 
C-M-p C-p C-p C-p C-p C-p C-e C-M-p C-x C-s C-x o M-> 
C-p C-n M-p <return> C-p C-p C-p C-p C-p C-p C-p C-p 
C-p C-p C-p C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n 
C-SPC C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p 
C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-a C-SPC C-v 
C-v C-n C-n <escape> w M-x r e p o r t - b SPC t <backspace> 
u SPC <backspace> <backspace> e m SPC SPC <return>

Recent messages:
Wrote /home/cwood/eLisp/vc.el
Mark set
History item: 1
Saving file /home/cwood/eLisp/vc.el...
Wrote /home/cwood/eLisp/vc.el
Mark set
History item: 1
Mark set [2 times]
Saved text from "--- vc.el.~1~	2006-10-27 11:13:51.703361"
Loading emacsbug...done