make in Cygwin fails on compiling callproc.c

make in Cygwin fails on compiling callproc.c

[Maks Romih]

Done the following:

-- got a fresh new machine preinstalled wtih Windows XP Home edition, no Visual C or any development tools
-- installed the newest Cygwin I could get on www
-- in rxvt (a Cygwin console window) unpacked emacs-21.4a.tar.gz
-- mounted the directory with mount -t
-- cd emacs-21.4/nt; ./configure.bat; make

Make fails on file src/callproc.c with conflicting types for egetenv. I look into the sources. I see that the definition of egetenv in lisp.h is guarded with #ifdef USE_CRT_DLL. I try to run the command gcc, as I see it from make, but leave the -IUSE_CRT_DLL=1. It compiles OK and then make goes successfully forward until the end.

I run make install and everything seems OK.

I suggest you repair somehow the condition in #ifdef USE_CRT_DLL in lisp.h to not skip the definition when in Cygwin.

I also miss the information about newer versions of gmake etc. in INSTALL and README and I found the instructions about mounting text!=binary confusing. I had to try both ways and I still don't know if it's important at all.

Some (maybe) useful facts of my installation:

$ uname

CYGWIN_NT-5.1 MAKSRMOB 1.5.21(0.156/4/2) 2006-07-30 14:21 i686 Cygwin

$ gcc -v
Reading specs from /usr/lib/gcc/i686-pc-cygwin/3.4.4/specs
Configured with: /gcc/gcc-3.4.4/gcc-3.4.4-1/configure --verbose --prefix=/usr --exec-prefix=/usr --sysconfdir=/etc --libdir=/usr/lib --libexecdir=/usr/lib --mandir=/usr/share/man --infodir=/usr/share/info --enable-languages=c,ada,c++,d,f77,java,objc --enable-nls --without-included-gettext --enable-version-specific-runtime-libs --without-x --enable-libgcj --disable-java-awt --with-system-zlib --enable-interpreter --disable-libgcj-debug --enable-threads=posix --enable-java-gc=boehm --disable-win32-registry --enable-sjlj-exceptions --enable-hash-synchronization --enable-libstdcxx-debug : (reconfigured) 
Thread model: posix
gcc version 3.4.4 (cygming special) (gdc 0.12, using dmd 0.125)

Re: make in Cygwin fails on compiling callproc.c

[Eli Zaretskii]

> From: Maks Romih <maks.romih@t-2.net>
> Date: Sun,  1 Oct 2006 15:55:52 +0200 (CEST)
> 
> Make fails on file src/callproc.c with conflicting types for egetenv.

Thank you for your report.

This is a known problem with Emacs 21.4; it is already fixed in the
development sources.

> I look into the sources. I see that the definition of egetenv in lisp.h is guarded with #ifdef USE_CRT_DLL. I try to run the command gcc, as I see it from make, but leave the -IUSE_CRT_DLL=1. It compiles OK and then make goes successfully forward until the end.

This is not the right fix; you _must_ define USE_CRT_DLL for the
Windows build.

The correct fix is this:

--- emacs-21.4/src/callproc.c~	2002-07-09 06:02:36.000000000 +0300
+++ emacs-21.4/src/callproc.c	2006-07-21 19:45:03.226000000 +0300
@@ -981,6 +981,8 @@ delete_temp_file (name)
   return Qnil;
 }
 
+char *egetenv (char *);
+
 DEFUN ("call-process-region", Fcall_process_region, Scall_process_region,
   3, MANY, 0,
   "Send text from START to END to a synchronous process running PROGRAM.\n\


> I suggest you repair somehow the condition in #ifdef USE_CRT_DLL in lisp.h to not skip the definition when in Cygwin.

You didn't build a Cygwin version of Emacs; you built a native Windows
version with the Cygwin tools.

To build a Cygwin version, you should use the ``normal'' Unix way: run
the configure script from the top-level directory (not
nt/configure.bat), then run "make" and "make install" from that
top-level directory.

> I also miss the information about newer versions of gmake etc. in INSTALL and README and I found the instructions about mounting text!=binary confusing. I had to try both ways and I still don't know if it's important at all.

The files nt/README and nt/INSTALL were changed a lot since 21.4; in
particular, they were updated with information about the latest
versions of Make and other utilities.  I attach the current files
below; please see if the new text is clear.

nt/README:

	     Emacs for Windows NT/2000 and Windows 95/98/ME

  Copyright (C) 2001, 2002, 2003, 2004, 2005,
     2006 Free Software Foundation, Inc.
  See the end of the INSTALL file in this directory for copying permissions.

  This directory contains support for compiling and running GNU Emacs on
  Windows NT, Windows 95, and their successors.  This port supports all
  of the major functionality of the Unix version, including
  subprocesses, windowing features (fonts, colors, scroll bars, multiple
  frames, etc.), and networking support.

  Precompiled distributions are also available; ftp to

	ftp://ftp.gnu.org/gnu/windows/emacs/latest/

  for the latest precompiled distributions.

* Building and installing

  See the INSTALL file in this directory for detailed instructions on
  building and installing Emacs on your system.

* Further information

  There is a web page that serves as a FAQ for the Windows port of
  Emacs (a.k.a. NTEmacs) at:

	http://www.gnu.org/software/emacs/windows/ntemacs.html

  There is also a mailing list for discussing issues related to this
  port of Emacs.  For information about the list, see this Web page:

	http://mail.gnu.org/mailman/listinfo/help-emacs-windows

  To ask questions on the mailing list, send email to
  help-emacs-windows@gnu.org.  (You don't need to subscribe for that.)
  To subscribe to the list or unsubscribe from it, fill the form you
  find at http://mail.gnu.org/mailman/listinfo/help-emacs-windows as
  explained there.

  Another valuable source of information and help which should not be
  overlooked is the various Usenet news groups dedicated to Emacs.
  These are particularly good for help with general issues which aren't
  specific to the Windows port of Emacs.  The main news groups to use
  for seeking help are:

	gnu.emacs.help
	comp.emacs

  There are also fairly regular postings and announcements of new or
  updated Emacs packages on this group:

	gnu.emacs.sources

* Reporting bugs

  If you encounter a bug in this port of Emacs, we would like to hear
  about it.  First check the file etc/PROBLEMS and the FAQ on the web
  page above to see if the bug is already known and if there are any
  workarounds.  If not, then check whether the bug has something to do
  with code in your .emacs file, e.g. by invoking Emacs with the "-q
  --no-site-file" options.

  If you decide that it is a bug in Emacs that might be specific to the
  Windows port, send a message to the help-emacs-windows@gnu.org
  mailing list describing the bug, the version of Emacs that you are
  using, and the operating system that you are running on (Windows NT,
  95 or 98 including service pack level if known).  If the bug is
  related to subprocesses, also specify which shell you are using (e.g.,
  include the values of `shell-file-name' and `shell-explicit-file-name'
  in your message).

  If you think the bug is not specific to the Windows port of Emacs,
  then it is better to mail the bug report to bug-gnu-emacs@gnu.org so
  that it will be seen by the right people.  If Emacs has been set up to
  send mail, you can use the command M-x report-emacs-bug to create and
  send the bug report, but in some cases there is a function to report
  bugs in a specific package; e.g. M-x gnus-bug for Gnus, M-x
  c-submit-bug-report for C/C++/Java mode, etc.


nt/INSTALL:

		      Building and Installing Emacs
		on Windows NT/2K/XP and Windows 95/98/ME

  Copyright (C) 2001, 2002, 2003, 2004, 2005, 2006
    Free Software Foundation, Inc.
  See the end of the file for copying permissions.

* For the impatient

  Here are the concise instructions for configuring and building the
  native Win32 binary of Emacs on Windows, for those who want to skip
  the complex explanations and ``just do it'':

  1. Change to the `nt' directory (the directory of this file):

       cd nt

  2. Run configure.bat.  From the COMMAND.COM/CMD.EXE command prompt:

       configure

     from a Unixy shell prompt:

       cmd /c configure.bat
     or
       command.com /c configure.bat

  3. Run the Make utility suitable for your environment.  If you build
     with the Microsoft's Visual C compiler:

       nmake

     For the development environments based on GNU GCC (MinGW, MSYS,
     Cygwin - but see notes about Cygwin make below), depending on how
     Make is called, it could be:

       make
     or
       mingw32-make
     or
       gnumake
     or
       gmake

     (If you are building from CVS, say "make bootstrap" or "nmake
     bootstrap" instead and avoid using Cygwin make.)

  4. Generate the Info manuals (only if you are building out of CVS, and
     if you have makeinfo.exe installed):

     make info

     (change "make" to "nmake" if you use MSVC).

  5. Install the produced binaries:

     make install

  That's it!

  If these short instructions somehow fail, read the rest of this
  file.

* Preliminaries

  If you used WinZip to unpack the distribution, we suggest to
  remove the files and unpack again with a different program!
  WinZip is known to create some subtle and hard to debug problems,
  such as converting files to DOS CR-LF format, not creating empty
  directories, etc.  We suggest to use djtarnt.exe from the GNU FTP
  site.

  If you are building out of CVS, then some files in this directory
  (.bat files, nmake.defs and makefile.w32-in) may need the line-ends
  fixing first. The easiest way to do this and avoid future conflicts
  is to run the following command in this (emacs/nt) directory:

     cvs update -kb

  Alternatively, use programs that convert end-of-line format, such as
  dos2unix and unix2dos available from GnuWin32 or dtou and utod from
  the DJGPP project.

  In addition to this file, you should also read INSTALL.CVS in the
  parent directory, and make sure that you have a version of
  "touch.exe" in your path, and that it will create files that do not
  yet exist.

* Supported development environments

  To compile Emacs, you will need either Microsoft Visual C++ 2.0 or
  later and nmake, or a Windows port of GCC 2.95 or later with MinGW
  and W32 API support and a port of GNU Make.  You can use the Cygwin
  ports of GCC, but Emacs requires the MinGW headers and libraries to
  build (latest versions of the Cygwin toolkit, at least since v1.3.3,
  include the MinGW headers and libraries as an integral part).

  The rest of this file assumes you have a working development
  environment.  If you just installed  such an environment, try
  building a trivial C "Hello world" program, and see if it works.  If
  it doesn't work, resolve that problem first!

  If you use the MinGW port of GCC and GNU Make to build Emacs, there
  are some compatibility issues wrt Make and the shell that is run by
  Make, either the standard COMMAND.COM/CMD.EXE supplied with Windows
  or sh.exe., a port of a Unixy shell.  For reference, here is a list
  of which builds of GNU Make are known to work or not, and whether
  they work in the presence and/or absence of sh.exe, the Cygwin port
  of Bash. Note that any version of Make that is compiled with Cygwin
  will only work with Cygwin tools, due to the use of cygwin style
  paths.  This means Cygwin Make is unsuitable for building parts of
  Emacs that need to invoke Emacs itself (leim and "make bootstrap",
  for example).  Also see the Trouble-shooting section below if you
  decide to go ahead and use Cygwin make.

  In addition, using 4NT as your shell is known to fail the build process,
  at least for 4NT version 3.01.  Use CMD.EXE, the default Windows shell,
  instead. MSYS sh.exe also appears to cause various problems. If you have
  MSYS installed, try "make SHELL=cmd.exe" to force the use of cmd.exe
  instead of sh.exe.

                                         sh exists     no sh

    cygwin b20.1 make (3.75):            fails[1, 5]   fails[2, 5]
    MSVC compiled gmake 3.77:            okay          okay
    MSVC compiled gmake 3.78.1:          okay          okay
    MSVC compiled gmake 3.79.1:          okay          okay
    mingw32/gcc-2.92.2 make (3.77):      okay          okay[4]
    cygwin compiled gmake 3.77:          fails[1, 5]   fails[2, 5]
    cygwin compiled make 3.78.1:         fails[5]      fails[2, 5]
    cygwin compiled make 3.79.1:         fails[3, 5]   fails[2?, 5]
    mingw32 compiled make 3.79.1:        okay          okay
    mingw32 compiled make 3.80:          okay          unknown[6]
    mingw32 compiled make 3.81:          okay          okay[7]

  Notes:

    [1] doesn't cope with makefiles with DOS line endings, so must mount
        emacs source with text!=binary.
    [2] fails when needs to invoke shell commands; okay invoking gcc etc.
    [3] requires LC_MESSAGES support to build; cannot build with early
        versions of cygwin.
    [4] may fail on Windows 9X and Windows ME; if so, install Bash.
    [5] fails when building leim due to the use of cygwin style paths.
        May work if building emacs without leim.
    [6] please report if you try this combination.
    [7] tested only on Windows XP.

  Other compilers may work, but specific reports from people that have
  tried suggest that the Intel C compiler (for example) may produce an
  Emacs executable with strange filename completion behaviour.  Unless
  you would like to assist by finding and fixing the cause of any bugs
  like this, we recommend the use of the supported compilers mentioned
  in the previous paragraph.

  You will also need a copy of the Posix cp, rm and mv programs.  These
  and other useful Posix utilities can be obtained from one of several
  projects:

  * http://gnuwin32.sourceforge.net/              ( GnuWin32 )
  * http://www.mingw.org/                         ( MinGW    )
  * http://www.cygwin.com/                        ( Cygwin   )
  * http://unxutils.sourceforge.net/              ( UnxUtils )

  If you build Emacs on Windows 9X or ME, not on Windows 2K/XP or
  Windows NT, we suggest to install the Cygwin port of Bash.  That is
  because the native Windows shell COMMAND.COM is too limited; the
  Emacs build procedure tries very hard to support even such limited
  shells, but as none of the Windows developers of Emacs work on
  Windows 9x, we cannot guarantee that it works without a more
  powerful shell.

  Additional instructions and help for building Emacs on Windows can be
  found at the Emacs Wiki:

    http://www.emacswiki.org/cgi-bin/wiki/WThirtyTwoInstallationKit

  and at this URL:

    http://ourcomments.org/Emacs/w32-build-emacs.html

* Configuring

  Configuration of Emacs is now handled by running configure.bat in the
  `nt' subdirectory.  It will detect which compiler you have available,
  and generate makefiles accordingly.  You can override the compiler
  detection, and control optimization and debug settings, by specifying
  options on the command line when invoking configure.

  To configure Emacs to build with GCC or MSVC, whichever is available,
  simply change to the `nt' subdirectory and run `configure.bat' with no
  options.  To see what options are available, run `configure --help'.

  N.B.  It is normal to see a few error messages output while configure
  is running, when gcc support is being tested.  These cannot be
  surpressed because of limitations in the Windows 9x command.com shell.

  You are encouraged to look at the file config.log which shows details
  for failed tests, after configure.bat finishes.  Any unexplained failure
  should be investigated and perhaps reported as a bug (see the section
  about reporting bugs in the file README in this directory and in the
  Emacs manual).

* Optional image library support

  In addition to its "native" image formats (pbm and xbm), Emacs can
  handle other image types: xpm, tiff, gif, png and jpeg (postscript is
  currently unsupported on Windows).  To build Emacs with support for
  them, the corresponding headers must be in the include path when the
  configure script is run.  This can be setup using environment
  variables, or by specifying --cflags -I... options on the command-line
  to configure.bat.  The configure script will report whether it was
  able to detect the headers.  If the results of this testing appear to be
  incorrect, please look for details in the file config.log: it will show
  the failed test programs and compiler error messages that should explain
  what is wrong.  (Usually, any such failures happen because some headers
  are missing due to bad packaging of the image support libraries.)

  To use the external image support, the DLLs implementing the
  functionality must be found when Emacs first needs them, either on the
  PATH, or in the same directory as emacs.exe.  Failure to find a
  library is not an error; the associated image format will simply be
  unavailable.  Note that once Emacs has determined that a library can
  not be found, there's no way to force it to try again, other than
  restarting.  See the variable `image-library-alist' to configure the
  expected names of the libraries.

  Some image libraries have dependencies on one another, or on zlib.
  For example, tiff support depends on the jpeg library.  If you did not
  compile the libraries yourself, you must make sure that any dependency
  is in the PATH or otherwise accesible and that the binaries are
  compatible (for example, that they were built with the same compiler).

  Binaries for the image libraries (among many others) can be found at
  the GnuWin32 project.  These are built with MinGW, but they can be
  used with both GCC/MinGW and MSVC builds of Emacs.  See the info on
  http://ourcomments.org/Emacs/EmacsW32.html for more details about
  installing image support libraries.

* Building

  After running configure, simply run the appropriate `make' program for
  your compiler to build Emacs.  For MSVC, this is nmake; for GCC, it is
  GNU make.  (If you are building out of CVS, say "make bootstrap" or
  "nmake bootstrap" instead.)

  As the files are compiled, you will see some warning messages
  declaring that some functions don't return a value, or that some data
  conversions will be lossy, etc.  You can safely ignore these messages.
  The warnings may be fixed in the main FSF source at some point, but
  until then we will just live with them.

  If you are building from CVS, the following commands will produce
  the Info manuals (which are not part of the CVS repository):

    make info
  or
    nmake info

  Note that you will need makeinfo.exe (from the GNU Texinfo package)
  in order for this command to succeed.

* Installing

  To install Emacs after it has compiled, simply run `nmake install'
  or `make install', depending on which version of the Make utility
  do you have.

  By default, Emacs will be installed in the location where it was
  built, but a different location can be specified either using the
  --prefix option to configure, or by setting INSTALL_DIR when running
  make, like so:

     make install INSTALL_DIR=D:/emacs

  (for `nmake', type "nmake install INSTALL_DIR=D:/emacs" instead).

  The install process will run addpm to setup the registry entries, and
  to create a Start menu icon for Emacs.

* Trouble-shooting

  The main problems that are likely to be encountered when building
  Emacs stem from using an old version of GCC, or old MinGW or W32 API
  headers.  Additionally, cygwin ports of GNU make may require the Emacs
  source tree to be mounted with text!=binary, because the makefiles
  generated by configure.bat necessarily use DOS line endings.  Also,
  cygwin ports of make must run in UNIX mode, either by specifying
  --unix on the command line, or MAKE_MODE=UNIX in the environment.

  When configure runs, it attempts to detect when GCC itself, or the
  headers it is using, are not suitable for building Emacs.  GCC version
  2.95 or later is needed, because that is when the Windows port gained
  sufficient support for anonymous structs and unions to cope with some
  definitions from winnt.h that are used by addsection.c.  The W32 API
  headers that come with Cygwin b20.1 are incomplete, and do not include
  some definitions required by addsection.c, for instance.  Also, older
  releases of the W32 API headers from Anders Norlander contain a typo
  in the definition of IMAGE_FIRST_SECTION in winnt.h, which
  addsection.c relies on.  Versions of w32api-xxx.zip from at least
  1999-11-18 onwards are okay.

  When in doubt about correctness of what configure did, look at the file
  config.log, which shows all the failed test programs and compiler
  messages associated with the failures.  If that doesn't give a clue,
  please report the problems, together with the relevant fragments from
  config.log, as bugs.

  If configure succeeds, but make fails, install the Cygwin port of
  Bash, even if the table above indicates that Emacs should be able to
  build without sh.exe.  (Some versions of Windows shells are too dumb
  for Makefile's used by Emacs.)

  If you are using certain Cygwin builds of GCC, such as Cygwin version
  1.1.8, you may need to specify some extra compiler flags like so:

    configure --with-gcc --cflags -mwin32 --cflags -D__MSVCRT__
      --ldflags -mwin32

  However, the latest Cygwin versions, such as 1.3.3, don't need those
  switches; you can simply use "configure --with-gcc".

  We will attempt to auto-detect the need for these flags in a future
  release.

* Debugging

  You should be able to debug Emacs using the debugger that is
  appropriate for the compiler you used, namely DevStudio or Windbg if
  compiled with MSVC, or GDB if compiled with GCC.

  When Emacs aborts due to a fatal internal error, Emacs on Windows
  pops up an Emacs Abort Dialog asking you whether you want to debug
  Emacs or terminate it.  If Emacs was built with MSVC, click YES
  twice, and Windbg or the DevStudio debugger will start up
  automatically.  If Emacs was built with GCC, first start GDB and
  attach it to the Emacs process with the "gdb -p EMACS-PID" command,
  where EMACS-PID is the Emacs process ID (which you can see in the
  Windows Task Manager), type the "continue" command inside GDB, and
  only then click YES on the abort dialog.  This will pass control to
  the debugger, and you will be able to debug the cause of the fatal
  error.

  Emacs functions implemented in C use a naming convention that reflects
  their names in lisp.  The names of the C routines are the lisp names
  prefixed with 'F', and with dashes converted to underscores.  For
  example, the function call-process is implemented in C by
  Fcall_process.  Similarly, lisp variables are prefixed with 'V', again
  with dashes converted to underscores.  These conventions enable you to
  easily set breakpoints or examine familiar lisp variables by name.

  Since Emacs data is often in the form of a lisp object, and the
  Lisp_Object type is difficult to examine manually in a debugger,
  Emacs provides a helper routine called debug_print that prints out a
  readable representation of a Lisp_Object.  If you are using GDB,
  there is a .gdbinit file in the src directory which provides
  definitions that are useful for examining lisp objects.  Therefore,
  the following tips are mainly of interest when using MSVC.

  The output from debug_print is sent to stderr, and to the debugger
  via the OutputDebugString routine.  The output sent to stderr should
  be displayed in the console window that was opened when the
  emacs.exe executable was started.  The output sent to the debugger
  should be displayed in its "Debug" output window.

  When you are in the process of debugging Emacs and you would like to
  examine the contents of a Lisp_Object variable, popup the QuickWatch
  window (QuickWatch has an eyeglass symbol on its button in the
  toolbar).  In the text field at the top of the window, enter
  debug_print(<variable>) and hit return.  For example, start and run
  Emacs in the debugger until it is waiting for user input.  Then click
  on the Break button in the debugger to halt execution.  Emacs should
  halt in ZwUserGetMessage waiting for an input event.  Use the Call
  Stack window to select the procedure w32_msp_pump up the call stack
  (see below for why you have to do this).  Open the QuickWatch window
  and enter debug_print(Vexec_path).  Evaluating this expression will
  then print out the contents of the lisp variable exec-path.

  If QuickWatch reports that the symbol is unknown, then check the call
  stack in the Call Stack window.  If the selected frame in the call
  stack is not an Emacs procedure, then the debugger won't recognize
  Emacs symbols.  Instead, select a frame that is inside an Emacs
  procedure and try using debug_print again.

  If QuickWatch invokes debug_print but nothing happens, then check the
  thread that is selected in the debugger.  If the selected thread is
  not the last thread to run (the "current" thread), then it cannot be
  used to execute debug_print.  Use the Debug menu to select the current
  thread and try using debug_print again.  Note that the debugger halts
  execution (e.g., due to a breakpoint) in the context of the current
  thread, so this should only be a problem if you've explicitly switched
  threads.

COPYING PERMISSIONS

  Permission is granted to anyone to make or distribute verbatim copies
  of this document as received, in any medium, provided that the
  copyright notice and permission notice are preserved,
  and that the distributor grants the recipient permission
  for further redistribution as permitted by this notice.

  Permission is granted to distribute modified versions
  of this document, or of portions of it,
  under the above conditions, provided also that they
  carry prominent notices stating who last changed them,
  and that any new or changed statements about the activities
  of the Free Software Foundation are approved by the Foundation.