From: Alexander Pohoyda <alexander.pohoyda@gmx.net>
Subject: Patch: Re: man.el should avoid "sh"
Date: Sun, 2 May 2004 13:57:04 +0200 (CEST) [thread overview]
Message-ID: <200405021157.i42Bv4aR000523@oak.pohoyda.family> (raw)
In-Reply-To: mailman.318.1082156069.1061.bug-gnu-emacs@gnu.org
Kevin Rodgers <ihs_4664@yahoo.com> writes:
> Max Polk wrote:
> > Running emacs in Windows, by typing "M-x man ls" I get an error
> > message that "sh" is not found.
> >
> > Here's a minor fix for man.el, line 618:
> >
> > - (start-process manual-program buffer "sh" "-c"
> > + (start-process manual-program buffer shell-file-name "-c"
> >
> > This replaces the hard-coded "sh" with the variable shell-file-name.
> > Notice that just below this shell-file-name is used and not "sh" so
> > maybe it got fixed in one place but not the other.
>
> You should also replace "-c" with shell-command-switch.
Thanks to Kevin and Max.
Here's a diff to install:
Index: man.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/man.el,v
retrieving revision 1.133
diff -u -r1.133 man.el
--- man.el 23 Mar 2004 07:33:39 -0000 1.133
+++ man.el 2 May 2004 11:46:55 -0000
@@ -732,11 +732,13 @@
(setenv "GROFF_NO_SGR" "1")
(if (fboundp 'start-process)
(set-process-sentinel
- (start-process manual-program buffer "sh" "-c"
+ (start-process manual-program buffer
+ shell-file-name shell-command-switch
(format (Man-build-man-command) man-args))
'Man-bgproc-sentinel)
(let ((exit-status
- (call-process shell-file-name nil (list buffer nil) nil "-c"
+ (call-process shell-file-name nil (list buffer nil) nil
+ shell-command-switch
(format (Man-build-man-command) man-args)))
(msg ""))
(or (and (numberp exit-status)
And ChangeLog entry:
2004-05-02 Alexander Pohoyda <alexander.pohoyda@gmx.net> (tiny change)
* man.el (Man-getpage-in-background): Use shell-file-name
and shell-command-switch variables instead of hard-coded
values.
--
Alexander Pohoyda <alexander.pohoyda@gmx.net>
PGP Key fingerprint: 7F C9 CC 5A 75 CD 89 72 15 54 5F 62 20 23 C6 44
prev parent reply other threads:[~2004-05-02 11:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <mailman.311.1082139976.1061.bug-gnu-emacs@gnu.org>
2004-04-16 22:53 ` man.el should avoid "sh" Kevin Rodgers
[not found] ` <mailman.318.1082156069.1061.bug-gnu-emacs@gnu.org>
2004-05-02 11:57 ` Alexander Pohoyda [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200405021157.i42Bv4aR000523@oak.pohoyda.family \
--to=alexander.pohoyda@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).