* compile.el compile-goto-error bug
@ 2002-12-12 5:00 Gustav Hållberg
0 siblings, 0 replies; only message in thread
From: Gustav Hållberg @ 2002-12-12 5:00 UTC (permalink / raw)
This bug exists in emacs 21.1.4 (and just about every older version I've seen).
When using compile-goto-error from compile.el, the compilation buffer is
erroneously marked as modified, since there is a call to add-text-properties.
This is very annoying if compilation-minor-mode is used on a regular file
(rather than *compilation* buffer).
Suggested patch:
--- /usr/local/emacs/emacs-21.1/share/emacs/21.1/lisp/progmodes/compile.el Wed Sep 19 22:59:24 2001
+++ compile.el Thu Dec 12 05:58:59 2002
@@ -1315,6 +1315,7 @@
(let ((inhibit-read-only t)
(buffer-undo-list t)
deactivate-mark
+ (buffer-was-modified (buffer-modified-p))
(error-list compilation-error-list))
(while error-list
(save-excursion
@@ -1322,7 +1323,8 @@
(progn (end-of-line) (point))
'(mouse-face highlight help-echo "\
mouse-2: visit this file and line")))
- (setq error-list (cdr error-list))))
+ (setq error-list (cdr error-list)))
+ (set-buffer-modified-p buffer-was-modified))
)))))
(defun compile-mouse-goto-error (event)
- Gustav
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2002-12-12 5:00 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-12-12 5:00 compile.el compile-goto-error bug Gustav Hållberg
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).