Problem in fileio.c on Windows NT

Problem in fileio.c on Windows NT

[William Sobel]

GNU Emacs 21.2.1 (i386-msvc-nt4.0.1381) of 2002-10-15 on SOBELNT

I found this problem in 21.1 and never got around to reporting it. It
appears to still exist in 21.2. I have taken the source release from
the ftp site, so I am not sure exactly what the file version is. 

The problem occurred in gnus with setting time of the file. I was
wondering if this is the intended logic, if the keep_time variable is
not nil I would think you would want to copy the times, otherwise do
nothing. The code reads that if keep time is NIL then reset the time.

Hope this helps,
Will Sobel


*** fileio.c.old	Tue Oct 15 17:23:30 2002
--- fileio.c	Tue Oct 15 17:22:15 2002
***************
*** 2339,2345 ****
  		 XSTRING (encoded_newname)->data, 
  		 FALSE))
      report_file_error ("Copying file", Fcons (file, Fcons (newname, Qnil)));
!   else if (NILP (keep_time))
      {
        EMACS_TIME now;
        DWORD attributes;
--- 2339,2345 ----
  		 XSTRING (encoded_newname)->data, 
  		 FALSE))
      report_file_error ("Copying file", Fcons (file, Fcons (newname, Qnil)));
!   else if (!NILP (keep_time))
      {
        EMACS_TIME now;
        DWORD attributes;

Re: Problem in fileio.c on Windows NT

[Richard Stallman]

Thanks for the fix.